diff mbox series

[1/3] vulkan-headers: upgrade to 1.3.249

Message ID 20230502195932.2196823-1-ross.burton@arm.com
State New
Headers show
Series [1/3] vulkan-headers: upgrade to 1.3.249 | expand

Commit Message

Ross Burton May 2, 2023, 7:59 p.m. UTC
---
 ...{vulkan-headers_1.3.239.0.bb => vulkan-headers_1.3.249.0.bb} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-graphics/vulkan/{vulkan-headers_1.3.239.0.bb => vulkan-headers_1.3.249.0.bb} (94%)

Comments

Alexander Kanavin May 3, 2023, 8:37 a.m. UTC | #1
Please respect the upstream version check; vulkan should be updated to
sdk-x.y.z versions, which currently means 1.3.243.

Alex


On Tue, 2 May 2023 at 21:59, Ross Burton <ross.burton@arm.com> wrote:
>
> ---
>  ...{vulkan-headers_1.3.239.0.bb => vulkan-headers_1.3.249.0.bb} | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename meta/recipes-graphics/vulkan/{vulkan-headers_1.3.239.0.bb => vulkan-headers_1.3.249.0.bb} (94%)
>
> diff --git a/meta/recipes-graphics/vulkan/vulkan-headers_1.3.239.0.bb b/meta/recipes-graphics/vulkan/vulkan-headers_1.3.249.0.bb
> similarity index 94%
> rename from meta/recipes-graphics/vulkan/vulkan-headers_1.3.239.0.bb
> rename to meta/recipes-graphics/vulkan/vulkan-headers_1.3.249.0.bb
> index a6b30fa8310..ea6312133ca 100644
> --- a/meta/recipes-graphics/vulkan/vulkan-headers_1.3.239.0.bb
> +++ b/meta/recipes-graphics/vulkan/vulkan-headers_1.3.249.0.bb
> @@ -11,7 +11,7 @@ LICENSE = "Apache-2.0"
>  LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=3b83ef96387f14655fc854ddc3c6bd57"
>  SRC_URI = "git://github.com/KhronosGroup/Vulkan-Headers.git;branch=main;protocol=https"
>
> -SRCREV = "2bb0a23104ceffd9a28d5b7401f2cee7dae35bb8"
> +SRCREV = "870a531486f77dfaf124395de80ed38867400d31"
>
>  S = "${WORKDIR}/git"
>
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#180766): https://lists.openembedded.org/g/openembedded-core/message/180766
> Mute This Topic: https://lists.openembedded.org/mt/98647309/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Ross Burton May 3, 2023, 8:39 a.m. UTC | #2
On 3 May 2023, at 09:37, Alexander Kanavin <alex.kanavin@gmail.com> wrote:
> 
> Please respect the upstream version check; vulkan should be updated to
> sdk-x.y.z versions, which currently means 1.3.243.

If that’s a policy and not just because of historical branch structure, please add a comment explaining this to the recipes.

Ross
Alexander Kanavin May 3, 2023, 8:47 a.m. UTC | #3
On Wed, 3 May 2023 at 10:39, Ross Burton <Ross.Burton@arm.com> wrote:
> > Please respect the upstream version check; vulkan should be updated to
> > sdk-x.y.z versions, which currently means 1.3.243.
>
> If that’s a policy and not just because of historical branch structure, please add a comment explaining this to the recipes.

Vulkan items need to be updated in lockstep with things like glslang,
and those only get tags for vulkan sdk releases:
https://github.com/KhronosGroup/glslang/tags

Also, there's less upgrade churn that way, as we can skip over many
intermediate development versions that happen weekly or more often.

I'll add a comment, but checking the version with devtool and then
performing the upgrade with it would've done the correct thing.

Alex
Jose Quaresma May 3, 2023, 10:02 a.m. UTC | #4
Hi,

Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia quarta,
3/05/2023 à(s) 09:47:

> On Wed, 3 May 2023 at 10:39, Ross Burton <Ross.Burton@arm.com> wrote:
> > > Please respect the upstream version check; vulkan should be updated to
> > > sdk-x.y.z versions, which currently means 1.3.243.
> >
> > If that’s a policy and not just because of historical branch structure,
> please add a comment explaining this to the recipes.
>
> Vulkan items need to be updated in lockstep with things like glslang,
> and those only get tags for vulkan sdk releases:
> https://github.com/KhronosGroup/glslang/tags
>
>
The spirv-headers and the spirv-tools usually also go together with the
vulkan update.

https://github.com/KhronosGroup/SPIRV-Headers/tags
https://github.com/KhronosGroup/SPIRV-Tools/tags

Jose

Also, there's less upgrade churn that way, as we can skip over many
> intermediate development versions that happen weekly or more often.
>
> I'll add a comment, but checking the version with devtool and then
> performing the upgrade with it would've done the correct thing.
>
> Alex
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#180789):
> https://lists.openembedded.org/g/openembedded-core/message/180789
> Mute This Topic: https://lists.openembedded.org/mt/98647309/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta/recipes-graphics/vulkan/vulkan-headers_1.3.239.0.bb b/meta/recipes-graphics/vulkan/vulkan-headers_1.3.249.0.bb
similarity index 94%
rename from meta/recipes-graphics/vulkan/vulkan-headers_1.3.239.0.bb
rename to meta/recipes-graphics/vulkan/vulkan-headers_1.3.249.0.bb
index a6b30fa8310..ea6312133ca 100644
--- a/meta/recipes-graphics/vulkan/vulkan-headers_1.3.239.0.bb
+++ b/meta/recipes-graphics/vulkan/vulkan-headers_1.3.249.0.bb
@@ -11,7 +11,7 @@  LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=3b83ef96387f14655fc854ddc3c6bd57"
 SRC_URI = "git://github.com/KhronosGroup/Vulkan-Headers.git;branch=main;protocol=https"
 
-SRCREV = "2bb0a23104ceffd9a28d5b7401f2cee7dae35bb8"
+SRCREV = "870a531486f77dfaf124395de80ed38867400d31"
 
 S = "${WORKDIR}/git"