diff mbox series

[v3] python3-calver: Add recipe

Message ID 20230502174529.2262518-1-tgamblin@baylibre.com
State Under Review
Headers show
Series [v3] python3-calver: Add recipe | expand

Commit Message

Trevor Gamblin May 2, 2023, 5:45 p.m. UTC
calver is "a setuptools extension for automatically defining your Python
package version as a calendar version." It is required for
python3-trove-classifiers (another new recipe), which in turn is
required for the upgrade of python3-hatchling from 1.13.0 to work.

v3 clarifies that the recipe now includes ptests, where v2 didn't make
this clear and v1 didn't have them at all.

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
---
 .../distro/include/ptest-packagelists.inc     |  1 +
 .../python/python3-calver_2022.6.26.bb        | 28 +++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-calver_2022.6.26.bb

Comments

Peter Kjellerstedt May 2, 2023, 10:40 p.m. UTC | #1
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Trevor Gamblin
> Sent: den 2 maj 2023 19:45
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core][PATCH v3] python3-calver: Add recipe
> 
> calver is "a setuptools extension for automatically defining your Python
> package version as a calendar version." It is required for
> python3-trove-classifiers (another new recipe), which in turn is
> required for the upgrade of python3-hatchling from 1.13.0 to work.
> 
> v3 clarifies that the recipe now includes ptests, where v2 didn't make
> this clear and v1 didn't have them at all.

Comments related to the patch versions should go after the "---" below 
as they will otherwise become part of the commit message, where they 
typically do not make any sense.

> 
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> ---
>  .../distro/include/ptest-packagelists.inc     |  1 +
>  .../python/python3-calver_2022.6.26.bb        | 28 +++++++++++++++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 meta/recipes-devtools/python/python3-calver_2022.6.26.bb
> 
> diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
> index 2f83132aeb..bd95a13ff6 100644
> --- a/meta/conf/distro/include/ptest-packagelists.inc
> +++ b/meta/conf/distro/include/ptest-packagelists.inc
> @@ -56,6 +56,7 @@ PTESTS_FAST = "\
>      popt \
>      python3-atomicwrites \
>      python3-bcrypt \
> +    python3-calver \
>      python3-hypothesis \
>      python3-jinja2 \
>      python3-jsonpointer \
> diff --git a/meta/recipes-devtools/python/python3-calver_2022.6.26.bb b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
> new file mode 100644
> index 0000000000..32b6cfbd42
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
> @@ -0,0 +1,28 @@
> +SUMMARY = "Setuptools extension for CalVer package versions"
> +HOMEPAGE = "https://github.com/di/calver"
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> +
> +SRC_URI = " \
> +    git://github.com/di/calver;branch=master;protocol=https \
> +    file://run-ptest \
> +"
> +SRC_URI[sha256sum] = "e05493a3b17517ef1748fbe610da11f10485faa7c416b9d33fd4a52d74894f8b"

This recipe uses Git, and thus should not need a SHA-256 checksum.

> +SRCREV ?= "3268d8acf2c345f32a1c5f08ba25dc67f76cca81"

Change `?=` to `=`.

> +
> +inherit python_setuptools_build_meta ptest
> +
> +S = "${WORKDIR}/git"
> +
> +RDEPENDS:${PN}-ptest += " \
> +    ${PYTHON_PN}-pretend \
> +    ${PYTHON_PN}-pytest \
> +    ${PYTHON_PN}-unittest-automake-output \
> +"
> +
> +do_install_ptest() {
> +    install -d ${D}${PTEST_PATH}/tests
> +    cp -rf ${S}/tests ${D}${PTEST_PATH}/

Shell code in OE-Core is expected to be tab-indented.

> +}
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.40.0

//Peter
Trevor Gamblin May 5, 2023, 6:51 p.m. UTC | #2
On 2023-05-02 18:40, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Trevor Gamblin
>> Sent: den 2 maj 2023 19:45
>> To: openembedded-core@lists.openembedded.org
>> Subject: [OE-core][PATCH v3] python3-calver: Add recipe
>>
>> calver is "a setuptools extension for automatically defining your Python
>> package version as a calendar version." It is required for
>> python3-trove-classifiers (another new recipe), which in turn is
>> required for the upgrade of python3-hatchling from 1.13.0 to work.
>>
>> v3 clarifies that the recipe now includes ptests, where v2 didn't make
>> this clear and v1 didn't have them at all.
> Comments related to the patch versions should go after the "---" below
> as they will otherwise become part of the commit message, where they
> typically do not make any sense.

Sorry, missed this earlier. I've resent with the revision notes moved.

-Trevor

>
>> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
>> ---
>>   .../distro/include/ptest-packagelists.inc     |  1 +
>>   .../python/python3-calver_2022.6.26.bb        | 28 +++++++++++++++++++
>>   2 files changed, 29 insertions(+)
>>   create mode 100644 meta/recipes-devtools/python/python3-calver_2022.6.26.bb
>>
>> diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
>> index 2f83132aeb..bd95a13ff6 100644
>> --- a/meta/conf/distro/include/ptest-packagelists.inc
>> +++ b/meta/conf/distro/include/ptest-packagelists.inc
>> @@ -56,6 +56,7 @@ PTESTS_FAST = "\
>>       popt \
>>       python3-atomicwrites \
>>       python3-bcrypt \
>> +    python3-calver \
>>       python3-hypothesis \
>>       python3-jinja2 \
>>       python3-jsonpointer \
>> diff --git a/meta/recipes-devtools/python/python3-calver_2022.6.26.bb b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
>> new file mode 100644
>> index 0000000000..32b6cfbd42
>> --- /dev/null
>> +++ b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
>> @@ -0,0 +1,28 @@
>> +SUMMARY = "Setuptools extension for CalVer package versions"
>> +HOMEPAGE = "https://github.com/di/calver"
>> +LICENSE = "Apache-2.0"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
>> +
>> +SRC_URI = " \
>> +    git://github.com/di/calver;branch=master;protocol=https \
>> +    file://run-ptest \
>> +"
>> +SRC_URI[sha256sum] = "e05493a3b17517ef1748fbe610da11f10485faa7c416b9d33fd4a52d74894f8b"
> This recipe uses Git, and thus should not need a SHA-256 checksum.
>
>> +SRCREV ?= "3268d8acf2c345f32a1c5f08ba25dc67f76cca81"
> Change `?=` to `=`.
>
>> +
>> +inherit python_setuptools_build_meta ptest
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +RDEPENDS:${PN}-ptest += " \
>> +    ${PYTHON_PN}-pretend \
>> +    ${PYTHON_PN}-pytest \
>> +    ${PYTHON_PN}-unittest-automake-output \
>> +"
>> +
>> +do_install_ptest() {
>> +    install -d ${D}${PTEST_PATH}/tests
>> +    cp -rf ${S}/tests ${D}${PTEST_PATH}/
> Shell code in OE-Core is expected to be tab-indented.
>
>> +}
>> +
>> +BBCLASSEXTEND = "native nativesdk"
>> --
>> 2.40.0
> //Peter
>
Peter Kjellerstedt May 5, 2023, 9:34 p.m. UTC | #3
> -----Original Message-----
> From: Trevor Gamblin <tgamblin@baylibre.com>
> Sent: den 5 maj 2023 20:52
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][PATCH v3] python3-calver: Add recipe
> 
> On 2023-05-02 18:40, Peter Kjellerstedt wrote:
> >> -----Original Message-----
> >> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Trevor Gamblin
> >> Sent: den 2 maj 2023 19:45
> >> To: openembedded-core@lists.openembedded.org
> >> Subject: [OE-core][PATCH v3] python3-calver: Add recipe
> >>
> >> calver is "a setuptools extension for automatically defining your Python
> >> package version as a calendar version." It is required for
> >> python3-trove-classifiers (another new recipe), which in turn is
> >> required for the upgrade of python3-hatchling from 1.13.0 to work.
> >>
> >> v3 clarifies that the recipe now includes ptests, where v2 didn't make
> >> this clear and v1 didn't have them at all.
> > Comments related to the patch versions should go after the "---" below
> > as they will otherwise become part of the commit message, where they
> > typically do not make any sense.
> 
> Sorry, missed this earlier. I've resent with the revision notes moved.

I also think you missed the comments below as they were not addressed 
in v5. ;)

> 
> -Trevor
> 
> >
> >> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> >> ---
> >>   .../distro/include/ptest-packagelists.inc     |  1 +
> >>   .../python/python3-calver_2022.6.26.bb        | 28 +++++++++++++++++++
> >>   2 files changed, 29 insertions(+)
> >>   create mode 100644 meta/recipes-devtools/python/python3-calver_2022.6.26.bb
> >>
> >> diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
> >> index 2f83132aeb..bd95a13ff6 100644
> >> --- a/meta/conf/distro/include/ptest-packagelists.inc
> >> +++ b/meta/conf/distro/include/ptest-packagelists.inc
> >> @@ -56,6 +56,7 @@ PTESTS_FAST = "\
> >>       popt \
> >>       python3-atomicwrites \
> >>       python3-bcrypt \
> >> +    python3-calver \
> >>       python3-hypothesis \
> >>       python3-jinja2 \
> >>       python3-jsonpointer \
> >> diff --git a/meta/recipes-devtools/python/python3-calver_2022.6.26.bb b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
> >> new file mode 100644
> >> index 0000000000..32b6cfbd42
> >> --- /dev/null
> >> +++ b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
> >> @@ -0,0 +1,28 @@
> >> +SUMMARY = "Setuptools extension for CalVer package versions"
> >> +HOMEPAGE = "https://github.com/di/calver"
> >> +LICENSE = "Apache-2.0"
> >> +LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
> >> +
> >> +SRC_URI = " \
> >> +    git://github.com/di/calver;branch=master;protocol=https \
> >> +    file://run-ptest \
> >> +"
> >> +SRC_URI[sha256sum] = "e05493a3b17517ef1748fbe610da11f10485faa7c416b9d33fd4a52d74894f8b"
> >
> > This recipe uses Git, and thus should not need a SHA-256 checksum.
> >
> >> +SRCREV ?= "3268d8acf2c345f32a1c5f08ba25dc67f76cca81"
> >
> > Change `?=` to `=`.
> >
> >> +
> >> +inherit python_setuptools_build_meta ptest
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +RDEPENDS:${PN}-ptest += " \
> >> +    ${PYTHON_PN}-pretend \
> >> +    ${PYTHON_PN}-pytest \
> >> +    ${PYTHON_PN}-unittest-automake-output \
> >> +"
> >> +
> >> +do_install_ptest() {
> >> +    install -d ${D}${PTEST_PATH}/tests
> >> +    cp -rf ${S}/tests ${D}${PTEST_PATH}/
> >
> > Shell code in OE-Core is expected to be tab-indented.
> >
> >> +}
> >> +
> >> +BBCLASSEXTEND = "native nativesdk"
> >> --
> >> 2.40.0
> >
> > //Peter

//Peter
diff mbox series

Patch

diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index 2f83132aeb..bd95a13ff6 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -56,6 +56,7 @@  PTESTS_FAST = "\
     popt \
     python3-atomicwrites \
     python3-bcrypt \
+    python3-calver \
     python3-hypothesis \
     python3-jinja2 \
     python3-jsonpointer \
diff --git a/meta/recipes-devtools/python/python3-calver_2022.6.26.bb b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
new file mode 100644
index 0000000000..32b6cfbd42
--- /dev/null
+++ b/meta/recipes-devtools/python/python3-calver_2022.6.26.bb
@@ -0,0 +1,28 @@ 
+SUMMARY = "Setuptools extension for CalVer package versions"
+HOMEPAGE = "https://github.com/di/calver"
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57"
+
+SRC_URI = " \
+    git://github.com/di/calver;branch=master;protocol=https \
+    file://run-ptest \
+"
+SRC_URI[sha256sum] = "e05493a3b17517ef1748fbe610da11f10485faa7c416b9d33fd4a52d74894f8b"
+SRCREV ?= "3268d8acf2c345f32a1c5f08ba25dc67f76cca81"
+
+inherit python_setuptools_build_meta ptest
+
+S = "${WORKDIR}/git"
+
+RDEPENDS:${PN}-ptest += " \
+    ${PYTHON_PN}-pretend \
+    ${PYTHON_PN}-pytest \
+    ${PYTHON_PN}-unittest-automake-output \
+"
+
+do_install_ptest() {
+    install -d ${D}${PTEST_PATH}/tests
+    cp -rf ${S}/tests ${D}${PTEST_PATH}/
+}
+
+BBCLASSEXTEND = "native nativesdk"