| Message ID | 20230413103109.5604-2-jamin_lin@aspeedtech.com |
|---|---|
| State | New |
| Headers | show |
| Series | kernel-fitimage/uboot-sign: support 64bits address | expand |
Hello Jamin, thank you for your contribution! On Thu, 13 Apr 2023 18:31:08 +0800 "Jamin Lin" <jamin_lin@aspeedtech.com> wrote: > The default value of address-cells is "1", so the generated "its" file > only supports 32bits address for kernel FIT image. > However, some platforms may want to support 64bits address > of UBOOT_LOADADDRESS and UBOOT_ENTRYPOINT. > Therefore, adds a variable to support both 64bits and 32bits address cells. > > By default, the address-cell is "1" which is used for 32bits load address. > If users would like to use 64bits load address, users are able to > set as following for "0x400000000" 64bits load address. > 1. FIT_ADDRESS_CELLS = "2" > 2. UBOOT_LOADADDRESS= "0x04 0x00000000" > > (From OE-Core rev: f79046d082f3a7752e6780b2990470dcd36cbba4) This line should not be there. It looks like you generated your patches from a poky repository where this patch landed via combo-layers, but it just doesn't make sense as an oe-core patch. Also, that SHA-1 does not exist in the public oe-core repository. I removed that line while applying the patch for testing, so you don't need to resend for this time, but please make sure you generate your patches from an oe-core repository in the future. The same applies to patch 2/2. Best regards, Luca
Thanks for your review and correct me. I should create a patch based on an openembedded-core repository rather than a poky repository.
diff --git a/meta/classes-recipe/kernel-fitimage.bbclass b/meta/classes-recipe/kernel-fitimage.bbclass index b77747404f..d294f28d17 100644 --- a/meta/classes-recipe/kernel-fitimage.bbclass +++ b/meta/classes-recipe/kernel-fitimage.bbclass @@ -92,6 +92,10 @@ FIT_SUPPORTED_INITRAMFS_FSTYPES ?= "cpio.lz4 cpio.lzo cpio.lzma cpio.xz cpio.zst # Allow user to select the default DTB for FIT image when multiple dtb's exists. FIT_CONF_DEFAULT_DTB ?= "" +# length of address in number of <u32> cells +# ex: 1 32bits address, 2 64bits address +FIT_ADDRESS_CELLS ?= "1" + # Keys used to sign individually image nodes. # The keys to sign image nodes must be different from those used to sign # configuration nodes, otherwise the "required" property, from @@ -110,7 +114,7 @@ fitimage_emit_fit_header() { / { description = "${FIT_DESC}"; - #address-cells = <1>; + #address-cells = <${FIT_ADDRESS_CELLS}>; EOF }
The default value of address-cells is "1", so the generated "its" file only supports 32bits address for kernel FIT image. However, some platforms may want to support 64bits address of UBOOT_LOADADDRESS and UBOOT_ENTRYPOINT. Therefore, adds a variable to support both 64bits and 32bits address cells. By default, the address-cell is "1" which is used for 32bits load address. If users would like to use 64bits load address, users are able to set as following for "0x400000000" 64bits load address. 1. FIT_ADDRESS_CELLS = "2" 2. UBOOT_LOADADDRESS= "0x04 0x00000000" (From OE-Core rev: f79046d082f3a7752e6780b2990470dcd36cbba4) Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- meta/classes-recipe/kernel-fitimage.bbclass | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)