diff mbox series

ref-manual: Fix invalid feature name

Message ID 20230219143133.66511-1-niko.mauno@vaisala.com
State New
Headers show
Series ref-manual: Fix invalid feature name | expand

Commit Message

Niko Mauno Feb. 19, 2023, 2:31 p.m. UTC
Replace the invalid feature name with correct one which helps to avoid
following bitbake error

  ERROR: Nothing PROVIDES 'core-image-minimal'
  core-image-minimal was skipped: 'empty-root-passwd' in IMAGE_FEATURES (added via EXTRA_IMAGE_FEATURES) is not a valid image feature.

Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
---
 documentation/ref-manual/features.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz Feb. 20, 2023, 9:20 a.m. UTC | #1
Hi Niko,

This should be sent to the docs mailing list instead 
(docs@lists.yoctoproject.org). Cc'ing now.

On 2/19/23 15:31, Niko Mauno via lists.openembedded.org wrote:
> Replace the invalid feature name with correct one which helps to avoid
> following bitbake error
> 
>    ERROR: Nothing PROVIDES 'core-image-minimal'
>    core-image-minimal was skipped: 'empty-root-passwd' in IMAGE_FEATURES (added via EXTRA_IMAGE_FEATURES) is not a valid image feature.
> 
> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>

Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>

@Michael, this typo seems to have landed in langdale too so probably a 
candidate for backport.

Cheers,
Quentin
Michael Opdenacker Feb. 20, 2023, 5:45 p.m. UTC | #2
Hi Nico,

On 20.02.23 at 10:20, Quentin Schulz via lists.openembedded.org wrote:
> Hi Niko,
>
> This should be sent to the docs mailing list instead 
> (docs@lists.yoctoproject.org). Cc'ing now.


Thanks for the patch!
You also have an issue with the way your e-mails are received here. Here 
is a workaround:
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity

I fixed the commit manually, but doing this will help for next time.

>
> On 2/19/23 15:31, Niko Mauno via lists.openembedded.org wrote:
>> Replace the invalid feature name with correct one which helps to avoid
>> following bitbake error
>>
>>    ERROR: Nothing PROVIDES 'core-image-minimal'
>>    core-image-minimal was skipped: 'empty-root-passwd' in 
>> IMAGE_FEATURES (added via EXTRA_IMAGE_FEATURES) is not a valid image 
>> feature.
>>
>> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
>
> Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>


Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
... and merged into "master-next".

>
> @Michael, this typo seems to have landed in langdale too so probably a 
> candidate for backport.


Correct. I submitted a backport patch. Thanks!

Cheers
Michael.
Niko Mauno Feb. 21, 2023, 10:32 a.m. UTC | #3
On 20.2.2023 19.45, Michael Opdenacker wrote:
> 
> Thanks for the patch!
> You also have an issue with the way your e-mails are received here. Here 
> is a workaround:
> https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity
> 
> I fixed the commit manually, but doing this will help for next time.

Thanks for pointing the issue Michael, I've now applied the mitigation.
BR, Niko
diff mbox series

Patch

diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
index 794a6fd15b..051bf9320a 100644
--- a/documentation/ref-manual/features.rst
+++ b/documentation/ref-manual/features.rst
@@ -294,11 +294,11 @@  Here are the image features available for all images:
    forced in ``/etc/passwd`` and ``/etc/shadow`` if such files exist.
 
    .. note::
-       ``empty-root-passwd`` doesn't set an empty root password by itself.
+       ``empty-root-password`` doesn't set an empty root password by itself.
        You get an initial empty root password thanks to the
        :oe_git:`base-passwd </openembedded-core/tree/meta/recipes-core/base-passwd/>`
        and :oe_git:`shadow </openembedded-core/tree/meta/recipes-extended/shadow/>`
-       recipes, and the presence of ``empty-root-passwd`` or ``debug-tweaks``
+       recipes, and the presence of ``empty-root-password`` or ``debug-tweaks``
        just disables the mechanism which forces an non-empty password for the
        root user.