diff mbox series

[2/3] libc-locale: Fix on target locale generation

Message ID 20230204114133.1178502-2-richard.purdie@linuxfoundation.org
State New
Headers show
Series [1/3,v2] perf: Enable debug/source packaging | expand

Commit Message

Richard Purdie Feb. 4, 2023, 11:41 a.m. UTC
If on target locale generation is used, it fails at first boot showing
errors about a missing directory. Ensure the directory exists.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes-recipe/libc-package.bbclass | 1 +
 1 file changed, 1 insertion(+)

Comments

Khem Raj Feb. 5, 2023, 1:07 a.m. UTC | #1
On Sat, Feb 4, 2023 at 3:41 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> If on target locale generation is used, it fails at first boot showing
> errors about a missing directory. Ensure the directory exists.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes-recipe/libc-package.bbclass | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes-recipe/libc-package.bbclass b/meta/classes-recipe/libc-package.bbclass
> index de3d4223a8c..8a99f73ae72 100644
> --- a/meta/classes-recipe/libc-package.bbclass
> +++ b/meta/classes-recipe/libc-package.bbclass
> @@ -51,6 +51,7 @@ PACKAGE_NO_GCONV ?= "0"
>  OVERRIDES:append = ":${TARGET_ARCH}-${TARGET_OS}"
>
>  locale_base_postinst_ontarget() {
> +mkdir ${libdir}/locale

should it be mkdir -p for when it does exist beforehand ?

>  localedef --inputfile=${datadir}/i18n/locales/%s --charmap=%s %s
>  }
>
> --
> 2.37.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#176760): https://lists.openembedded.org/g/openembedded-core/message/176760
> Mute This Topic: https://lists.openembedded.org/mt/96742036/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Richard Purdie Feb. 5, 2023, 8:19 a.m. UTC | #2
On Sat, 2023-02-04 at 17:07 -0800, Khem Raj wrote:
> On Sat, Feb 4, 2023 at 3:41 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > If on target locale generation is used, it fails at first boot showing
> > errors about a missing directory. Ensure the directory exists.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/classes-recipe/libc-package.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta/classes-recipe/libc-package.bbclass b/meta/classes-recipe/libc-package.bbclass
> > index de3d4223a8c..8a99f73ae72 100644
> > --- a/meta/classes-recipe/libc-package.bbclass
> > +++ b/meta/classes-recipe/libc-package.bbclass
> > @@ -51,6 +51,7 @@ PACKAGE_NO_GCONV ?= "0"
> >  OVERRIDES:append = ":${TARGET_ARCH}-${TARGET_OS}"
> > 
> >  locale_base_postinst_ontarget() {
> > +mkdir ${libdir}/locale
> 
> should it be mkdir -p for when it does exist beforehand ?

I wondered about that, then I wondered about portability with a minimal
busybox and decided libdir likely will exist...

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/classes-recipe/libc-package.bbclass b/meta/classes-recipe/libc-package.bbclass
index de3d4223a8c..8a99f73ae72 100644
--- a/meta/classes-recipe/libc-package.bbclass
+++ b/meta/classes-recipe/libc-package.bbclass
@@ -51,6 +51,7 @@  PACKAGE_NO_GCONV ?= "0"
 OVERRIDES:append = ":${TARGET_ARCH}-${TARGET_OS}"
 
 locale_base_postinst_ontarget() {
+mkdir ${libdir}/locale
 localedef --inputfile=${datadir}/i18n/locales/%s --charmap=%s %s
 }