| Message ID | 20230128233021.2230473-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | nghttp2: Always enable python bindings | expand |
I have sent a v2, please disregard this one. On Sat, Jan 28, 2023 at 3:30 PM Khem Raj <raj.khem@gmail.com> wrote: > > This makes the build host agnostic, otherwise on some hosts e.g. (archlinux) > it ends up using cython compiler from build host, mixing python3-native > and cython from host is not a tested combination and can result in > obscure errors. Lets make it use cython from OE native packages and also > enable the bindings explicitly. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-support/nghttp2/nghttp2_1.51.0.bb | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb b/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb > index fc1a592200..4402b80d1a 100644 > --- a/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb > +++ b/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb > @@ -4,6 +4,8 @@ SECTION = "libs" > LICENSE = "MIT" > LIC_FILES_CHKSUM = "file://COPYING;md5=764abdf30b2eadd37ce47dcbce0ea1ec" > > +DEPENDS += "python3-cython-native" > + > SRC_URI = "\ > ${GITHUB_BASE_URI}/download/v${PV}/nghttp2-${PV}.tar.xz \ > file://0001-fetch-ocsp-response-use-python3.patch \ > @@ -15,7 +17,7 @@ PACKAGECONFIG[manpages] = "" > > # examples are never installed, and don't need to be built in the > # first place > -EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF" > +EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF -DENABLE_PYTHON_BINDINGS=ON" > > PACKAGES =+ "lib${BPN} ${PN}-client ${PN}-proxy ${PN}-server" > > -- > 2.39.1 >
diff --git a/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb b/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb index fc1a592200..4402b80d1a 100644 --- a/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb +++ b/meta/recipes-support/nghttp2/nghttp2_1.51.0.bb @@ -4,6 +4,8 @@ SECTION = "libs" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://COPYING;md5=764abdf30b2eadd37ce47dcbce0ea1ec" +DEPENDS += "python3-cython-native" + SRC_URI = "\ ${GITHUB_BASE_URI}/download/v${PV}/nghttp2-${PV}.tar.xz \ file://0001-fetch-ocsp-response-use-python3.patch \ @@ -15,7 +17,7 @@ PACKAGECONFIG[manpages] = "" # examples are never installed, and don't need to be built in the # first place -EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF" +EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF -DENABLE_PYTHON_BINDINGS=ON" PACKAGES =+ "lib${BPN} ${PN}-client ${PN}-proxy ${PN}-server"
This makes the build host agnostic, otherwise on some hosts e.g. (archlinux) it ends up using cython compiler from build host, mixing python3-native and cython from host is not a tested combination and can result in obscure errors. Lets make it use cython from OE native packages and also enable the bindings explicitly. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-support/nghttp2/nghttp2_1.51.0.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)