| Message ID | 20230116164325.289867-1-f_l_k@t-online.de |
|---|---|
| State | New |
| Headers | show |
| Series | neard: dont pull in wpa-supplicant unconditionally | expand |
On Mon, 2023-01-16 at 17:43 +0100, Markus Volk wrote: > Signed-off-by: Markus Volk <f_l_k@t-online.de> > --- > meta/recipes-connectivity/neard/neard_0.18.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-connectivity/neard/neard_0.18.bb b/meta/recipes-connectivity/neard/neard_0.18.bb > index 23e999acc4..17dbfc4378 100644 > --- a/meta/recipes-connectivity/neard/neard_0.18.bb > +++ b/meta/recipes-connectivity/neard/neard_0.18.bb > @@ -42,7 +42,7 @@ RDEPENDS:${PN} = "dbus" > # Bluez & Wifi are not mandatory except for handover > RRECOMMENDS:${PN} = "\ > ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ > - ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ > + ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','${WIRELESS_DAEMON}', '', d)} \ > " > > INITSCRIPT_NAME = "neard" That isn't going to work as there is no default value for WIRELESS_DAEMON ? Cheers, Richard
We have it set here <https://git.yoctoproject.org/poky/commit/?id=1eaf64fbe16d2ceb472623c65c961b36aee33608> Am Mo, 16. Jan 2023 um 16:47:16 +0000 schrieb Richard Purdie <richard.purdie@linuxfoundation.org>: > On Mon, 2023-01-16 at 17:43 +0100, Markus Volk wrote: >> Signed-off-by: Markus Volk <f_l_k@t-online.de >> <mailto:f_l_k@t-online.de>> >> --- >> meta/recipes-connectivity/neard/neard_0.18.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-connectivity/neard/neard_0.18.bb >> b/meta/recipes-connectivity/neard/neard_0.18.bb >> index 23e999acc4..17dbfc4378 100644 >> --- a/meta/recipes-connectivity/neard/neard_0.18.bb >> +++ b/meta/recipes-connectivity/neard/neard_0.18.bb >> @@ -42,7 +42,7 @@ RDEPENDS:${PN} = "dbus" >> # Bluez & Wifi are not mandatory except for handover >> RRECOMMENDS:${PN} = "\ >> ${@bb.utils.contains >> <mailto:${@bb.utils.contains>('DISTRO_FEATURES', 'bluetooth', >> 'bluez5', '', d)} \ >> - ${@bb.utils.contains >> <mailto:${@bb.utils.contains>('DISTRO_FEATURES', >> 'wifi','wpa-supplicant', '', d)} \ >> + ${@bb.utils.contains >> <mailto:${@bb.utils.contains>('DISTRO_FEATURES', >> 'wifi','${WIRELESS_DAEMON}', '', d)} \ >> " >> >> INITSCRIPT_NAME = "neard" > > That isn't going to work as there is no default value for > WIRELESS_DAEMON ? > > Cheers, > > Richard > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#176004): > <https://lists.openembedded.org/g/openembedded-core/message/176004> > Mute This Topic: <https://lists.openembedded.org/mt/96310274/3618223> > Group Owner: openembedded-core+owner@lists.openembedded.org > <mailto:openembedded-core+owner@lists.openembedded.org> > Unsubscribe: > <https://lists.openembedded.org/g/openembedded-core/unsub> > [f_l_k@t-online.de <mailto:f_l_k@t-online.de>] > -=-=-=-=-=-=-=-=-=-=-=- >
On Mon, 2023-01-16 at 17:49 +0100, Markus Volk wrote: > > That isn't going to work as there is no default value for > > WIRELESS_DAEMON ? > > > > We have it set here > > https://git.yoctoproject.org/poky/commit/?id=1eaf64fbe16d2ceb472623c65c961b36aee33608 > Sure, but the neard recipe can't see in the packagegroup-base recipe scope? Cheers, Richard
Yes, that's right, of course. What would be the preferred way to deal with this. The dependency on wpa-supplicant is a bit annoying. Should I use a bbappend to remove it, or is the RRECOMMEND on wpa-supplicant perhaps removable from the neard recipe? Am Mo, 16. Jan 2023 um 17:03:09 +0000 schrieb Richard Purdie <richard.purdie@linuxfoundation.org>: > On Mon, 2023-01-16 at 17:49 +0100, Markus Volk wrote: > >> > That isn't going to work as there is no default value for >> > WIRELESS_DAEMON ? >> > >> >> We have it set here >> >> >> <https://git.yoctoproject.org/poky/commit/?id=1eaf64fbe16d2ceb472623c65c961b36aee33608> >> > > Sure, but the neard recipe can't see in the packagegroup-base recipe > scope? > > Cheers, > > Richard > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#176008): > <https://lists.openembedded.org/g/openembedded-core/message/176008> > Mute This Topic: <https://lists.openembedded.org/mt/96310274/3618223> > Group Owner: openembedded-core+owner@lists.openembedded.org > <mailto:openembedded-core+owner@lists.openembedded.org> > Unsubscribe: > <https://lists.openembedded.org/g/openembedded-core/unsub> > [f_l_k@t-online.de <mailto:f_l_k@t-online.de>] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Markus, Markus Volk <f_l_k@t-online.de> escreveu no dia segunda, 16/01/2023 à(s) 17:20: > Yes, that's right, of course. What would be the preferred way to deal with > this. The dependency on wpa-supplicant is a bit annoying. Should I use a > bbappend to remove it, or is the RRECOMMEND on wpa-supplicant perhaps > removable from the neard recipe? > I think we can set on the recipe the default value of the WIRELESS_DAEMON like on the patch you pointed out so that globally changing WIRELESS_DAEMON will take effect everywhere where it is used. WIRELESS_DAEMON ??= "wpa-supplicant" Jose > Am Mo, 16. Jan 2023 um 17:03:09 +0000 schrieb Richard Purdie < > richard.purdie@linuxfoundation.org>: > > On Mon, 2023-01-16 at 17:49 +0100, Markus Volk wrote: > > > That isn't going to work as there is no default value for > > WIRELESS_DAEMON ? > We have it set here > https://git.yoctoproject.org/poky/commit/?id=1eaf64fbe16d2ceb472623c65c961b36aee33608 > > Sure, but the neard recipe can't see in the packagegroup-base recipe > scope? Cheers, Richard > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#176009): > https://lists.openembedded.org/g/openembedded-core/message/176009 > Mute This Topic: https://lists.openembedded.org/mt/96310274/5052612 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > quaresma.jose@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Mon, 2023-01-16 at 18:20 +0100, Markus Volk wrote: > Yes, that's right, of course. What would be the preferred way to deal > with this. The dependency on wpa-supplicant is a bit annoying. Should > I use a bbappend to remove it, or is the RRECOMMEND on wpa-supplicant > perhaps removable from the neard recipe? It might be time to add something to meta/conf/distro/includes/default- providers.inc along the lines of: VIRTUAL-RUNTIME_wireless-daemon ?= "wpa-supplicant" I don't like these but probably need something more central/standard... Cheers, Richard
diff --git a/meta/recipes-connectivity/neard/neard_0.18.bb b/meta/recipes-connectivity/neard/neard_0.18.bb index 23e999acc4..17dbfc4378 100644 --- a/meta/recipes-connectivity/neard/neard_0.18.bb +++ b/meta/recipes-connectivity/neard/neard_0.18.bb @@ -42,7 +42,7 @@ RDEPENDS:${PN} = "dbus" # Bluez & Wifi are not mandatory except for handover RRECOMMENDS:${PN} = "\ ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ - ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ + ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','${WIRELESS_DAEMON}', '', d)} \ " INITSCRIPT_NAME = "neard"
Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta/recipes-connectivity/neard/neard_0.18.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)