diff mbox series

[v2,5/5] defaultsetup: Enable largefile and 64bit time_t support systemwide

Message ID 20230103200553.52973-5-raj.khem@gmail.com
State New
Headers show
Series [v2,1/5] rust: Fix build with 64bit time_t | expand

Commit Message

Khem Raj Jan. 3, 2023, 8:05 p.m. UTC
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/conf/distro/defaultsetup.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Jan. 18, 2023, 3:59 p.m. UTC | #1
On Tue, 2023-01-03 at 12:05 -0800, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/conf/distro/defaultsetup.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/defaultsetup.conf b/meta/conf/distro/defaultsetup.conf
> index f6894f3ab5..1abb509629 100644
> --- a/meta/conf/distro/defaultsetup.conf
> +++ b/meta/conf/distro/defaultsetup.conf
> @@ -2,7 +2,7 @@ include conf/distro/include/default-providers.inc
>  include conf/distro/include/default-versions.inc
>  include conf/distro/include/default-distrovars.inc
>  include conf/distro/include/maintainers.inc
> -
> +include conf/distro/include/time64.inc
>  require conf/distro/include/tcmode-${TCMODE}.inc
>  require conf/distro/include/tclibc-${TCLIBC}.inc
>  


I tried this as requested. I saw:

x86 binutils do_compile failure:
https://autobuilder.yoctoproject.org/typhoon/#/builders/48/builds/6562/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/5424/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/6572/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/76/builds/6493/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/6528/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/6481/steps/13/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/5304/steps/13/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6437/steps/11/logs/stdio

lib32-binutils do_compile failure:
https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6437/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/4042/steps/12/logs/stdio

mingw binutils do_compile:
https://autobuilder.yoctoproject.org/typhoon/#/builders/89/builds/6562/steps/13/logs/stdio

meta-virt xen-tools do_compile:
https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/1166/steps/20/logs/stdio

qemuarm glibc-testsuite issue:
https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/6539/steps/19/logs/stdio

qemumips glibc-testsuite issue:
https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/6500/steps/20/logs/stdio

qemux86 glibc-testsuite issue:
https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/6481/steps/20/logs/stdio

Close, but not quite there!


Cheers,

Richard
Khem Raj Jan. 19, 2023, 4:32 a.m. UTC | #2
On Wed, Jan 18, 2023 at 7:59 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2023-01-03 at 12:05 -0800, Khem Raj wrote:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/conf/distro/defaultsetup.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/distro/defaultsetup.conf b/meta/conf/distro/defaultsetup.conf
> > index f6894f3ab5..1abb509629 100644
> > --- a/meta/conf/distro/defaultsetup.conf
> > +++ b/meta/conf/distro/defaultsetup.conf
> > @@ -2,7 +2,7 @@ include conf/distro/include/default-providers.inc
> >  include conf/distro/include/default-versions.inc
> >  include conf/distro/include/default-distrovars.inc
> >  include conf/distro/include/maintainers.inc
> > -
> > +include conf/distro/include/time64.inc
> >  require conf/distro/include/tcmode-${TCMODE}.inc
> >  require conf/distro/include/tclibc-${TCLIBC}.inc
> >
>
>
> I tried this as requested. I saw:
>
> x86 binutils do_compile failure:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/48/builds/6562/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/5424/steps/12/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/6572/steps/12/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/76/builds/6493/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/6528/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/6481/steps/13/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/5304/steps/13/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6437/steps/11/logs/stdio
>
> lib32-binutils do_compile failure:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6437/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/4042/steps/12/logs/stdio
>
> mingw binutils do_compile:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/89/builds/6562/steps/13/logs/stdio
>
> meta-virt xen-tools do_compile:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/1166/steps/20/logs/stdio
>
> qemuarm glibc-testsuite issue:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/6539/steps/19/logs/stdio
>
> qemumips glibc-testsuite issue:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/6500/steps/20/logs/stdio
>
> qemux86 glibc-testsuite issue:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/6481/steps/20/logs/stdio
>
> Close, but not quite there!

Thanks for trying it out. I did realize that we will be better off
trying with upcoming glibc 2.37
I have a patch for the upgrade on the yoe/mut  poky-contrib branch. cherry-pick

[WIP] glibc: Upgrade to 2.37

on

https://git.yoctoproject.org/poky-contrib/log/?h=yoe/mut

as is with glibc upgrade, there might be other gotchas e.g. uninative
generation etc. but
meta-oe AB job has been using this glibc for some time now.

>
>
> Cheers,
>
> Richard
Khem Raj Jan. 19, 2023, 4:46 a.m. UTC | #3
On Wed, Jan 18, 2023 at 7:59 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2023-01-03 at 12:05 -0800, Khem Raj wrote:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/conf/distro/defaultsetup.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/distro/defaultsetup.conf b/meta/conf/distro/defaultsetup.conf
> > index f6894f3ab5..1abb509629 100644
> > --- a/meta/conf/distro/defaultsetup.conf
> > +++ b/meta/conf/distro/defaultsetup.conf
> > @@ -2,7 +2,7 @@ include conf/distro/include/default-providers.inc
> >  include conf/distro/include/default-versions.inc
> >  include conf/distro/include/default-distrovars.inc
> >  include conf/distro/include/maintainers.inc
> > -
> > +include conf/distro/include/time64.inc
> >  require conf/distro/include/tcmode-${TCMODE}.inc
> >  require conf/distro/include/tclibc-${TCLIBC}.inc
> >
>
>
> I tried this as requested. I saw:
>
> x86 binutils do_compile failure:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/48/builds/6562/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/5424/steps/12/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/6572/steps/12/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/76/builds/6493/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/6528/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/6481/steps/13/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/5304/steps/13/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6437/steps/11/logs/stdio
>
> lib32-binutils do_compile failure:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/6437/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/4042/steps/12/logs/stdio
>
> mingw binutils do_compile:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/89/builds/6562/steps/13/logs/stdio
>

all binutils errors reduce to a single problem, its in gprofng and
uses *64 versions of syscall
functions which are not available when using 64bit off_t. I have some
ideas about fixing it

> meta-virt xen-tools do_compile:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/1166/steps/20/logs/stdio
>

This looks like a simple printf format error which can be fixed easily
by using %j printf format
and typecasting now - conn->ta_start_time to intmax_t(now - conn->ta_start_time)

> qemuarm glibc-testsuite issue:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/6539/steps/19/logs/stdio
>
> qemumips glibc-testsuite issue:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/6500/steps/20/logs/stdio
>
> qemux86 glibc-testsuite issue:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/6481/steps/20/logs/stdio
>

as mentioned in previous email. We can try it with upcoming glibc.

> Close, but not quite there!

indeed

>
>
> Cheers,
>
> Richard
diff mbox series

Patch

diff --git a/meta/conf/distro/defaultsetup.conf b/meta/conf/distro/defaultsetup.conf
index f6894f3ab5..1abb509629 100644
--- a/meta/conf/distro/defaultsetup.conf
+++ b/meta/conf/distro/defaultsetup.conf
@@ -2,7 +2,7 @@  include conf/distro/include/default-providers.inc
 include conf/distro/include/default-versions.inc
 include conf/distro/include/default-distrovars.inc
 include conf/distro/include/maintainers.inc
-
+include conf/distro/include/time64.inc
 require conf/distro/include/tcmode-${TCMODE}.inc
 require conf/distro/include/tclibc-${TCLIBC}.inc