[1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES

From: Mingli Yu <mingli.yu@windriver.com>

xf86-input-synaptics depends on virtual/xserver which needs opengl
DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Both of these patches seem very wrong. X11 definitely does not require
opengl. I just confirmed it by building xf86-input-synaptics without
opengl in DISTRO_FEATURES.

Can you show how the issue can be reproduced on plain poky? It seems
like your local config or distro or BSP layer does something which
triggers this.

Alex



On Mon, 5 Dec 2022 at 10:51, Yu, Mingli <mingli.yu@eng.windriver.com> wrote:
>
> From: Mingli Yu <mingli.yu@windriver.com>
>
> xf86-input-synaptics depends on virtual/xserver which needs opengl
> DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> index 8b3f19426b..3fc54af3e4 100644
> --- a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> +++ b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> @@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
>  inherit ${XORGBUILDCLASS} pkgconfig features_check
>
>  # depends on virtual/xserver
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>
>  # FIXME: We don't want to include the libtool archives (*.la) from modules
>  # directory, as they serve no useful purpose. Upstream should fix Makefile.am
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#174279): https://lists.openembedded.org/g/openembedded-core/message/174279
> Mute This Topic: https://lists.openembedded.org/mt/95465698/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Hi Alex,

The error as below:
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/meta-openembedded/meta-oe/recipes-graphics/xorg-driver/xf86-video-amdgpu_22.0.0.bb DEPENDS on or otherwise requires it). Close matches:
  virtual/libc
  virtual/libomxil
  virtual/libusb0
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-video-amdgpu', 'virtual/libgbm']

Thanks,

Hello,

this means that xf86-video-amdgpu_22.0.0.bb needs the
REQUIRED_DISTRO_FEATURES = "opengl"
line, but other x11 recipes do not need to be changed.

Alex

On Fri, 9 Dec 2022 at 05:10, Yu, Mingli <Mingli.Yu@windriver.com> wrote:
>
> Hi Alex,
>
> The error as below:
> ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/meta-openembedded/meta-oe/recipes-graphics/xorg-driver/xf86-video-amdgpu_22.0.0.bb DEPENDS on or otherwise requires it). Close matches:
>   virtual/libc
>   virtual/libomxil
>   virtual/libusb0
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-video-amdgpu', 'virtual/libgbm']
>
> Thanks,
> ________________________________
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> on behalf of Alexander Kanavin <alex.kanavin@gmail.com>
> Sent: Monday, December 5, 2022 18:04
> To: Yu, Mingli <Mingli.Yu@windriver.com>
> Cc: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES
>
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> Both of these patches seem very wrong. X11 definitely does not require
> opengl. I just confirmed it by building xf86-input-synaptics without
> opengl in DISTRO_FEATURES.
>
> Can you show how the issue can be reproduced on plain poky? It seems
> like your local config or distro or BSP layer does something which
> triggers this.
>
> Alex
>
>
>
> On Mon, 5 Dec 2022 at 10:51, Yu, Mingli <mingli.yu@eng.windriver.com> wrote:
> >
> > From: Mingli Yu <mingli.yu@windriver.com>
> >
> > xf86-input-synaptics depends on virtual/xserver which needs opengl
> > DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.
> >
> > Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> > ---
> >  meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > index 8b3f19426b..3fc54af3e4 100644
> > --- a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > +++ b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > @@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
> >  inherit ${XORGBUILDCLASS} pkgconfig features_check
> >
> >  # depends on virtual/xserver
> > -REQUIRED_DISTRO_FEATURES = "x11"
> > +REQUIRED_DISTRO_FEATURES = "x11 opengl"
> >
> >  # FIXME: We don't want to include the libtool archives (*.la) from modules
> >  # directory, as they serve no useful purpose. Upstream should fix Makefile.am
> > --
> > 2.25.1
> >
> >
> >
> >

Hi Alex,

Not only xf86-video-amdgpu_22.0.0.bb needs the REQUIRED_DISTRO_FEATURES = "opengl", there still comes below error if we only add REQUIRED_DISTRO_FEATURES = "opengl" for xf86-video-amdgpu_22.0.0.bb.
ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/oe-core/meta/recipes-graphics/xorg-xserver/xserver-xorg_21.1.4.bb DEPENDS on or otherwise requires it)
libmali-xlnx PROVIDES virtual/libgbm but was skipped: incompatible with machine qemux86-64 (not in COMPATIBLE_MACHINE)
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-input-mouse', 'virtual/xserver', 'virtual/libgbm']

Thanks,

"libmali-xlnx PROVIDES virtual/libgbm but was skipped: incompatible
with machine qemux86-64 (not in COMPATIBLE_MACHINE)"

This is the key error. Why is libmali being set as the libgbm provider
if it's not compatible?

Alex

On Mon, 12 Dec 2022 at 11:20, Yu, Mingli <Mingli.Yu@windriver.com> wrote:
>
> Hi Alex,
>
> Not only xf86-video-amdgpu_22.0.0.bb needs the REQUIRED_DISTRO_FEATURES = "opengl", there still comes below error if we only add REQUIRED_DISTRO_FEATURES = "opengl" for xf86-video-amdgpu_22.0.0.bb.
> ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/oe-core/meta/recipes-graphics/xorg-xserver/xserver-xorg_21.1.4.bb DEPENDS on or otherwise requires it)
> libmali-xlnx PROVIDES virtual/libgbm but was skipped: incompatible with machine qemux86-64 (not in COMPATIBLE_MACHINE)
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-input-mouse', 'virtual/xserver', 'virtual/libgbm']
>
> Thanks,
>
> ________________________________
> From: Alexander Kanavin <alex.kanavin@gmail.com>
> Sent: Friday, December 9, 2022 17:05
> To: Yu, Mingli <Mingli.Yu@windriver.com>
> Cc: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES
>
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> Hello,
>
> this means that xf86-video-amdgpu_22.0.0.bb needs the
> REQUIRED_DISTRO_FEATURES = "opengl"
> line, but other x11 recipes do not need to be changed.
>
> Alex
>
> On Fri, 9 Dec 2022 at 05:10, Yu, Mingli <Mingli.Yu@windriver.com> wrote:
> >
> > Hi Alex,
> >
> > The error as below:
> > ERROR: Nothing PROVIDES 'virtual/libgbm' (but /build/layers/meta-openembedded/meta-oe/recipes-graphics/xorg-driver/xf86-video-amdgpu_22.0.0.bb DEPENDS on or otherwise requires it). Close matches:
> >   virtual/libc
> >   virtual/libomxil
> >   virtual/libusb0
> > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'xf86-video-amdgpu', 'virtual/libgbm']
> >
> > Thanks,
> > ________________________________
> > From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> on behalf of Alexander Kanavin <alex.kanavin@gmail.com>
> > Sent: Monday, December 5, 2022 18:04
> > To: Yu, Mingli <Mingli.Yu@windriver.com>
> > Cc: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
> > Subject: Re: [OE-core] [PATCH 1/2] xorg-driver-common: add opengl to REQUIRED_DISTRO_FEATURES
> >
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and know the content is safe.
> >
> > Both of these patches seem very wrong. X11 definitely does not require
> > opengl. I just confirmed it by building xf86-input-synaptics without
> > opengl in DISTRO_FEATURES.
> >
> > Can you show how the issue can be reproduced on plain poky? It seems
> > like your local config or distro or BSP layer does something which
> > triggers this.
> >
> > Alex
> >
> >
> >
> > On Mon, 5 Dec 2022 at 10:51, Yu, Mingli <mingli.yu@eng.windriver.com> wrote:
> > >
> > > From: Mingli Yu <mingli.yu@windriver.com>
> > >
> > > xf86-input-synaptics depends on virtual/xserver which needs opengl
> > > DISTRO_FEATURES, so add opengl distro check also for xf86-input-synaptics.
> > >
> > > Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> > > ---
> > >  meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > > index 8b3f19426b..3fc54af3e4 100644
> > > --- a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > > +++ b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > > @@ -17,7 +17,7 @@ XORGBUILDCLASS ??= "autotools"
> > >  inherit ${XORGBUILDCLASS} pkgconfig features_check
> > >
> > >  # depends on virtual/xserver
> > > -REQUIRED_DISTRO_FEATURES = "x11"
> > > +REQUIRED_DISTRO_FEATURES = "x11 opengl"
> > >
> > >  # FIXME: We don't want to include the libtool archives (*.la) from modules
> > >  # directory, as they serve no useful purpose. Upstream should fix Makefile.am
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >