diff mbox series

[V4,1/2] bluez5: change configuration directory mode

Message ID 20221006112712.23062-2-liu.ming50@gmail.com
State New
Headers show
Series bluez5: change configuration directory mode | expand

Commit Message

Ming Liu Oct. 6, 2022, 11:27 a.m. UTC
From: Ming Liu <liu.ming50@gmail.com>

Change configuration directory mode from 0755 to 0555, this fixes a
following warning when bluetoothd starts:
| ConfigurationDirectory 'bluetooth' already exists but the mode is different.
| (File system: 755 ConfigurationDirectoryMode: 555)

Reference:
https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=00cfb36e20e3c35db2150e7d0351ad7b8442e2d8

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ross Burton Oct. 6, 2022, 12:19 p.m. UTC | #1
Is this in a build with systemd or sysvinit?  Looking at the referenced commit, that’s when running in a systemd-managed contained environment.  In sysv that isn’t the case, so I’m not convinced this is the correct solution.

Ross

> On 6 Oct 2022, at 12:27, Ming Liu via lists.openembedded.org <liu.ming50=gmail.com@lists.openembedded.org> wrote:
> 
> From: Ming Liu <liu.ming50@gmail.com>
> 
> Change configuration directory mode from 0755 to 0555, this fixes a
> following warning when bluetoothd starts:
> | ConfigurationDirectory 'bluetooth' already exists but the mode is different.
> | (File system: 755 ConfigurationDirectoryMode: 555)
> 
> Reference:
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=00cfb36e20e3c35db2150e7d0351ad7b8442e2d8
> 
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 79d4645ca8..9f5c78b81e 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -82,7 +82,7 @@ do_install:append() {
> 	install -d ${D}${INIT_D_DIR}
> 	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
> 
> -	install -d ${D}${sysconfdir}/bluetooth/
> +	install -m 0555 -d ${D}${sysconfdir}/bluetooth/
> 	if [ -f ${S}/profiles/network/network.conf ]; then
> 		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
> 	fi
> -- 
> 2.25.1
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171494): https://lists.openembedded.org/g/openembedded-core/message/171494
> Mute This Topic: https://lists.openembedded.org/mt/94155398/6875888
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Ming Liu Oct. 7, 2022, 7:54 a.m. UTC | #2
Hi, Ross:

I think it applies for both systemd and sysvinit, it's bluez5's requirement
that /etc/bluetooth should be read-only.

//Ming Liu

Ross Burton <Ross.Burton@arm.com> 於 2022年10月6日 週四 下午2:19寫道:

> Is this in a build with systemd or sysvinit?  Looking at the referenced
> commit, that’s when running in a systemd-managed contained environment.  In
> sysv that isn’t the case, so I’m not convinced this is the correct solution.
>
> Ross
>
> > On 6 Oct 2022, at 12:27, Ming Liu via lists.openembedded.org
> <liu.ming50=gmail.com@lists.openembedded.org> wrote:
> >
> > From: Ming Liu <liu.ming50@gmail.com>
> >
> > Change configuration directory mode from 0755 to 0555, this fixes a
> > following warning when bluetoothd starts:
> > | ConfigurationDirectory 'bluetooth' already exists but the mode is
> different.
> > | (File system: 755 ConfigurationDirectoryMode: 555)
> >
> > Reference:
> >
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=00cfb36e20e3c35db2150e7d0351ad7b8442e2d8
> >
> > Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> > ---
> > meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc
> b/meta/recipes-connectivity/bluez5/bluez5.inc
> > index 79d4645ca8..9f5c78b81e 100644
> > --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> > +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> > @@ -82,7 +82,7 @@ do_install:append() {
> >       install -d ${D}${INIT_D_DIR}
> >       install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
> >
> > -     install -d ${D}${sysconfdir}/bluetooth/
> > +     install -m 0555 -d ${D}${sysconfdir}/bluetooth/
> >       if [ -f ${S}/profiles/network/network.conf ]; then
> >               install -m 0644 ${S}/profiles/network/network.conf
> ${D}/${sysconfdir}/bluetooth/
> >       fi
> > --
> > 2.25.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#171494):
> https://lists.openembedded.org/g/openembedded-core/message/171494
> > Mute This Topic: https://lists.openembedded.org/mt/94155398/6875888
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ross.burton@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
diff mbox series

Patch

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index 79d4645ca8..9f5c78b81e 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -82,7 +82,7 @@  do_install:append() {
 	install -d ${D}${INIT_D_DIR}
 	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
 
-	install -d ${D}${sysconfdir}/bluetooth/
+	install -m 0555 -d ${D}${sysconfdir}/bluetooth/
 	if [ -f ${S}/profiles/network/network.conf ]; then
 		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
 	fi