| Message ID | 20221004105106.1556357-4-ross.burton@arm.com |
|---|---|
| State | Accepted, archived |
| Commit | 15e876ada73fe8e98284d14dec166007b5767f19 |
| Headers | show |
| Series | [1/5] acpid: upgrade 2.0.33 -> 2.0.34 | expand |
On Tue, Oct 4, 2022 at 3:51 AM Ross Burton <ross.burton@arm.com> wrote: > Also disable any attempt at debug splitting/stripping. Piglit installs > over 2GB of files which we install stripped, so the action of attempting > to split/strip takes a long time and achieves nothing. > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/recipes-graphics/piglit/piglit_git.bb | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-graphics/piglit/piglit_git.bb > b/meta/recipes-graphics/piglit/piglit_git.bb > index f758208c6bc..c9cf5795e99 100644 > --- a/meta/recipes-graphics/piglit/piglit_git.bb > +++ b/meta/recipes-graphics/piglit/piglit_git.bb > @@ -14,7 +14,7 @@ SRC_URI = "git:// > gitlab.freedesktop.org/mesa/piglit.git;protocol=https;branch=ma > " > UPSTREAM_CHECK_COMMITS = "1" > > -SRCREV = "265896c86f90cb72e8f218ba6a3617fca8b9a1e3" > +SRCREV = "80465078a0ae8f12411db66850ee14f017962fa7" > # (when PV goes above 1.0 remove the trailing r) > PV = "1.0+gitr${SRCPV}" > > @@ -52,8 +52,10 @@ do_configure:prepend() { > fi > } > > -# Forcibly strip because Piglit is *huge* > +# Forcibly strip because Piglit is *huge*, and don't bother trying to > split/strip the result. > OECMAKE_TARGET_INSTALL = "install/strip" > +INHIBIT_PACKAGE_STRIP = "1" > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" How does debugging piglet looks like after this change ? I wonder if we can reduce debug info by Using something like -g1 maybe a good middle ground > > RDEPENDS:${PN} = "waffle waffle-bin python3 python3-mako python3-json \ > python3-misc \ > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#171384): > https://lists.openembedded.org/g/openembedded-core/message/171384 > Mute This Topic: https://lists.openembedded.org/mt/94110619/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On 4 Oct 2022, at 14:36, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > How does debugging piglet looks like after this change ? I wonder if we can reduce debug info by > Using something like -g1 maybe a good middle ground The binaries have been stripped since 2016, this change simply stops do_package from trying to split/strip the debug symbols. There’s 2GB of already-stripped binaries to process, which on my machine takes over a minute. Ross
On Tue, Oct 4, 2022 at 6:39 AM Ross Burton <Ross.Burton@arm.com> wrote: > > On 4 Oct 2022, at 14:36, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > > How does debugging piglet looks like after this change ? I wonder if we can reduce debug info by > > Using something like -g1 maybe a good middle ground > > The binaries have been stripped since 2016, this change simply stops do_package from trying to split/strip the debug symbols. There’s 2GB of already-stripped binaries to process, which on my machine takes over a minute. yeah understood, I was trying to see if we can make it optimize a bit while you were here. > > Ross
On 4 Oct 2022, at 15:08, Khem Raj <raj.khem@gmail.com> wrote: > > On Tue, Oct 4, 2022 at 6:39 AM Ross Burton <Ross.Burton@arm.com> wrote: >> >> On 4 Oct 2022, at 14:36, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: >>> How does debugging piglet looks like after this change ? I wonder if we can reduce debug info by >>> Using something like -g1 maybe a good middle ground >> >> The binaries have been stripped since 2016, this change simply stops do_package from trying to split/strip the debug symbols. There’s 2GB of already-stripped binaries to process, which on my machine takes over a minute. > > yeah understood, I was trying to see if we can make it optimize a bit > while you were here. Turning on any form of debug would make that 2GB more like 3GB… Ross
On Tue, Oct 4, 2022 at 7:15 AM Ross Burton <Ross.Burton@arm.com> wrote: > > On 4 Oct 2022, at 15:08, Khem Raj <raj.khem@gmail.com> wrote: > > > > On Tue, Oct 4, 2022 at 6:39 AM Ross Burton <Ross.Burton@arm.com> wrote: > >> > >> On 4 Oct 2022, at 14:36, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > >>> How does debugging piglet looks like after this change ? I wonder if we can reduce debug info by > >>> Using something like -g1 maybe a good middle ground > >> > >> The binaries have been stripped since 2016, this change simply stops do_package from trying to split/strip the debug symbols. There’s 2GB of already-stripped binaries to process, which on my machine takes over a minute. > > > > yeah understood, I was trying to see if we can make it optimize a bit > > while you were here. > > Turning on any form of debug would make that 2GB more like 3GB… hmm yeah I guess. Ignore me. > > Ross
diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb index f758208c6bc..c9cf5795e99 100644 --- a/meta/recipes-graphics/piglit/piglit_git.bb +++ b/meta/recipes-graphics/piglit/piglit_git.bb @@ -14,7 +14,7 @@ SRC_URI = "git://gitlab.freedesktop.org/mesa/piglit.git;protocol=https;branch=ma " UPSTREAM_CHECK_COMMITS = "1" -SRCREV = "265896c86f90cb72e8f218ba6a3617fca8b9a1e3" +SRCREV = "80465078a0ae8f12411db66850ee14f017962fa7" # (when PV goes above 1.0 remove the trailing r) PV = "1.0+gitr${SRCPV}" @@ -52,8 +52,10 @@ do_configure:prepend() { fi } -# Forcibly strip because Piglit is *huge* +# Forcibly strip because Piglit is *huge*, and don't bother trying to split/strip the result. OECMAKE_TARGET_INSTALL = "install/strip" +INHIBIT_PACKAGE_STRIP = "1" +INHIBIT_PACKAGE_DEBUG_SPLIT = "1" RDEPENDS:${PN} = "waffle waffle-bin python3 python3-mako python3-json \ python3-misc \
Also disable any attempt at debug splitting/stripping. Piglit installs over 2GB of files which we install stripped, so the action of attempting to split/strip takes a long time and achieves nothing. Signed-off-by: Ross Burton <ross.burton@arm.com> --- meta/recipes-graphics/piglit/piglit_git.bb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)