diff mbox series

[2/3] kern-tools-native: don't pull the toolchain as it is not used

Message ID 20220930175440.2168008-2-jose.quaresma@foundries.io
State New
Headers show
Series [1/3] go: drop patch to make content based hash generation less pedan | expand

Commit Message

Jose Quaresma Sept. 30, 2022, 5:54 p.m. UTC
Prevents the default dependencies, namely the C compiler and standard C library (libc),
from being added to DEPENDS. This variable is usually used within recipes that do not
require any compilation using the C compiler.

This also improves the speed as it will not populate the
native sysroot with the toolchain.

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
---
 meta/recipes-kernel/kern-tools/kern-tools-native_git.bb | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Ross Burton Oct. 6, 2022, 10:50 a.m. UTC | #1
On 30 Sep 2022, at 18:54, Jose Quaresma via lists.openembedded.org <quaresma.jose=gmail.com@lists.openembedded.org> wrote:
> 
> Prevents the default dependencies, namely the C compiler and standard C library (libc),
> from being added to DEPENDS. This variable is usually used within recipes that do not
> require any compilation using the C compiler.
> 
> This also improves the speed as it will not populate the
> native sysroot with the toolchain.

But this is a native recipe, so it doesn’t depend on a cross-compiler:

$ bitbake-getvar -r kern-tools-native DEPENDS
DEPENDS=" git-native”

Ross
Jose Quaresma Oct. 7, 2022, 8:59 a.m. UTC | #2
Hi Ross,

Ross Burton <Ross.Burton@arm.com> escreveu no dia quinta, 6/10/2022 à(s)
11:50:

> On 30 Sep 2022, at 18:54, Jose Quaresma via lists.openembedded.org
> <quaresma.jose=gmail.com@lists.openembedded.org> wrote:
> >
> > Prevents the default dependencies, namely the C compiler and standard C
> library (libc),
> > from being added to DEPENDS. This variable is usually used within
> recipes that do not
> > require any compilation using the C compiler.
> >
> > This also improves the speed as it will not populate the
> > native sysroot with the toolchain.
>
> But this is a native recipe, so it doesn’t depend on a cross-compiler:
>
> $ bitbake-getvar -r kern-tools-native DEPENDS
> DEPENDS=" git-native”
>

Right, sorry for my confusion that maybe it was ignorance of the reality of
this detail of native packages.
Please drop that patch and thanks for your time in reviewing it.

Jose


>
> Ross
Jose Quaresma Oct. 24, 2022, 2:21 p.m. UTC | #3
Hi Alexandre,

I see this one is still on staging abelloni main-next
https://git.yoctoproject.org/poky-contrib/log/?h=abelloni/master-next

Can this be dropped please?

Jose

Jose Quaresma via lists.openembedded.org <quaresma.jose=
gmail.com@lists.openembedded.org> escreveu no dia sexta, 7/10/2022 à(s)
09:59:

> Hi Ross,
>
> Ross Burton <Ross.Burton@arm.com> escreveu no dia quinta, 6/10/2022 à(s)
> 11:50:
>
>> On 30 Sep 2022, at 18:54, Jose Quaresma via lists.openembedded.org
>> <quaresma.jose=gmail.com@lists.openembedded.org> wrote:
>> >
>> > Prevents the default dependencies, namely the C compiler and standard C
>> library (libc),
>> > from being added to DEPENDS. This variable is usually used within
>> recipes that do not
>> > require any compilation using the C compiler.
>> >
>> > This also improves the speed as it will not populate the
>> > native sysroot with the toolchain.
>>
>> But this is a native recipe, so it doesn’t depend on a cross-compiler:
>>
>> $ bitbake-getvar -r kern-tools-native DEPENDS
>> DEPENDS=" git-native”
>>
>
> Right, sorry for my confusion that maybe it was ignorance of the reality
> of this detail of native packages.
> Please drop that patch and thanks for your time in reviewing it.
>
> Jose
>
>
>>
>> Ross
>
>
>
> --
> Best regards,
>
> José Quaresma
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171519):
> https://lists.openembedded.org/g/openembedded-core/message/171519
> Mute This Topic: https://lists.openembedded.org/mt/94022665/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Alexandre Belloni Oct. 24, 2022, 2:51 p.m. UTC | #4
On 24/10/2022 15:21:56+0100, Jose Quaresma wrote:
> Hi Alexandre,
> 
> I see this one is still on staging abelloni main-next
> https://git.yoctoproject.org/poky-contrib/log/?h=abelloni/master-next
> 
> Can this be dropped please?
> 

Dropped now

> Jose
> 
> Jose Quaresma via lists.openembedded.org <quaresma.jose=
> gmail.com@lists.openembedded.org> escreveu no dia sexta, 7/10/2022 à(s)
> 09:59:
> 
> > Hi Ross,
> >
> > Ross Burton <Ross.Burton@arm.com> escreveu no dia quinta, 6/10/2022 à(s)
> > 11:50:
> >
> >> On 30 Sep 2022, at 18:54, Jose Quaresma via lists.openembedded.org
> >> <quaresma.jose=gmail.com@lists.openembedded.org> wrote:
> >> >
> >> > Prevents the default dependencies, namely the C compiler and standard C
> >> library (libc),
> >> > from being added to DEPENDS. This variable is usually used within
> >> recipes that do not
> >> > require any compilation using the C compiler.
> >> >
> >> > This also improves the speed as it will not populate the
> >> > native sysroot with the toolchain.
> >>
> >> But this is a native recipe, so it doesn’t depend on a cross-compiler:
> >>
> >> $ bitbake-getvar -r kern-tools-native DEPENDS
> >> DEPENDS=" git-native”
> >>
> >
> > Right, sorry for my confusion that maybe it was ignorance of the reality
> > of this detail of native packages.
> > Please drop that patch and thanks for your time in reviewing it.
> >
> > Jose
> >
> >
> >>
> >> Ross
> >
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#171519):
> > https://lists.openembedded.org/g/openembedded-core/message/171519
> > Mute This Topic: https://lists.openembedded.org/mt/94022665/5052612
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> > quaresma.jose@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
> >
> 
> -- 
> Best regards,
> 
> José Quaresma
diff mbox series

Patch

diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
index dea7b65a7c..5fe46341da 100644
--- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
+++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
@@ -19,13 +19,10 @@  inherit native
 SRC_URI = "git://git.yoctoproject.org/yocto-kernel-tools.git;branch=master"
 S = "${WORKDIR}/git"
 
-do_configure() {
-	:
-}
+INHIBIT_DEFAULT_DEPS = "1"
 
-do_compile() { 
-	:
-}
+do_configure[noexec] = "1"
+do_compile[noexec] = "1"
 
 do_install() {
 	oe_runmake DESTDIR=${D}${bindir} install