| Message ID | 20220930150858.3389410-1-philippe.coval@astrolabe.coop |
|---|---|
| State | New |
| Headers | show |
| Series | [openembedded-core,PATCHv2] graphics: Hotfix for eGalax Touchscreen | expand |
As discussed in the MR you filed originally with libinput, this udev rule is far too broad. If you can demonstrate that every user of this touchscreen has the input inverted then add a quirk to libinput, otherwise keep this in your own layer. Ross > On 30 Sep 2022, at 16:08, philippe.coval@astrolabe.coop via lists.openembedded.org <philippe.coval=astrolabe.coop@lists.openembedded.org> wrote: > > From: Philippe Coval <philippe.coval@astrolabe.coop> > > For unsupported screens (which X axis is inverted) > > For the record issue was observed with this CVL1010 device: > > http://www.cartft.com/en/catalog/il/1589# > > For more details check related links: > > Forwarded: https://lists.openembedded.org/g/openembedded-core/message/171179 > Relate-to: https://gitlab.freedesktop.org/libinput/libinput/-/issues/665 > Relate-to: https://at.projects.genivi.org/jira/si/jira.issueviews:issue-html/GDP-19/GDP-19.html > Relate-to: https://git.ostc-eu.org/OSTC/planning/blueprints/-/issues/22 > Origin: https://git.ostc-eu.org/OSTC/OHOS/meta-ohos/-/merge_requests/288 > Signed-off-by: Philippe Coval <philippe.coval@huawei.com> > Signed-off-by: Philippe Coval <philippe.coval@astrolabe.coop> > --- > .../wayland/libinput/90-usb-0eef-0001.rules | 1 + > meta/recipes-graphics/wayland/libinput_1.19.4.bb | 6 ++++++ > 2 files changed, 7 insertions(+) > create mode 100644 meta/recipes-graphics/wayland/libinput/90-usb-0eef-0001.rules > > diff --git a/meta/recipes-graphics/wayland/libinput/90-usb-0eef-0001.rules b/meta/recipes-graphics/wayland/libinput/90-usb-0eef-0001.rules > new file mode 100644 > index 0000000000..354629dbbb > --- /dev/null > +++ b/meta/recipes-graphics/wayland/libinput/90-usb-0eef-0001.rules > @@ -0,0 +1 @@ > +ACTION=="add|change", KERNEL=="event[0-9]*", ENV{ID_VENDOR_ID}=="0eef", ENV{ID_MODEL_ID}=="0001", ENV{ID_INPUT_TOUCHSCREEN}="1", ENV{ID_INPUT_TABLET}="0", ENV{ID_INPUT_MOUSE}="0", ENV{LIBINPUT_CALIBRATION_MATRIX}="-1 0 1 0 1 0" > diff --git a/meta/recipes-graphics/wayland/libinput_1.19.4.bb b/meta/recipes-graphics/wayland/libinput_1.19.4.bb > index a7d0c4be69..089f41c58a 100644 > --- a/meta/recipes-graphics/wayland/libinput_1.19.4.bb > +++ b/meta/recipes-graphics/wayland/libinput_1.19.4.bb > @@ -15,6 +15,7 @@ DEPENDS = "libevdev udev mtdev libcheck" > SRC_URI = "http://www.freedesktop.org/software/${BPN}/${BP}.tar.xz \ > file://run-ptest \ > file://determinism.patch \ > + file://90-usb-0eef-0001.rules \ > " > SRC_URI[sha256sum] = "ff33a570b5a936c81e6c08389a8581c2665311d026ce3d225c88d09c49f9b440" > > @@ -47,3 +48,8 @@ RREPLACES:${PN} = "libinput" > RCONFLICTS:${PN} = "libinput" > > FILES:${PN}-ptest += "${libexecdir}/libinput/libinput-test-suite" > + > +do_install:append() { > + install -d "${D}/${sysconfdir}/udev/rules.d" > + install -m444 "${WORKDIR}/90-usb-0eef-0001.rules" "${D}/${sysconfdir}/udev/rules.d/" > +} > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#171222): https://lists.openembedded.org/g/openembedded-core/message/171222 > Mute This Topic: https://lists.openembedded.org/mt/94018555/6875888 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-graphics/wayland/libinput/90-usb-0eef-0001.rules b/meta/recipes-graphics/wayland/libinput/90-usb-0eef-0001.rules new file mode 100644 index 0000000000..354629dbbb --- /dev/null +++ b/meta/recipes-graphics/wayland/libinput/90-usb-0eef-0001.rules @@ -0,0 +1 @@ +ACTION=="add|change", KERNEL=="event[0-9]*", ENV{ID_VENDOR_ID}=="0eef", ENV{ID_MODEL_ID}=="0001", ENV{ID_INPUT_TOUCHSCREEN}="1", ENV{ID_INPUT_TABLET}="0", ENV{ID_INPUT_MOUSE}="0", ENV{LIBINPUT_CALIBRATION_MATRIX}="-1 0 1 0 1 0" diff --git a/meta/recipes-graphics/wayland/libinput_1.19.4.bb b/meta/recipes-graphics/wayland/libinput_1.19.4.bb index a7d0c4be69..089f41c58a 100644 --- a/meta/recipes-graphics/wayland/libinput_1.19.4.bb +++ b/meta/recipes-graphics/wayland/libinput_1.19.4.bb @@ -15,6 +15,7 @@ DEPENDS = "libevdev udev mtdev libcheck" SRC_URI = "http://www.freedesktop.org/software/${BPN}/${BP}.tar.xz \ file://run-ptest \ file://determinism.patch \ + file://90-usb-0eef-0001.rules \ " SRC_URI[sha256sum] = "ff33a570b5a936c81e6c08389a8581c2665311d026ce3d225c88d09c49f9b440" @@ -47,3 +48,8 @@ RREPLACES:${PN} = "libinput" RCONFLICTS:${PN} = "libinput" FILES:${PN}-ptest += "${libexecdir}/libinput/libinput-test-suite" + +do_install:append() { + install -d "${D}/${sysconfdir}/udev/rules.d" + install -m444 "${WORKDIR}/90-usb-0eef-0001.rules" "${D}/${sysconfdir}/udev/rules.d/" +}