diff mbox series

lttng-tools: Disable on qemuriscv32

Message ID 20220926080807.1625573-1-zhe.he@windriver.com
State New
Headers show
Series lttng-tools: Disable on qemuriscv32 | expand

Commit Message

He Zhe Sept. 26, 2022, 8:08 a.m. UTC
lttng-tools requires SYS_ppoll and SYS_pselect6 which are not supported on
riscv32. This has been confirmed by lttng-tools upstream.
https://github.com/lttng/lttng-tools/pull/162

It's also turned off for riscv32 in meta-riscv.
https://github.com/riscv/meta-riscv/blob/master/conf/layer.conf

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 meta/recipes-kernel/lttng/lttng-platforms.inc | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Khem Raj Sept. 26, 2022, 3:58 p.m. UTC | #1
On 9/26/22 1:08 AM, He Zhe wrote:
> lttng-tools requires SYS_ppoll and SYS_pselect6 which are not supported on
> riscv32. This has been confirmed by lttng-tools upstream.
> https://github.com/lttng/lttng-tools/pull/162
> 
> It's also turned off for riscv32 in meta-riscv.
> https://github.com/riscv/meta-riscv/blob/master/conf/layer.conf
> 
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
>   meta/recipes-kernel/lttng/lttng-platforms.inc | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-kernel/lttng/lttng-platforms.inc b/meta/recipes-kernel/lttng/lttng-platforms.inc
> index 933c65d85d..98b13b194c 100644
> --- a/meta/recipes-kernel/lttng/lttng-platforms.inc
> +++ b/meta/recipes-kernel/lttng/lttng-platforms.inc
> @@ -15,3 +15,7 @@ LTTNGUST:arc = ""
>   
>   COMPATIBLE_HOST:arc:pn-lttng-ust = "null"
>   
> +# Whether the platform supports lttng-tools
> +# lttng-tools requires SYS_ppoll and SYS_pselect6 which are not supported on riscv32.
> +# It's also turned off for riscv32 in meta-riscv. See https://github.com/riscv/meta-riscv/blob/master/conf/layer.conf
> +COMPATIBLE_HOST:qemuriscv32:pn-lttng-tools = "null"
> 

Its perhaps better to disable it rv32 wide not just form qemu.

> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171052): https://lists.openembedded.org/g/openembedded-core/message/171052
> Mute This Topic: https://lists.openembedded.org/mt/93922533/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
He Zhe Sept. 27, 2022, 3:19 a.m. UTC | #2
On 9/26/22 23:58, Khem Raj wrote:
> On 9/26/22 1:08 AM, He Zhe wrote:
>> lttng-tools requires SYS_ppoll and SYS_pselect6 which are not supported on
>> riscv32. This has been confirmed by lttng-tools upstream.
>> https://github.com/lttng/lttng-tools/pull/162
>>
>> It's also turned off for riscv32 in meta-riscv.
>> https://github.com/riscv/meta-riscv/blob/master/conf/layer.conf
>>
>> Signed-off-by: He Zhe <zhe.he@windriver.com>
>> ---
>>   meta/recipes-kernel/lttng/lttng-platforms.inc | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/meta/recipes-kernel/lttng/lttng-platforms.inc b/meta/recipes-kernel/lttng/lttng-platforms.inc
>> index 933c65d85d..98b13b194c 100644
>> --- a/meta/recipes-kernel/lttng/lttng-platforms.inc
>> +++ b/meta/recipes-kernel/lttng/lttng-platforms.inc
>> @@ -15,3 +15,7 @@ LTTNGUST:arc = ""
>>     COMPATIBLE_HOST:arc:pn-lttng-ust = "null"
>>   +# Whether the platform supports lttng-tools
>> +# lttng-tools requires SYS_ppoll and SYS_pselect6 which are not supported on riscv32.
>> +# It's also turned off for riscv32 in meta-riscv. See https://github.com/riscv/meta-riscv/blob/master/conf/layer.conf
>> +COMPATIBLE_HOST:qemuriscv32:pn-lttng-tools = "null"
>>
>
> Its perhaps better to disable it rv32 wide not just form qemu.

OK, I'll send an update for that.

Thanks,
Zhe

>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#171052): https://lists.openembedded.org/g/openembedded-core/message/171052
>> Mute This Topic: https://lists.openembedded.org/mt/93922533/1997914
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta/recipes-kernel/lttng/lttng-platforms.inc b/meta/recipes-kernel/lttng/lttng-platforms.inc
index 933c65d85d..98b13b194c 100644
--- a/meta/recipes-kernel/lttng/lttng-platforms.inc
+++ b/meta/recipes-kernel/lttng/lttng-platforms.inc
@@ -15,3 +15,7 @@  LTTNGUST:arc = ""
 
 COMPATIBLE_HOST:arc:pn-lttng-ust = "null"
 
+# Whether the platform supports lttng-tools
+# lttng-tools requires SYS_ppoll and SYS_pselect6 which are not supported on riscv32.
+# It's also turned off for riscv32 in meta-riscv. See https://github.com/riscv/meta-riscv/blob/master/conf/layer.conf
+COMPATIBLE_HOST:qemuriscv32:pn-lttng-tools = "null"