Message ID | 20220819113336.3167-1-mateuszmar2@gmail.com |
---|---|
State | New |
Headers | show |
Series | util-linux: Remove raw flags in EXTRA_OECONF | expand |
> -----Original Message----- > From: openembedded-core@lists.openembedded.org <openembedded- > core@lists.openembedded.org> On Behalf Of Mateusz Marciniec > Sent: den 19 augusti 2022 13:34 > To: openembedded-core@lists.openembedded.org > Cc: Mateusz Marciniec <mateuszmar2@gmail.com>; Tomasz Dziendzielski > <tomasz.dziendzielski@gmail.com> > Subject: [OE-core] [PATCH] util-linux: Remove raw flags in EXTRA_OECONF > > Having both enable and disable flags for raw is confusing. > Raw should not be enabled so both flags can be removed. > > Signed-off-by: Mateusz Marciniec <mateuszmar2@gmail.com> > Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com> > --- > meta/recipes-core/util-linux/util-linux_2.38.1.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-core/util-linux/util-linux_2.38.1.bb > b/meta/recipes-core/util-linux/util-linux_2.38.1.bb > index 8a7b47a0c6..a93ae83cd6 100644 > --- a/meta/recipes-core/util-linux/util-linux_2.38.1.bb > +++ b/meta/recipes-core/util-linux/util-linux_2.38.1.bb > @@ -69,12 +69,12 @@ EXTRA_OECONF = "\ > --enable-libuuid --enable-libblkid \ > \ > --enable-fsck --enable-kill --enable-last --enable-mesg \ > - --enable-mount --enable-partx --enable-raw --enable-rfkill \ > + --enable-mount --enable-partx --enable-rfkill \ > --enable-unshare --enable-write \ > \ > --disable-bfs --disable-login \ > --disable-makeinstall-chown --disable-minix --disable-newgrp \ > - --disable-use-tty-group --disable-vipw --disable-raw \ > + --disable-use-tty-group --disable-vipw \ A quick look in configure.ac for util-linux indicates that it will start to look for linux/raw.h and enable raw support if it exists if you remove the --disable-raw option. So you should leave the --disable-raw option to maintain the current deterministic behavior. > \ > --without-udev \ > \ > -- > 2.37.1 //Peter
Yes, you are right, I corrected it in the new version of patch. Thanks for pointing that out. Best Regards, Mateusz Marciniec pt., 19 sie 2022 o 16:38 Peter Kjellerstedt <peter.kjellerstedt@axis.com> napisaĆ(a): > > -----Original Message----- > > From: openembedded-core@lists.openembedded.org <openembedded- > > core@lists.openembedded.org> On Behalf Of Mateusz Marciniec > > Sent: den 19 augusti 2022 13:34 > > To: openembedded-core@lists.openembedded.org > > Cc: Mateusz Marciniec <mateuszmar2@gmail.com>; Tomasz Dziendzielski > > <tomasz.dziendzielski@gmail.com> > > Subject: [OE-core] [PATCH] util-linux: Remove raw flags in EXTRA_OECONF > > > > Having both enable and disable flags for raw is confusing. > > Raw should not be enabled so both flags can be removed. > > > > Signed-off-by: Mateusz Marciniec <mateuszmar2@gmail.com> > > Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com> > > --- > > meta/recipes-core/util-linux/util-linux_2.38.1.bb | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/meta/recipes-core/util-linux/util-linux_2.38.1.bb > > b/meta/recipes-core/util-linux/util-linux_2.38.1.bb > > index 8a7b47a0c6..a93ae83cd6 100644 > > --- a/meta/recipes-core/util-linux/util-linux_2.38.1.bb > > +++ b/meta/recipes-core/util-linux/util-linux_2.38.1.bb > > @@ -69,12 +69,12 @@ EXTRA_OECONF = "\ > > --enable-libuuid --enable-libblkid \ > > \ > > --enable-fsck --enable-kill --enable-last --enable-mesg \ > > - --enable-mount --enable-partx --enable-raw --enable-rfkill \ > > + --enable-mount --enable-partx --enable-rfkill \ > > --enable-unshare --enable-write \ > > \ > > --disable-bfs --disable-login \ > > --disable-makeinstall-chown --disable-minix --disable-newgrp \ > > - --disable-use-tty-group --disable-vipw --disable-raw \ > > + --disable-use-tty-group --disable-vipw \ > > A quick look in configure.ac for util-linux indicates that it will > start to look for linux/raw.h and enable raw support if it exists > if you remove the --disable-raw option. So you should leave the > --disable-raw option to maintain the current deterministic behavior. > > > \ > > --without-udev \ > > \ > > -- > > 2.37.1 > > //Peter > >
diff --git a/meta/recipes-core/util-linux/util-linux_2.38.1.bb b/meta/recipes-core/util-linux/util-linux_2.38.1.bb index 8a7b47a0c6..a93ae83cd6 100644 --- a/meta/recipes-core/util-linux/util-linux_2.38.1.bb +++ b/meta/recipes-core/util-linux/util-linux_2.38.1.bb @@ -69,12 +69,12 @@ EXTRA_OECONF = "\ --enable-libuuid --enable-libblkid \ \ --enable-fsck --enable-kill --enable-last --enable-mesg \ - --enable-mount --enable-partx --enable-raw --enable-rfkill \ + --enable-mount --enable-partx --enable-rfkill \ --enable-unshare --enable-write \ \ --disable-bfs --disable-login \ --disable-makeinstall-chown --disable-minix --disable-newgrp \ - --disable-use-tty-group --disable-vipw --disable-raw \ + --disable-use-tty-group --disable-vipw \ \ --without-udev \ \