| Message ID | 20220816075432.22347-1-kai.kang@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | distrooverrides.bbclass: use IMAGE_CLASSES | expand |
This class functionality isn't limited to images. On Tue, Aug 16, 2022 at 12:54 AM kai <kai.kang@windriver.com> wrote: > From: Kai Kang <kai.kang@windriver.com> > > Update comment in distrooverrides.bbclass to use IMAGE_CLASSES rather > than globally with INHERIT. > > Signed-off-by: Kai Kang <kai.kang@windriver.com> > --- > meta/classes-recipe/distrooverrides.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/distrooverrides.bbclass > b/meta/classes-recipe/distrooverrides.bbclass > index 8d9d7cda7d..b5346b465e 100644 > --- a/meta/classes-recipe/distrooverrides.bbclass > +++ b/meta/classes-recipe/distrooverrides.bbclass > @@ -17,7 +17,7 @@ > # > # The class is meant to be used in a layer.conf or distro > # .inc file with: > -# INHERIT += "distrooverrides" > +# IMAGE_CLASSES += "distrooverrides" > # DISTRO_FEATURES_OVERRIDES += "my-feature" > # > # Beware that this part of OVERRIDES changes during parsing, so usage > -- > 2.17.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#169428): > https://lists.openembedded.org/g/openembedded-core/message/169428 > Mute This Topic: https://lists.openembedded.org/mt/93054585/3617123 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > kergoth@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On 8/16/22 22:55, Christopher Larson wrote: > This class functionality isn't limited to images. If not, it may need to move to classes-global. Otherwise it fails to parse: ERROR: ParseError in configuration INHERITs: Could not inherit file classes/distrooverrides.bbclass > > On Tue, Aug 16, 2022 at 12:54 AM kai <kai.kang@windriver.com> wrote: > > From: Kai Kang <kai.kang@windriver.com> > > Update comment in distrooverrides.bbclass to use IMAGE_CLASSES rather > than globally with INHERIT. > > Signed-off-by: Kai Kang <kai.kang@windriver.com> > --- > meta/classes-recipe/distrooverrides.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/distrooverrides.bbclass > b/meta/classes-recipe/distrooverrides.bbclass > index 8d9d7cda7d..b5346b465e 100644 > --- a/meta/classes-recipe/distrooverrides.bbclass > +++ b/meta/classes-recipe/distrooverrides.bbclass > @@ -17,7 +17,7 @@ > # > # The class is meant to be used in a layer.conf or distro > # .inc file with: > -# INHERIT += "distrooverrides" > +# IMAGE_CLASSES += "distrooverrides" > # DISTRO_FEATURES_OVERRIDES += "my-feature" > # > # Beware that this part of OVERRIDES changes during parsing, so usage > -- > 2.17.1 > > > > > > > -- > Christopher Larson > chris_larson@mentor.com, chris.larson@siemens.com, kergoth@gmail.com > Principal Software Engineer, Embedded Linux Solutions, Siemens Digital > Industries Software > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#169439):https://lists.openembedded.org/g/openembedded-core/message/169439 > Mute This Topic:https://lists.openembedded.org/mt/93054585/3616933 > Group Owner:openembedded-core+owner@lists.openembedded.org > Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub [kai.kang@windriver.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Thu, 2022-08-18 at 09:54 +0800, kai wrote: > On 8/16/22 22:55, Christopher Larson wrote: > > > This class functionality isn't limited to images. > If not, it may need to move to classes-global. Otherwise it fails to > parse: > ERROR: ParseError in configuration INHERITs: Could not inherit file > classes/distrooverrides.bbclass > > I've moved this back to the classes directory for now until we can decide on how it should be used. It is one of those cases where either can work. Cheers, Richard
diff --git a/meta/classes-recipe/distrooverrides.bbclass b/meta/classes-recipe/distrooverrides.bbclass index 8d9d7cda7d..b5346b465e 100644 --- a/meta/classes-recipe/distrooverrides.bbclass +++ b/meta/classes-recipe/distrooverrides.bbclass @@ -17,7 +17,7 @@ # # The class is meant to be used in a layer.conf or distro # .inc file with: -# INHERIT += "distrooverrides" +# IMAGE_CLASSES += "distrooverrides" # DISTRO_FEATURES_OVERRIDES += "my-feature" # # Beware that this part of OVERRIDES changes during parsing, so usage