| Message ID | 20220711083309.1749253-2-sean@geanix.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] zlib: split src_uri into inc file | expand |
On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote: > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > --- > meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb I can see what this does, but why? Who would want this and why? There is no detail in the commit messages. Also no maintainers entry which will break QA checks. Cheers, Richard
On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote: > On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote: > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > > --- > > meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb > > I can see what this does, but why? Who would want this and why? There > is no detail in the commit messages. Also no maintainers entry which > will break QA checks. > > Cheers, > > Richard > > Hi Richard, We have some software that depends on minizip. I don't know if an extra package zlib-minizip or this was the prefered way to add it? /Sean
On Mon, 2022-07-11 at 10:53 +0200, Sean Nyekjaer wrote: > On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote: > > On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote: > > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > > > --- > > > meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb > > > > I can see what this does, but why? Who would want this and why? There > > is no detail in the commit messages. Also no maintainers entry which > > will break QA checks. > > > > Cheers, > > > > Richard > > > > > > Hi Richard, > > We have some software that depends on minizip. > I don't know if an extra package zlib-minizip or this was the prefered > way to add it? I think an extra package on the existing recipe may be simpler and easier maintenance. Commit messages do need a bit more information in them too, it isn't enough to say what something does, it needs to say why. Cheers, Richard
On Mon, Jul 11, 2022 at 09:58:38AM +0100, Richard Purdie wrote: > On Mon, 2022-07-11 at 10:53 +0200, Sean Nyekjaer wrote: > > On Mon, Jul 11, 2022 at 09:46:58AM +0100, Richard Purdie wrote: > > > On Mon, 2022-07-11 at 10:33 +0200, Sean Nyekjaer wrote: > > > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > > > > --- > > > > meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb > > > > > > I can see what this does, but why? Who would want this and why? There > > > is no detail in the commit messages. Also no maintainers entry which > > > will break QA checks. > > > > > > Cheers, > > > > > > Richard > > > > > > > > > > Hi Richard, > > > > We have some software that depends on minizip. > > I don't know if an extra package zlib-minizip or this was the prefered > > way to add it? > > I think an extra package on the existing recipe may be simpler and > easier maintenance. > > Commit messages do need a bit more information in them too, it isn't > enough to say what something does, it needs to say why. > > Cheers, > > Richard I think it will be quite hacky to do it as one recipe, as zlib and minizip is to seperate autotools projects and zlib isn't even compatible with the autotools class. I could something with addtask but I don't think it will be very readable. Any ideas? /Sean
diff --git a/meta/recipes-core/zlib/minizip_1.2.12.bb b/meta/recipes-core/zlib/minizip_1.2.12.bb new file mode 100644 index 0000000000..548bb8c62b --- /dev/null +++ b/meta/recipes-core/zlib/minizip_1.2.12.bb @@ -0,0 +1,15 @@ +SUMMARY = "Minimal zip library using deflate from zlib" +HOMEPAGE = "http://zlib.net/" +SECTION = "libs" +LICENSE = "Zlib" +LIC_FILES_CHKSUM = "file://MiniZip64_info.txt;beginline=53;endline=73;md5=02090b3a3511ed8a910b77dae6906cea" + +include zlib.inc + +inherit autotools + +DEPENDS = "zlib" + +S = "${WORKDIR}/zlib-${PV}/contrib/minizip" + +BBCLASSEXTEND = "native nativesdk"
Signed-off-by: Sean Nyekjaer <sean@geanix.com> --- meta/recipes-core/zlib/minizip_1.2.12.bb | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 meta/recipes-core/zlib/minizip_1.2.12.bb