[2/3] strace: Drop redundant oe_runmake parameter

Message ID 20220622191615.10168-2-niko.mauno@vaisala.com
State Accepted, archived
Commit c314316831ac602a31275c303c36974e8a632ce5
Headers show
Series [1/3] ptest.bbclass: Honor PARALLEL_MAKE, PARALLEL_MAKEINST | expand

Commit Message

Niko Mauno June 22, 2022, 7:16 p.m. UTC
PARALLEL_MAKE is now honored in ptest.bbclass, so drop redundant
parameter from oe_runmake call.

Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
---
 meta/recipes-devtools/strace/strace_5.17.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Ceresoli June 23, 2022, 9:30 a.m. UTC | #1
Hi Niko,

On Wed, 22 Jun 2022 22:16:14 +0300
"niko.mauno@vaisala.com via lists.openembedded.org"
<niko.mauno=vaisala.com@lists.openembedded.org> wrote:

> PARALLEL_MAKE is now honored in ptest.bbclass, so drop redundant
> parameter from oe_runmake call.
> 
> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
> ---
>  meta/recipes-devtools/strace/strace_5.17.bb | 2 +-

Thank you for your patches!

Unfortunately this patch does not apply as strace has been bumped to
5.18 by a recent commit. Could you send a v2 series with this updated
please?
Niko Mauno June 23, 2022, 4:53 p.m. UTC | #2
On 6/23/22 12:30, Luca Ceresoli via lists.openembedded.org wrote:
> Unfortunately this patch does not apply as strace has been bumped to
> 5.18 by a recent commit. Could you send a v2 series with this updated
> please?

Hi Luca, new v2 series sent with updated strace version: 
https://patchwork.yoctoproject.org/project/oe-core/list/?series=5032

-Niko
Luca Ceresoli June 24, 2022, 10:30 a.m. UTC | #3
Hi Niko,

On Thu, 23 Jun 2022 19:53:58 +0300
"niko.mauno@vaisala.com via lists.openembedded.org"
<niko.mauno=vaisala.com@lists.openembedded.org> wrote:

> On 6/23/22 12:30, Luca Ceresoli via lists.openembedded.org wrote:
> > Unfortunately this patch does not apply as strace has been bumped to
> > 5.18 by a recent commit. Could you send a v2 series with this updated
> > please?  
> 
> Hi Luca, new v2 series sent with updated strace version: 
> https://patchwork.yoctoproject.org/project/oe-core/list/?series=5032

Thank you. Yesterday I had already picked patches 1 and 3 for testing
on the autobuilders and all builds succeeded. I'm taking your v2 for my
next testing run today.

Patch

diff --git a/meta/recipes-devtools/strace/strace_5.17.bb b/meta/recipes-devtools/strace/strace_5.17.bb
index c7fd9edf40..0542780c00 100644
--- a/meta/recipes-devtools/strace/strace_5.17.bb
+++ b/meta/recipes-devtools/strace/strace_5.17.bb
@@ -34,7 +34,7 @@  TESTDIR = "tests"
 PTEST_BUILD_HOST_PATTERN = "^(DEB_CHANGELOGTIME|RPM_CHANGELOGTIME|WARN_CFLAGS_FOR_BUILD|LDFLAGS_FOR_BUILD)"
 
 do_compile_ptest() {
-	oe_runmake ${PARALLEL_MAKE} -C ${TESTDIR} buildtest-TESTS
+	oe_runmake -C ${TESTDIR} buildtest-TESTS
 }
 
 do_install_ptest() {