Message ID | 20220616055414.42319-1-muhammad_hamza@mentor.com |
---|---|
State | New |
Headers | show |
Series | [v1] glibc-locale: work around host-user-contaminated QA failure | expand |
On 6/16/22 07:54, Muhammad Hamza wrote: > Work around long standing periodic host-user-contaminated QA failure by > explicitly correcting the ownership. > > See `glibc-locale: Rewrite do_install using install utility instead of cp` > on the oe-core mailing list for discussion. This should be dropped when > a real fix is implemented. > > Explicitly disable host-user-contaminated to further work around the > pseudo bug. With pseudo acting up, even if the ownership is correct, it > may well think it is not, so just sidestep the issue until upstream > fixes the root cause. > > Signed-off-by: Christopher Larson <chris_larson@mentor.com> > > Signed-off-by: Muhammad Hamza <muhammad_hamza@mentor.com> > --- > meta/recipes-core/glibc/glibc-locale.inc | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/meta/recipes-core/glibc/glibc-locale.inc b/meta/recipes-core/glibc/glibc-locale.inc > index b8de7d3192..34c178268b 100644 > --- a/meta/recipes-core/glibc/glibc-locale.inc > +++ b/meta/recipes-core/glibc/glibc-locale.inc > @@ -69,6 +69,23 @@ FILES:localedef = "${bindir}/localedef" > > LOCALETREESRC = "${COMPONENTS_DIR}/${PACKAGE_ARCH}/glibc-stash-locale" > > +# Work around long standing periodic host-user-contaminated QA failure by > +# explicitly correcting the ownership. > +# > +# See `glibc-locale: Rewrite do_install using install utility instead of cp` > +# on the oe-core mailing list for discussion. This should be dropped when > +# a real fix is implemented. > + > +do_prep_locale_tree_append () { > + chown -R root:root $treedir > +} > + > +# Explicitly disable host-user-contaminated to further work around the > +# pseudo bug. With pseudo acting up, even if the ownership is correct, > +# it may well think it is not, so just sidestep the issue until upstream > +# fixes the root cause. > +ERROR_QA_remove = "host-user-contaminated" > + > copy_locale_files() { > local dir=$1 mode=$2 > > Given the append/remove override syntax used here, I guess this patch is aimed at an older Yocto release, and shouldn't be necessary for master ? Jacob
On Thu, 2022-06-16 at 10:54 +0500, Muhammad Hamza wrote: > Work around long standing periodic host-user-contaminated QA failure by > explicitly correcting the ownership. > > See `glibc-locale: Rewrite do_install using install utility instead of cp` > on the oe-core mailing list for discussion. This should be dropped when > a real fix is implemented. > > Explicitly disable host-user-contaminated to further work around the > pseudo bug. With pseudo acting up, even if the ownership is correct, it > may well think it is not, so just sidestep the issue until upstream > fixes the root cause. > > Signed-off-by: Christopher Larson <chris_larson@mentor.com> > > Signed-off-by: Muhammad Hamza <muhammad_hamza@mentor.com> > --- > meta/recipes-core/glibc/glibc-locale.inc | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/meta/recipes-core/glibc/glibc-locale.inc b/meta/recipes-core/glibc/glibc-locale.inc > index b8de7d3192..34c178268b 100644 > --- a/meta/recipes-core/glibc/glibc-locale.inc > +++ b/meta/recipes-core/glibc/glibc-locale.inc > @@ -69,6 +69,23 @@ FILES:localedef = "${bindir}/localedef" > > LOCALETREESRC = "${COMPONENTS_DIR}/${PACKAGE_ARCH}/glibc-stash-locale" > > +# Work around long standing periodic host-user-contaminated QA failure by > +# explicitly correcting the ownership. > +# > +# See `glibc-locale: Rewrite do_install using install utility instead of cp` > +# on the oe-core mailing list for discussion. This should be dropped when > +# a real fix is implemented. > + > +do_prep_locale_tree_append () { > + chown -R root:root $treedir > +} > + > +# Explicitly disable host-user-contaminated to further work around the > +# pseudo bug. With pseudo acting up, even if the ownership is correct, > +# it may well think it is not, so just sidestep the issue until upstream > +# fixes the root cause. > +ERROR_QA_remove = "host-user-contaminated" > + > copy_locale_files() { > local dir=$1 mode=$2 At a quick search I couldn't find the email you reference so it probably isn't recent. As Jacob mentions, this syntax is invalid for master. Was this not fixed properly by something like: https://git.yoctoproject.org/poky/commit/?id=2e75c084f2cfe7617de3b9a4b006caa3fee687a6 ? We're definitely not taking this without more details on what is going on and a correct patch as this looks like a workaround. Cheers, Richard
Hello, my bad, yes these changes are on some older branch and don't need upstream. Thanks, Hamza -----Original Message----- From: Richard Purdie <richard.purdie@linuxfoundation.org> Sent: Thursday, June 16, 2022 3:23 PM To: Hamza, Muhammad <Muhammad_Hamza@mentor.com>; openembedded-core@lists.openembedded.org Cc: Larson, Chris <Chris_Larson@mentor.com> Subject: Re: [OE-core] [PATCH v1] glibc-locale: work around host-user-contaminated QA failure On Thu, 2022-06-16 at 10:54 +0500, Muhammad Hamza wrote: > Work around long standing periodic host-user-contaminated QA failure > by explicitly correcting the ownership. > > See `glibc-locale: Rewrite do_install using install utility instead of > cp` on the oe-core mailing list for discussion. This should be dropped > when a real fix is implemented. > > Explicitly disable host-user-contaminated to further work around the > pseudo bug. With pseudo acting up, even if the ownership is correct, > it may well think it is not, so just sidestep the issue until upstream > fixes the root cause. > > Signed-off-by: Christopher Larson <chris_larson@mentor.com> > > Signed-off-by: Muhammad Hamza <muhammad_hamza@mentor.com> > --- > meta/recipes-core/glibc/glibc-locale.inc | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/meta/recipes-core/glibc/glibc-locale.inc > b/meta/recipes-core/glibc/glibc-locale.inc > index b8de7d3192..34c178268b 100644 > --- a/meta/recipes-core/glibc/glibc-locale.inc > +++ b/meta/recipes-core/glibc/glibc-locale.inc > @@ -69,6 +69,23 @@ FILES:localedef = "${bindir}/localedef" > > LOCALETREESRC = "${COMPONENTS_DIR}/${PACKAGE_ARCH}/glibc-stash-locale" > > +# Work around long standing periodic host-user-contaminated QA > +failure by # explicitly correcting the ownership. > +# > +# See `glibc-locale: Rewrite do_install using install utility instead > +of cp` # on the oe-core mailing list for discussion. This should be > +dropped when # a real fix is implemented. > + > +do_prep_locale_tree_append () { > + chown -R root:root $treedir > +} > + > +# Explicitly disable host-user-contaminated to further work around > +the # pseudo bug. With pseudo acting up, even if the ownership is > +correct, # it may well think it is not, so just sidestep the issue > +until upstream # fixes the root cause. > +ERROR_QA_remove = "host-user-contaminated" > + > copy_locale_files() { > local dir=$1 mode=$2 At a quick search I couldn't find the email you reference so it probably isn't recent. As Jacob mentions, this syntax is invalid for master. Was this not fixed properly by something like: https://git.yoctoproject.org/poky/commit/?id=2e75c084f2cfe7617de3b9a4b006caa3fee687a6 ? We're definitely not taking this without more details on what is going on and a correct patch as this looks like a workaround. Cheers, Richard
diff --git a/meta/recipes-core/glibc/glibc-locale.inc b/meta/recipes-core/glibc/glibc-locale.inc index b8de7d3192..34c178268b 100644 --- a/meta/recipes-core/glibc/glibc-locale.inc +++ b/meta/recipes-core/glibc/glibc-locale.inc @@ -69,6 +69,23 @@ FILES:localedef = "${bindir}/localedef" LOCALETREESRC = "${COMPONENTS_DIR}/${PACKAGE_ARCH}/glibc-stash-locale" +# Work around long standing periodic host-user-contaminated QA failure by +# explicitly correcting the ownership. +# +# See `glibc-locale: Rewrite do_install using install utility instead of cp` +# on the oe-core mailing list for discussion. This should be dropped when +# a real fix is implemented. + +do_prep_locale_tree_append () { + chown -R root:root $treedir +} + +# Explicitly disable host-user-contaminated to further work around the +# pseudo bug. With pseudo acting up, even if the ownership is correct, +# it may well think it is not, so just sidestep the issue until upstream +# fixes the root cause. +ERROR_QA_remove = "host-user-contaminated" + copy_locale_files() { local dir=$1 mode=$2