[1/4] xorg-lib-common: allow to build for wayland

Message ID 20220531190620.186764-1-f_l_k@t-online.de
State New
Headers show
Series [1/4] xorg-lib-common: allow to build for wayland | expand

Commit Message

Markus Volk May 31, 2022, 7:06 p.m. UTC
Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Ceresoli June 1, 2022, 3 p.m. UTC | #1
Hi Markus,

On Tue, 31 May 2022 21:06:17 +0200
"Markus Volk" <f_l_k@t-online.de> wrote:

> Signed-off-by: Markus Volk <f_l_k@t-online.de>

I applied patches 1 to 3 of this series to my testing branch and got
these failures:

stdio: ERROR: Nothing PROVIDES 'font-util' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libfontenc_1.1.4.bb DEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'libxfont2' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont2_2.0.5.bb RDEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'libxfont2-dev' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont2_2.0.5.bb RDEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'libfontenc' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libfontenc_1.1.4.bb RDEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'libfontenc-dev' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libfontenc_1.1.4.bb RDEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'libxfont-dev' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont_1.5.4.bb RDEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'libxfont' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont_1.5.4.bb RDEPENDS on or otherwise requires it)

See the full logs:

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/12/logs/errors
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/15/logs/errors
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/15/logs/stdio
Markus Volk June 1, 2022, 3:10 p.m. UTC | #2
Hi Luca,

i've sent a patch that should hopefully fix your issue

Am 01.06.22 um 17:00 schrieb Luca Ceresoli:
> Hi Markus,
>
> On Tue, 31 May 2022 21:06:17 +0200
> "Markus Volk" <f_l_k@t-online.de> wrote:
>
>> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> I applied patches 1 to 3 of this series to my testing branch and got
> these failures:
>
> stdio: ERROR: Nothing PROVIDES 'font-util' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libfontenc_1.1.4.bb DEPENDS on or otherwise requires it)
> stdio: ERROR: Nothing RPROVIDES 'libxfont2' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont2_2.0.5.bb RDEPENDS on or otherwise requires it)
> stdio: ERROR: Nothing RPROVIDES 'libxfont2-dev' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont2_2.0.5.bb RDEPENDS on or otherwise requires it)
> stdio: ERROR: Nothing RPROVIDES 'libfontenc' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libfontenc_1.1.4.bb RDEPENDS on or otherwise requires it)
> stdio: ERROR: Nothing RPROVIDES 'libfontenc-dev' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libfontenc_1.1.4.bb RDEPENDS on or otherwise requires it)
> stdio: ERROR: Nothing RPROVIDES 'libxfont-dev' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont_1.5.4.bb RDEPENDS on or otherwise requires it)
> stdio: ERROR: Nothing RPROVIDES 'libxfont' (but /home/pokybuild/yocto-worker/no-x11/build/meta/recipes-graphics/xorg-lib/libxfont_1.5.4.bb RDEPENDS on or otherwise requires it)
>
> See the full logs:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/12/logs/errors
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/12/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/15/logs/errors
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5304/steps/15/logs/stdio
>
Luca Ceresoli June 3, 2022, 8:17 p.m. UTC | #3
Hi Markus,

On Wed, 1 Jun 2022 17:10:45 +0200
"Markus Volk" <f_l_k@t-online.de> wrote:

> Hi Luca,
> 
> i've sent a patch that should hopefully fix your issue

I guess you refer to:

  [oe-core][PATCH] xorg-font-common.inc: allow to build for wayland

and so I ran a build test with the above patch + the 4 patches in this
series.

However I would find it a lot clearer if you instead sent a v2 series
with all the 5 patches (1 new + 4 as in the previous version). It would
avoid any confusion.

About the test, unfortunately we are still having failures:

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5316/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5316/steps/14/logs/stdio
Markus Volk June 4, 2022, 5:29 a.m. UTC | #4
You are certainly right about that. The error message reached me just 
before I had to go to work and so I just quickly changed the file 
without testing anything with it. That's why I hadn't sent out a new 
patchset yet, but I'll make up for that completely this time. Hopefully 
also with a solution for your current problem.
> However I would find it a lot clearer if you instead sent a v2 series
> with all the 5 patches (1 new + 4 as in the previous version). It would
> avoid any confusion.
>
> About the test, unfortunately we are still having failures:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5316/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/5316/steps/14/logs/stdio
>
Ross Burton June 6, 2022, 10:20 a.m. UTC | #5
On 31 May 2022, at 20:06, Markus Volk via lists.openembedded.org <f_l_k=t-online.de@lists.openembedded.org> wrote:
>
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> ---
> meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> index 60bc8c76fa..30122f2bfa 100644
> --- a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> +++ b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> @@ -23,4 +23,4 @@ UNKNOWN_CONFIGURE_OPT_IGNORE += "--enable-malloc0returnsnull --disable-malloc0re
>                                 --without-xmlto --with-xmlto \
> "
>
> -REQUIRED_DISTRO_FEATURES ?= "x11"
> +ANY_OF_DISTRO_FEATURES ?= "x11 wayland"

If you’re doing this you might as well just remove the feature check, as the entire point of this was that it should be *impossible* to build the X11 stack on distros which have disabled X11.

Obviously, eg libxrandr isn’t going to actually work on a pure Wayland system, as there isn’t going to be an X server.

So, the question is what is the actual problem you’re trying to solve here, as this isn’t the solution.

Ross

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Patch

diff --git a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
index 60bc8c76fa..30122f2bfa 100644
--- a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
+++ b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
@@ -23,4 +23,4 @@  UNKNOWN_CONFIGURE_OPT_IGNORE += "--enable-malloc0returnsnull --disable-malloc0re
                                 --without-xmlto --with-xmlto \
 "
 
-REQUIRED_DISTRO_FEATURES ?= "x11"
+ANY_OF_DISTRO_FEATURES ?= "x11 wayland"