diff mbox series

[v2] libavtp: add recipe to be able to use aaf config for alsa-plugins

Message ID 20220531155704.682685-1-marcel@ziswiler.com
State New
Headers show
Series [v2] libavtp: add recipe to be able to use aaf config for alsa-plugins | expand

Commit Message

Marcel Ziswiler May 31, 2022, 3:57 p.m. UTC 
From: Peter Bergin <peter@berginkonsult.se>

In order to enable configuration option aaf (AVTP Audio Format)
used for AVB the library libavtp is a dependency but no recipe for
this library was present. aaf support for alsa-plugins was
introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.

Signed-off-by: Peter Bergin <peter@berginkonsult.se>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---
Resurrect from mailing list [1] as this is still not upstream.
End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World in the TSN & Linux track next
month [2].

[1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/
[2] https://events.weka-fachmedien.de/embedded-world-conference/program/

Changes in v2:
- Updated SRC_URI specifying mandatory protocol as https.
- Updated SRCREV to latest.

 meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb

Comments

Khem Raj May 31, 2022, 4:38 p.m. UTC | #1 
On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Peter Bergin <peter@berginkonsult.se>
>
> In order to enable configuration option aaf (AVTP Audio Format)
> used for AVB the library libavtp is a dependency but no recipe for
> this library was present. aaf support for alsa-plugins was
> introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.
>
> Signed-off-by: Peter Bergin <peter@berginkonsult.se>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
> Resurrect from mailing list [1] as this is still not upstream.
> End-to-end tested on Verdin iMX8M Plus.
> Will talk about it at the Embedded World in the TSN & Linux track next
> month [2].
>
> [1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/
> [2] https://events.weka-fachmedien.de/embedded-world-conference/program/
>
> Changes in v2:
> - Updated SRC_URI specifying mandatory protocol as https.
> - Updated SRCREV to latest.
>
>  meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++

There was a 0.2.0 release https://github.com/Avnu/libavtp/releases/tag/v0.2.0
so I wonder if we should use the release tagged SRC_URI and call the PV = 0.2.0

>  1 file changed, 16 insertions(+)
>  create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb
>
> diff --git a/meta/recipes-multimedia/libavtp/libavtp_git.bb b/meta/recipes-multimedia/libavtp/libavtp_git.bb
> new file mode 100644
> index 0000000000..aefbee56ea
> --- /dev/null
> +++ b/meta/recipes-multimedia/libavtp/libavtp_git.bb
> @@ -0,0 +1,16 @@
> +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \
> +               specified in IEEE 1722-2016 spec."
> +HOMEPAGE = "https://github.com/Avnu/libavtp"
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
> +
> +PROVIDES = "avtp"

why is this provides needed ?

> +
> +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=master;protocol=https"
> +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit meson pkgconfig
> +
> +EXTRA_OEMESON = "-Dtests=disabled"
> --
> 2.36.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#166321): https://lists.openembedded.org/g/openembedded-core/message/166321
> Mute This Topic: https://lists.openembedded.org/mt/91454504/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Peter Bergin May 31, 2022, 6:36 p.m. UTC | #2 
Hi,

thanks Marcel for bumping this patch again!

On 2022-05-31 18:38, Khem Raj wrote:
> On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>> From: Peter Bergin <peter@berginkonsult.se>
>>
>> In order to enable configuration option aaf (AVTP Audio Format)
>> used for AVB the library libavtp is a dependency but no recipe for
>> this library was present. aaf support for alsa-plugins was
>> introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.
>>
>> Signed-off-by: Peter Bergin <peter@berginkonsult.se>
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>
>> ---
>> Resurrect from mailing list [1] as this is still not upstream.
>> End-to-end tested on Verdin iMX8M Plus.
>> Will talk about it at the Embedded World in the TSN & Linux track next
>> month [2].
>>
>> [1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/
>> [2] https://events.weka-fachmedien.de/embedded-world-conference/program/
>>
>> Changes in v2:
>> - Updated SRC_URI specifying mandatory protocol as https.
>> - Updated SRCREV to latest.
>>
>>   meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++
> There was a 0.2.0 release https://github.com/Avnu/libavtp/releases/tag/v0.2.0
> so I wonder if we should use the release tagged SRC_URI and call the PV = 0.2.0
This tag was set after I sent my initial patch. I think this is a good 
thing to do.
>
>>   1 file changed, 16 insertions(+)
>>   create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb
>>
>> diff --git a/meta/recipes-multimedia/libavtp/libavtp_git.bb b/meta/recipes-multimedia/libavtp/libavtp_git.bb
>> new file mode 100644
>> index 0000000000..aefbee56ea
>> --- /dev/null
>> +++ b/meta/recipes-multimedia/libavtp/libavtp_git.bb
>> @@ -0,0 +1,16 @@
>> +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \
>> +               specified in IEEE 1722-2016 spec."
>> +HOMEPAGE = "https://github.com/Avnu/libavtp"
>> +LICENSE = "BSD-3-Clause"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
>> +
>> +PROVIDES = "avtp"
> why is this provides needed ?

It is because recipe meta/recipes-multimedia/alsa/alsa-plugins_1.2.6.bb 
has this PACKAGECONFIG:

   PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"

So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?

/Peter

>> +
>> +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=master;protocol=https"
>> +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +inherit meson pkgconfig
>> +
>> +EXTRA_OEMESON = "-Dtests=disabled"
>> --
>> 2.36.1
>>
>>
>>
>>
>>
>> 
>>
Khem Raj May 31, 2022, 7:01 p.m. UTC | #3 
Maybe call the recipe avtp

On Tue, May 31, 2022 at 11:36 AM Peter Bergin <peter@berginkonsult.se>
wrote:

> Hi,
>
> thanks Marcel for bumping this patch again!
>
> On 2022-05-31 18:38, Khem Raj wrote:
> > On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <marcel@ziswiler.com>
> wrote:
> >> From: Peter Bergin <peter@berginkonsult.se>
> >>
> >> In order to enable configuration option aaf (AVTP Audio Format)
> >> used for AVB the library libavtp is a dependency but no recipe for
> >> this library was present. aaf support for alsa-plugins was
> >> introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.
> >>
> >> Signed-off-by: Peter Bergin <peter@berginkonsult.se>
> >> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >>
> >> ---
> >> Resurrect from mailing list [1] as this is still not upstream.
> >> End-to-end tested on Verdin iMX8M Plus.
> >> Will talk about it at the Embedded World in the TSN & Linux track next
> >> month [2].
> >>
> >> [1]
> https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/
> >> [2]
> https://events.weka-fachmedien.de/embedded-world-conference/program/
> >>
> >> Changes in v2:
> >> - Updated SRC_URI specifying mandatory protocol as https.
> >> - Updated SRCREV to latest.
> >>
> >>   meta/recipes-multimedia/libavtp/libavtp_git.bb | 16 ++++++++++++++++
> > There was a 0.2.0 release
> https://github.com/Avnu/libavtp/releases/tag/v0.2.0
> > so I wonder if we should use the release tagged SRC_URI and call the PV
> = 0.2.0
> This tag was set after I sent my initial patch. I think this is a good
> thing to do.
> >
> >>   1 file changed, 16 insertions(+)
> >>   create mode 100644 meta/recipes-multimedia/libavtp/libavtp_git.bb
> >>
> >> diff --git a/meta/recipes-multimedia/libavtp/libavtp_git.bb
> b/meta/recipes-multimedia/libavtp/libavtp_git.bb
> >> new file mode 100644
> >> index 0000000000..aefbee56ea
> >> --- /dev/null
> >> +++ b/meta/recipes-multimedia/libavtp/libavtp_git.bb
> >> @@ -0,0 +1,16 @@
> >> +DESCRIPTION = "Open source implementation of Audio Video Transport
> Protocol (AVTP) \
> >> +               specified in IEEE 1722-2016 spec."
> >> +HOMEPAGE = "https://github.com/Avnu/libavtp"
> >> +LICENSE = "BSD-3-Clause"
> >> +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
> >> +
> >> +PROVIDES = "avtp"
> > why is this provides needed ?
>
> It is because recipe meta/recipes-multimedia/alsa/alsa-plugins_1.2.6.bb
> has this PACKAGECONFIG:
>
>    PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"
>
> So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?
>
> /Peter
>
> >> +
> >> +SRC_URI = "git://
> github.com/Avnu/libavtp.git;branch=master;protocol=https"
> >> +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +inherit meson pkgconfig
> >> +
> >> +EXTRA_OEMESON = "-Dtests=disabled"
> >> --
> >> 2.36.1
> >>
> >>
> >>
> >>
> >>
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> Links: You receive all messages sent to this group.
> >> View/Reply Online (#166324):
> https://lists.openembedded.org/g/openembedded-core/message/166324
> >> Mute This Topic: https://lists.openembedded.org/mt/91454504/3617552
> >> Group Owner: openembedded-core+owner@lists.openembedded.org
> >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> peter@berginkonsult.se]
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >>
>
Khem Raj May 31, 2022, 9 p.m. UTC | #4 
On Tue, May 31, 2022 at 1:14 PM Marcel Ziswiler <marcel.ziswiler@toradex.com>
wrote:

> On Tue, 2022-05-31 at 12:01 -0700, Khem Raj wrote:
> > Maybe call the recipe avtp
>
> No, here I disagree. As mentioned before the project and everything is
> really called libavtp everywhere. So I
> think the better solution is to consistently use libavtp in
> openembedded-core everywhere as well.


That’s fine with me I don’t have hard stand on the name changing existing
packageconfog can be a change for someone who might be using it already but
that’s fine we have warnings in place to address these

>
>
>
> > On Tue, May 31, 2022 at 11:36 AM Peter Bergin <peter@berginkonsult.se>
> wrote:
> > > Hi,
> > >
> > > thanks Marcel for bumping this patch again!
> > >
> > > On 2022-05-31 18:38, Khem Raj wrote:
> > > > On Tue, May 31, 2022 at 8:57 AM Marcel Ziswiler <marcel@ziswiler.com>
> wrote:
> > > > > From: Peter Bergin <peter@berginkonsult.se>
> > > > >
> > > > > In order to enable configuration option aaf (AVTP Audio Format)
> > > > > used for AVB the library libavtp is a dependency but no recipe for
> > > > > this library was present. aaf support for alsa-plugins was
> > > > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff.
> > > > >
> > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se>
> > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > > >
> > > > > ---
> > > > > Resurrect from mailing list [1] as this is still not upstream.
> > > > > End-to-end tested on Verdin iMX8M Plus.
> > > > > Will talk about it at the Embedded World in the TSN & Linux track
> next
> > > > > month [2].
> > > > >
> > > > > [1]
> https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/
> > > > > [2]
> https://events.weka-fachmedien.de/embedded-world-conference/program/
> > > > >
> > > > > Changes in v2:
> > > > > - Updated SRC_URI specifying mandatory protocol as https.
> > > > > - Updated SRCREV to latest.
> > > > >
> > > > >    meta/recipes-multimedia/libavtp/libavtp_git.bb | 16
> ++++++++++++++++
> > > > There was a 0.2.0 release
> https://github.com/Avnu/libavtp/releases/tag/v0.2.0
> > > > so I wonder if we should use the release tagged SRC_URI and call the
> PV = 0.2.0
> > > This tag was set after I sent my initial patch. I think this is a good
> > > thing to do.
> > > >
> > > > >    1 file changed, 16 insertions(+)
> > > > >    create mode 100644 meta/recipes-multimedia/libavtp/
> libavtp_git.bb
> > > > >
> > > > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_git.bb
> b/meta/recipes-
> > > > > multimedia/libavtp/libavtp_git.bb
> > > > > new file mode 100644
> > > > > index 0000000000..aefbee56ea
> > > > > --- /dev/null
> > > > > +++ b/meta/recipes-multimedia/libavtp/libavtp_git.bb
> > > > > @@ -0,0 +1,16 @@
> > > > > +DESCRIPTION = "Open source implementation of Audio Video
> Transport Protocol (AVTP) \
> > > > > +               specified in IEEE 1722-2016 spec."
> > > > > +HOMEPAGE = "https://github.com/Avnu/libavtp"
> > > > > +LICENSE = "BSD-3-Clause"
> > > > > +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
> > > > > +
> > > > > +PROVIDES = "avtp"
> > > > why is this provides needed ?
> > >
> > > It is because recipe meta/recipes-multimedia/alsa/
> alsa-plugins_1.2.6.bb
> > > has this PACKAGECONFIG:
> > >
> > >    PACKAGECONFIG[aaf] = "--enable-aaf,--disable-aaf,avtp"
> > >
> > > So either this PROVIDES or also change PACKAGECONFIG for alsa-plugins?
> > >
> > > /Peter
> > >
> > > > > +
> > > > > +SRC_URI = "git://
> github.com/Avnu/libavtp.git;branch=master;protocol=https"
> > > > > +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
> > > > > +
> > > > > +S = "${WORKDIR}/git"
> > > > > +
> > > > > +inherit meson pkgconfig
> > > > > +
> > > > > +EXTRA_OEMESON = "-Dtests=disabled"
> > > > > --
> > > > > 2.36.1
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > -=-=-=-=-=-=-=-=-=-=-=-
> > > > > Links: You receive all messages sent to this group.
> > > > > View/Reply Online (#166324):
> https://lists.openembedded.org/g/openembedded-core/message/166324
> > > > > Mute This Topic:
> https://lists.openembedded.org/mt/91454504/3617552
> > > > > Group Owner: openembedded-core+owner@lists.openembedded.org
> > > > > Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> peter@berginkonsult.se]
> > > > > -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-multimedia/libavtp/libavtp_git.bb b/meta/recipes-multimedia/libavtp/libavtp_git.bb
new file mode 100644
index 0000000000..aefbee56ea
--- /dev/null
+++ b/meta/recipes-multimedia/libavtp/libavtp_git.bb
@@ -0,0 +1,16 @@ 
+DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \
+               specified in IEEE 1722-2016 spec."
+HOMEPAGE = "https://github.com/Avnu/libavtp"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e"
+
+PROVIDES = "avtp"
+
+SRC_URI = "git://github.com/Avnu/libavtp.git;branch=master;protocol=https"
+SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866"
+
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig
+
+EXTRA_OEMESON = "-Dtests=disabled"