Message ID | 20220420151725.468761-1-andrei@gherzan.com |
---|---|
State | Accepted, archived |
Commit | f099e0467599b18f162bc101d2de2fcc3a75b2ec |
Headers | show |
Series | [1/1] automake: Drop redundant 'u' flag in ARFLAGS | expand |
On Wed, Apr 20, 2022 at 8:17 AM Andrei Gherzan <andrei@gherzan.com> wrote: > > From: Andrei Gherzan <andrei.gherzan@huawei.com> > > Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com> > --- > .../automake/0001-Drop-ar-u-argument.patch | 32 +++++++++++++++++++ > .../automake/automake_1.16.5.bb | 1 + > 2 files changed, 33 insertions(+) > create mode 100644 meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch > > diff --git a/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch b/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch > new file mode 100644 > index 0000000000..260c51f517 > --- /dev/null > +++ b/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch > @@ -0,0 +1,32 @@ > +From bed646918bc67e9e2151ccbda03aae34717821fe Mon Sep 17 00:00:00 2001 > +From: Andrei Gherzan <andrei.gherzan@huawei.com> > +Date: Wed, 20 Apr 2022 14:57:14 +0200 > +Subject: [PATCH] Drop ar 'u' argument > + > +binutils/ar is configured in deterministic mode by default making the > +'u' argument irrelevant while leading to warning massages similar to: > + > +| ar: `u' modifier ignored since `D' is the default (see `U') > + this is perhaps due to the way we build binutils and I am fine with removing -u here but I think the patch is OE specific. While you are here can you add -D explicitly, because we do have option to use llvm ar and it would help those distributions to create reproducible archives too. > +Upstream-Status: Pending > +Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com> > +--- > + bin/automake.in | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/bin/automake.in b/bin/automake.in > +index 92bcebe..0f2b84b 100644 > +--- a/bin/automake.in > ++++ b/bin/automake.in > +@@ -2678,7 +2678,7 @@ sub handle_libraries () > + } > + > + define_variable ('AR', 'ar', INTERNAL); > +- define_variable ('ARFLAGS', 'cru', INTERNAL); > ++ define_variable ('ARFLAGS', 'cr', INTERNAL); > + define_verbose_tagvar ('AR'); > + > + foreach my $pair (@liblist) > +-- > +2.25.1 > + > diff --git a/meta/recipes-devtools/automake/automake_1.16.5.bb b/meta/recipes-devtools/automake/automake_1.16.5.bb > index ba5ce7b9bb..469fcd69f7 100644 > --- a/meta/recipes-devtools/automake/automake_1.16.5.bb > +++ b/meta/recipes-devtools/automake/automake_1.16.5.bb > @@ -25,6 +25,7 @@ SRC_URI += "\ > file://new_rt_path_for_test-driver.patch \ > file://0001-automake-Add-default-libtool_tag-to-cppasm.patch \ > file://0001-build-fix-race-in-parallel-builds.patch \ > + file://0001-Drop-ar-u-argument.patch \ > " > > SRC_URI[sha256sum] = "07bd24ad08a64bc17250ce09ec56e921d6343903943e99ccf63bbf0705e34605" > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#164702): https://lists.openembedded.org/g/openembedded-core/message/164702 > Mute This Topic: https://lists.openembedded.org/mt/90586101/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Wed, 20 Apr 2022, at 16:36, Khem Raj wrote: > On Wed, Apr 20, 2022 at 8:17 AM Andrei Gherzan <andrei@gherzan.com> wrote: >> >> From: Andrei Gherzan <andrei.gherzan@huawei.com> >> >> Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com> >> --- >> .../automake/0001-Drop-ar-u-argument.patch | 32 +++++++++++++++++++ >> .../automake/automake_1.16.5.bb | 1 + >> 2 files changed, 33 insertions(+) >> create mode 100644 meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch >> >> diff --git a/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch b/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch >> new file mode 100644 >> index 0000000000..260c51f517 >> --- /dev/null >> +++ b/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch >> @@ -0,0 +1,32 @@ >> +From bed646918bc67e9e2151ccbda03aae34717821fe Mon Sep 17 00:00:00 2001 >> +From: Andrei Gherzan <andrei.gherzan@huawei.com> >> +Date: Wed, 20 Apr 2022 14:57:14 +0200 >> +Subject: [PATCH] Drop ar 'u' argument >> + >> +binutils/ar is configured in deterministic mode by default making the >> +'u' argument irrelevant while leading to warning massages similar to: >> + >> +| ar: `u' modifier ignored since `D' is the default (see `U') >> + > > this is perhaps due to the way we build binutils and I am fine with > removing -u here but > I think the patch is OE specific. While you are here can you add -D > explicitly, because we > do have option to use llvm ar and it would help those distributions to > create reproducible archives too. Agreed. I'll send v2. Andrei
diff --git a/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch b/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch new file mode 100644 index 0000000000..260c51f517 --- /dev/null +++ b/meta/recipes-devtools/automake/automake/0001-Drop-ar-u-argument.patch @@ -0,0 +1,32 @@ +From bed646918bc67e9e2151ccbda03aae34717821fe Mon Sep 17 00:00:00 2001 +From: Andrei Gherzan <andrei.gherzan@huawei.com> +Date: Wed, 20 Apr 2022 14:57:14 +0200 +Subject: [PATCH] Drop ar 'u' argument + +binutils/ar is configured in deterministic mode by default making the +'u' argument irrelevant while leading to warning massages similar to: + +| ar: `u' modifier ignored since `D' is the default (see `U') + +Upstream-Status: Pending +Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com> +--- + bin/automake.in | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/bin/automake.in b/bin/automake.in +index 92bcebe..0f2b84b 100644 +--- a/bin/automake.in ++++ b/bin/automake.in +@@ -2678,7 +2678,7 @@ sub handle_libraries () + } + + define_variable ('AR', 'ar', INTERNAL); +- define_variable ('ARFLAGS', 'cru', INTERNAL); ++ define_variable ('ARFLAGS', 'cr', INTERNAL); + define_verbose_tagvar ('AR'); + + foreach my $pair (@liblist) +-- +2.25.1 + diff --git a/meta/recipes-devtools/automake/automake_1.16.5.bb b/meta/recipes-devtools/automake/automake_1.16.5.bb index ba5ce7b9bb..469fcd69f7 100644 --- a/meta/recipes-devtools/automake/automake_1.16.5.bb +++ b/meta/recipes-devtools/automake/automake_1.16.5.bb @@ -25,6 +25,7 @@ SRC_URI += "\ file://new_rt_path_for_test-driver.patch \ file://0001-automake-Add-default-libtool_tag-to-cppasm.patch \ file://0001-build-fix-race-in-parallel-builds.patch \ + file://0001-Drop-ar-u-argument.patch \ " SRC_URI[sha256sum] = "07bd24ad08a64bc17250ce09ec56e921d6343903943e99ccf63bbf0705e34605"