[meta-oe] kernel: Delete unused KERNEL_LOCALVERSION variable

Message ID 20220412130818.26000-1-alexk@zuma.ai
State New
Headers show
Series [meta-oe] kernel: Delete unused KERNEL_LOCALVERSION variable | expand

Commit Message

Alex Kiernan April 12, 2022, 1:08 p.m. UTC
This has been unused since:

  commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
  Author: Richard Purdie <richard@openedhand.com>
  Date:   Mon Jan 8 21:05:18 2007 +0000

      kernel.bbclass: Drop KERNEL_RELEASE variable

      git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123 311d38ba-8fff-0310-9ca6-ca027cbcb966

Signed-off-by: Alex Kiernan <alexk@zuma.ai>
---
 meta/classes/kernel.bbclass | 2 --
 1 file changed, 2 deletions(-)

Comments

Luca Ceresoli April 13, 2022, 9:29 a.m. UTC | #1
Hello Alex,

Il giorno Tue, 12 Apr 2022 14:08:18 +0100
"Alex Kiernan" <alex.kiernan@gmail.com> ha scritto:

> This has been unused since:
> 
>   commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
>   Author: Richard Purdie <richard@openedhand.com>
>   Date:   Mon Jan 8 21:05:18 2007 +0000
> 
>       kernel.bbclass: Drop KERNEL_RELEASE variable
> 
>       git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123
> 311d38ba-8fff-0310-9ca6-ca027cbcb966
> 
> Signed-off-by: Alex Kiernan <alexk@zuma.ai>

This patch has [meta-oe] in the subject line but it is indeed for
oe-core. No need to resend it, I've taken it for autobuilders testing
already, however this is something you should possibly fix in future
patches.

The same applies to the 8-patch series you sent a few minutes earlier.

Best regards
Alex Kiernan April 13, 2022, 1:28 p.m. UTC | #2
On Wed, Apr 13, 2022 at 10:29 AM Luca Ceresoli
<luca.ceresoli@bootlin.com> wrote:
>
> Hello Alex,
>
> Il giorno Tue, 12 Apr 2022 14:08:18 +0100
> "Alex Kiernan" <alex.kiernan@gmail.com> ha scritto:
>
> > This has been unused since:
> >
> >   commit fb61dc1430f81ae2ee59766ffab8404fd79ff1b1
> >   Author: Richard Purdie <richard@openedhand.com>
> >   Date:   Mon Jan 8 21:05:18 2007 +0000
> >
> >       kernel.bbclass: Drop KERNEL_RELEASE variable
> >
> >       git-svn-id: https://svn.o-hand.com/repos/poky/trunk@1123
> > 311d38ba-8fff-0310-9ca6-ca027cbcb966
> >
> > Signed-off-by: Alex Kiernan <alexk@zuma.ai>
>
> This patch has [meta-oe] in the subject line but it is indeed for
> oe-core. No need to resend it, I've taken it for autobuilders testing
> already, however this is something you should possibly fix in future
> patches.
>
> The same applies to the 8-patch series you sent a few minutes earlier.
>

Thank you!

Patch

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 7ca847f0a341..cd900edd5cb6 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -221,8 +221,6 @@  export CMDLINE_CONSOLE = "console=${@d.getVar("KERNEL_CONSOLE") or "ttyS0"}"
 
 KERNEL_VERSION = "${@get_kernelversion_headers('${B}')}"
 
-KERNEL_LOCALVERSION ?= ""
-
 # kernels are generally machine specific
 PACKAGE_ARCH = "${MACHINE_ARCH}"