| Message ID | 20220312073022.2894-3-f_l_k@t-online.de |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe,PATCHv3,1/3] mesa: update to 22.0.0 | expand |
On Sat, 2022-03-12 at 08:30 +0100, Markus Volk wrote: > this fixes a build error about missing vapigen and enables vapi build > > Signed-off-by: Markus Volk <f_l_k@t-online.de> > --- > meta/recipes-gnome/librsvg/librsvg_2.52.5.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb > index 1279c663f7..ede6454c2b 100644 > --- a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb > +++ b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb > @@ -14,7 +14,7 @@ SECTION = "x11/utils" > DEPENDS = "cairo gdk-pixbuf glib-2.0 libcroco libxml2 pango" > BBCLASSEXTEND = "native" > > -inherit gnomebase gtk-doc pixbufcache upstream-version-is-even gobject-introspection rust > +inherit gnomebase gtk-doc pixbufcache upstream-version-is-even gobject-introspection rust vala > > SRC_URI += "file://0001-Makefile.am-pass-rust-target-to-cargo-also-when-not-.patch \ > file://0001-system-deps-src-lib.rs-do-not-probe-into-harcoded-li.patch \ I'm curious whether we've just been missing some functionality in librsvg or whether the recent changes exposed some new error? Put another way, how did you see this when the autobuilder does not? Cheers, Richard
Am 12.03.22 um 14:32 schrieb Richard Purdie: > On Sat, 2022-03-12 at 08:30 +0100, Markus Volk wrote: >> this fixes a build error about missing vapigen and enables vapi build >> >> Signed-off-by: Markus Volk <f_l_k@t-online.de> >> --- >> meta/recipes-gnome/librsvg/librsvg_2.52.5.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb >> index 1279c663f7..ede6454c2b 100644 >> --- a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb >> +++ b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb >> @@ -14,7 +14,7 @@ SECTION = "x11/utils" >> DEPENDS = "cairo gdk-pixbuf glib-2.0 libcroco libxml2 pango" >> BBCLASSEXTEND = "native" >> >> -inherit gnomebase gtk-doc pixbufcache upstream-version-is-even gobject-introspection rust >> +inherit gnomebase gtk-doc pixbufcache upstream-version-is-even gobject-introspection rust vala >> >> SRC_URI += "file://0001-Makefile.am-pass-rust-target-to-cargo-also-when-not-.patch \ >> file://0001-system-deps-src-lib.rs-do-not-probe-into-harcoded-li.patch \ > > I'm curious whether we've just been missing some functionality in librsvg or > whether the recent changes exposed some new error? > > Put another way, how did you see this when the autobuilder does not? > > Cheers, > > Richard In any case, this adds functionality. For example, a real life issue for the lack of vapi in librsvg is that you can't build gnome-chess because it has a dependency on it. The second question is a good one. Normally vala bindings should be optional in librsvg autotools buidsystem. https://github.com/GNOME/librsvg/blob/c5d0eb679ee45377417bbf9ce2dabde0eb72802d/configure.ac#L293 I noticed similar behavior with some xfce recipes when I did an oe-core update a little over two weeks ago. I suddenly had build aborts due to missing vapigen, even though --enable-vala was not explicitly specified. https://git.openembedded.org/meta-openembedded/diff/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb?h=master-next&id=26d9d0b627177f6f710c5d7b902d73b84ac14804 All recipes that were affected by this already had 'inherit gobject-introspection' added. vapi build is basically just gobject-introspection too, so this seems related somehow. But why has this only been the case for two weeks? And why not with autobuilder? I really don't know. I'll see if I can reproduce the vapi error in librsvg.
Am 12.03.22 um 16:25 schrieb Markus Volk: > > Am 12.03.22 um 14:32 schrieb Richard Purdie: >> On Sat, 2022-03-12 at 08:30 +0100, Markus Volk wrote: >>> this fixes a build error about missing vapigen and enables vapi build >>> >>> Signed-off-by: Markus Volk <f_l_k@t-online.de> >>> --- >>> meta/recipes-gnome/librsvg/librsvg_2.52.5.bb | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb >>> b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb >>> index 1279c663f7..ede6454c2b 100644 >>> --- a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb >>> +++ b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb >>> @@ -14,7 +14,7 @@ SECTION = "x11/utils" >>> DEPENDS = "cairo gdk-pixbuf glib-2.0 libcroco libxml2 pango" >>> BBCLASSEXTEND = "native" >>> -inherit gnomebase gtk-doc pixbufcache upstream-version-is-even >>> gobject-introspection rust >>> +inherit gnomebase gtk-doc pixbufcache upstream-version-is-even >>> gobject-introspection rust vala >>> SRC_URI += >>> "file://0001-Makefile.am-pass-rust-target-to-cargo-also-when-not-.patch >>> \ >>> file://0001-system-deps-src-lib.rs-do-not-probe-into-harcoded-li.patch >>> \ >> >> I'm curious whether we've just been missing some functionality in >> librsvg or >> whether the recent changes exposed some new error? >> >> Put another way, how did you see this when the autobuilder does not? >> >> Cheers, >> >> Richard > In any case, this adds functionality. For example, a real life issue > for the lack of vapi in librsvg is that you can't build gnome-chess > because it has a dependency on it. > > The second question is a good one. Normally vala bindings should be > optional in librsvg autotools buidsystem. > > https://github.com/GNOME/librsvg/blob/c5d0eb679ee45377417bbf9ce2dabde0eb72802d/configure.ac#L293 > > > I noticed similar behavior with some xfce recipes when I did an > oe-core update a little over two weeks ago. I suddenly had build > aborts due to missing vapigen, even though --enable-vala was not > explicitly specified. > > https://git.openembedded.org/meta-openembedded/diff/meta-xfce/recipes-xfce/libxfce4util/libxfce4util_4.16.0.bb?h=master-next&id=26d9d0b627177f6f710c5d7b902d73b84ac14804 > > > All recipes that were affected by this already had 'inherit > gobject-introspection' added. vapi build is basically just > gobject-introspection too, so this seems related somehow. > But why has this only been the case for two weeks? And why not with > autobuilder? I really don't know. > I'll see if I can reproduce the vapi error in librsvg. > It looks like i'm not able to reproduce the issue. It only happened on the first clean build. Now, that i have sstate cache available it's working as expected. Adding or removing vala from inherit just enables or disables generation of the vapi files.
diff --git a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb index 1279c663f7..ede6454c2b 100644 --- a/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb +++ b/meta/recipes-gnome/librsvg/librsvg_2.52.5.bb @@ -14,7 +14,7 @@ SECTION = "x11/utils" DEPENDS = "cairo gdk-pixbuf glib-2.0 libcroco libxml2 pango" BBCLASSEXTEND = "native" -inherit gnomebase gtk-doc pixbufcache upstream-version-is-even gobject-introspection rust +inherit gnomebase gtk-doc pixbufcache upstream-version-is-even gobject-introspection rust vala SRC_URI += "file://0001-Makefile.am-pass-rust-target-to-cargo-also-when-not-.patch \ file://0001-system-deps-src-lib.rs-do-not-probe-into-harcoded-li.patch \
this fixes a build error about missing vapigen and enables vapi build Signed-off-by: Markus Volk <f_l_k@t-online.de> --- meta/recipes-gnome/librsvg/librsvg_2.52.5.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)