package: do_package should depend on binutils

Message ID 20220301152535.1958806-1-ross.burton@arm.com
State New
Headers show
Series package: do_package should depend on binutils | expand

Commit Message

Ross Burton March 1, 2022, 3:25 p.m. UTC
splitdebuginfo() in do_package uses objcopy, but there is no dependency.
It usually gets pulled in via the toolchain but if
INHIBIT_DEFAULT_DEPS="1" there is no dependency on a toolchain, so make
it explicit.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/classes/package.bbclass | 2 ++
 1 file changed, 2 insertions(+)

Comments

Lee, Chee Yang March 2, 2022, 10 a.m. UTC | #1
Looks like this is causing problem with multilib 
https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/4844
https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/4844/steps/11/logs/errors


> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Ross Burton
> Sent: Tuesday, 1 March, 2022 11:26 PM
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] package: do_package should depend on binutils
> 
> splitdebuginfo() in do_package uses objcopy, but there is no dependency.
> It usually gets pulled in via the toolchain but if INHIBIT_DEFAULT_DEPS="1"
> there is no dependency on a toolchain, so make it explicit.
> 
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/classes/package.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index f822258150..4b72bf2039 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -53,6 +53,8 @@ ALL_MULTILIB_PACKAGE_ARCHS =
> "${@all_multilib_tune_values(d, 'PACKAGE_ARCHS')}"
>  # rpm is used for the per-file dependency identification  # dwarfsrcfiles is
> used to determine the list of debug source files  PACKAGE_DEPENDS +=
> "rpm-native dwarfsrcfiles-native"
> +PACKAGE_DEPENDS:append:class-target = "
> virtual/${TARGET_PREFIX}binutils"
> +PACKAGE_DEPENDS:append:class-nativesdk = "
> virtual/${SDK_PREFIX}binutils-crosssdk"
> 
> 
>  # If your postinstall can execute at rootfs creation time rather than on
> --
> 2.25.1

Patch

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index f822258150..4b72bf2039 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -53,6 +53,8 @@  ALL_MULTILIB_PACKAGE_ARCHS = "${@all_multilib_tune_values(d, 'PACKAGE_ARCHS')}"
 # rpm is used for the per-file dependency identification
 # dwarfsrcfiles is used to determine the list of debug source files
 PACKAGE_DEPENDS += "rpm-native dwarfsrcfiles-native"
+PACKAGE_DEPENDS:append:class-target = " virtual/${TARGET_PREFIX}binutils"
+PACKAGE_DEPENDS:append:class-nativesdk = " virtual/${SDK_PREFIX}binutils-crosssdk"
 
 
 # If your postinstall can execute at rootfs creation time rather than on