diff mbox series

yocto-check-layer: Address Bug#11131

Message ID 20211130054335.58255-1-goledhruva@gmail.com
State New
Headers show
Series yocto-check-layer: Address Bug#11131 | expand

Commit Message

Dhruva Gole Nov. 30, 2021, 5:43 a.m. UTC 
This adds:
- Test case to review if the README file specifies the maintainer.
- Test case to review if the README file specifies the word patch.
- Test case to review if the README file contains an email address.

Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
---
 scripts/lib/checklayer/cases/common.py | 6 ++++++
 1 file changed, 6 insertions(+)
diff mbox series

Patch

diff --git a/scripts/lib/checklayer/cases/common.py b/scripts/lib/checklayer/cases/common.py
index b82304e361..8d4aab7973 100644
--- a/scripts/lib/checklayer/cases/common.py
+++ b/scripts/lib/checklayer/cases/common.py
@@ -6,6 +6,7 @@ 
 import glob
 import os
 import unittest
+import re
 from checklayer import get_signatures, LayerType, check_command, get_depgraph, compare_signatures
 from checklayer.case import OECheckLayerTestCase
 
@@ -25,6 +26,11 @@  class CommonCheckLayer(OECheckLayerTestCase):
             data = f.read()
         self.assertTrue(data,
                 msg="Layer contains a README file but it is empty.")
+        self.assertIn('maintainer',data)
+        self.assertIn('patch',data)
+        # Check that there is an email address in the README
+        email_regex = re.compile(r"[^@]+@[^@]+")
+        self.assertTrue(email_regex.match(data))
 
     def test_parse(self):
         check_command('Layer %s failed to parse.' % self.tc.layer['name'],