[6/8] kbd: add nativesdk

Message ID 20211117123201.111905-7-luca.boccassi@gmail.com
State New
Headers show
Series systemd: allow building for nativesdk | expand

Commit Message

Luca Boccassi Nov. 17, 2021, 12:31 p.m. UTC
From: Luca Boccassi <luca.boccassi@microsoft.com>

Required to build systemd tools

Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
 meta/recipes-core/kbd/kbd_2.4.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Nov. 17, 2021, 5:43 p.m. UTC | #1
On Wed, 2021-11-17 at 12:31 +0000, Luca Bocassi wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
> 
> Required to build systemd tools

If systemd needs these to build, wouldn't it be depending on kbd-native?

Or are you saying that systemd-tools needs something in here at runtime?

I don't mind extending the recipe if we really need it but that isn't what the
commit message says so at the very least that needs to be clearer.

Cheers,

Richard
Luca Boccassi Nov. 17, 2021, 5:58 p.m. UTC | #2
On Wed, 2021-11-17 at 17:43 +0000, Richard Purdie wrote:
> On Wed, 2021-11-17 at 12:31 +0000, Luca Bocassi wrote:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > 
> > Required to build systemd tools
> 
> If systemd needs these to build, wouldn't it be depending on kbd-native?
> 
> Or are you saying that systemd-tools needs something in here at runtime?
> 
> I don't mind extending the recipe if we really need it but that isn't what the
> commit message says so at the very least that needs to be clearer.
> 
> Cheers,
> 
> Richard
> 

It's probably indirect, I guess (dependency of a dependency)? This
series was the bare minimum required to get the recipe to build. The
build failed with "nothing provides nativesdk-foobar" without these.

Patch

diff --git a/meta/recipes-core/kbd/kbd_2.4.0.bb b/meta/recipes-core/kbd/kbd_2.4.0.bb
index 7cb45eff77..7efc7af312 100644
--- a/meta/recipes-core/kbd/kbd_2.4.0.bb
+++ b/meta/recipes-core/kbd/kbd_2.4.0.bb
@@ -43,4 +43,4 @@  ALTERNATIVE:${PN} = "chvt deallocvt fgconsole openvt showkey \
                      ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'vlock','', d)}"
 ALTERNATIVE_PRIORITY = "100"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"