| Message ID | 20211117123201.111905-6-luca.boccassi@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | systemd: allow building for nativesdk | expand |
On Wed, 2021-11-17 at 12:31 +0000, Luca Bocassi wrote: > From: Luca Boccassi <luca.boccassi@microsoft.com> > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com> > --- > meta/recipes-core/volatile-binds/volatile-binds.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb > index 66e28f4fc9..0f27353031 100644 > --- a/meta/recipes-core/volatile-binds/volatile-binds.bb > +++ b/meta/recipes-core/volatile-binds/volatile-binds.bb > @@ -84,3 +84,5 @@ do_install[dirs] = "${WORKDIR}" > do_install_append_class-nativesdk () { > rm -rf ${D}/var > } > + > +BBCLASSEXTEND = "nativesdk" Is there any useful component left in volatile-binds in the SDK case? I don't think we should be extending this as the recipe makes no sense. Rather nativesdk variants probably shouldn't be depending upon it? Cheers, Richard
On Wed, 2021-11-17 at 17:40 +0000, Richard Purdie wrote: > On Wed, 2021-11-17 at 12:31 +0000, Luca Bocassi wrote: > > From: Luca Boccassi <luca.boccassi@microsoft.com> > > > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com> > > --- > > meta/recipes-core/volatile-binds/volatile-binds.bb | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb > > index 66e28f4fc9..0f27353031 100644 > > --- a/meta/recipes-core/volatile-binds/volatile-binds.bb > > +++ b/meta/recipes-core/volatile-binds/volatile-binds.bb > > @@ -84,3 +84,5 @@ do_install[dirs] = "${WORKDIR}" > > do_install_append_class-nativesdk () { > > rm -rf ${D}/var > > } > > + > > +BBCLASSEXTEND = "nativesdk" > > Is there any useful component left in volatile-binds in the SDK case? I don't > think we should be extending this as the recipe makes no sense. Rather nativesdk > variants probably shouldn't be depending upon it? It's pulled in automatically. I don't know enough about yocto to be able to tell whether it's intentional and needed or not.
On Wed, 2021-11-17 at 17:42 +0000, Luca Boccassi wrote: > On Wed, 2021-11-17 at 17:40 +0000, Richard Purdie wrote: > > On Wed, 2021-11-17 at 12:31 +0000, Luca Bocassi wrote: > > > From: Luca Boccassi <luca.boccassi@microsoft.com> > > > > > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com> > > > --- > > > meta/recipes-core/volatile-binds/volatile-binds.bb | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb > > > index 66e28f4fc9..0f27353031 100644 > > > --- a/meta/recipes-core/volatile-binds/volatile-binds.bb > > > +++ b/meta/recipes-core/volatile-binds/volatile-binds.bb > > > @@ -84,3 +84,5 @@ do_install[dirs] = "${WORKDIR}" > > > do_install_append_class-nativesdk () { > > > rm -rf ${D}/var > > > } > > > + > > > +BBCLASSEXTEND = "nativesdk" > > > > Is there any useful component left in volatile-binds in the SDK case? I don't > > think we should be extending this as the recipe makes no sense. Rather nativesdk > > variants probably shouldn't be depending upon it? > > It's pulled in automatically. I don't know enough about yocto to be > able to tell whether it's intentional and needed or not. Looks like it's working without, so changed in v2 to remove the dependency for nativesdk instead.
diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb index 66e28f4fc9..0f27353031 100644 --- a/meta/recipes-core/volatile-binds/volatile-binds.bb +++ b/meta/recipes-core/volatile-binds/volatile-binds.bb @@ -84,3 +84,5 @@ do_install[dirs] = "${WORKDIR}" do_install_append_class-nativesdk () { rm -rf ${D}/var } + +BBCLASSEXTEND = "nativesdk"