Message ID | 20211116014413.419573-1-jim.wilson.gcc@gmail.com |
---|---|
State | Accepted, archived |
Commit | 56623848f45cf475f909beb75209323a89837169 |
Headers | show |
Series | gdb-common: Add --with-liblzma-prefix in xz PACKAGECONFIG. | expand |
On 11/15/21 17:44, Jim Wilson wrote: > This fixes an arch linux gdb configure error with liblzma installed. > > Without the --with-liblzma-prefix option, when configuring the target > gdb, gdb configure may find the native liblzma (on a non-multiarch > system) and try to use it, which gives a configure error. We already > use --with-libexpat-prefix for expat, we just need to do the same for > liblzma. > > This was reported here: > https://github.com/sifive/meta-sifive/issues/34 > https://github.com/sifive/freedom-u-sdk/issues/148 > > Signed-off-by: Jim Wilson <jim.wilson.gcc@gmail.com> > --- > meta/recipes-devtools/gdb/gdb-common.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc > index f3ab3544da..925b0c2f80 100644 > --- a/meta/recipes-devtools/gdb/gdb-common.inc > +++ b/meta/recipes-devtools/gdb/gdb-common.inc > @@ -37,7 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python > PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" > # ncurses is already a hard DEPENDS, but would be added here if it weren't > PACKAGECONFIG[tui] = "--enable-tui,--disable-tui" > -PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz" > +PACKAGECONFIG[xz] = "--with-lzma --with-liblzma-prefix=${STAGING_DIR_HOST},--without-lzma,xz" this looks ok to me. Although I wonder why gdb's configure is not able to find it in staging sysroot automatically, I have seen similar behavior in gmp and mpfr in past as well. > PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils" > > GDBPROPREFIX = "--program-prefix=''" > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#158320): https://lists.openembedded.org/g/openembedded-core/message/158320 > Mute This Topic: https://lists.openembedded.org/mt/87085648/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Mon, Nov 15, 2021 at 6:14 PM Khem Raj <raj.khem@gmail.com> wrote: > On 11/15/21 17:44, Jim Wilson wrote: > > This fixes an arch linux gdb configure error with liblzma installed. > > this looks ok to me. Although I wonder why gdb's configure is not able > to find it in staging sysroot automatically, I have seen similar > behavior in gmp and mpfr in past as well. > I have no familiarity with the OE cross native build system. I didn't spend much time looking at that. There might be something wrong with gdb configure, or there might be something wrong with options or environment variables passed to gdb configure. But since we already passed the --with-expat-prefix option to configure, doing the same for liblzma was the easiest way to get this working. Jim
On Tue, Nov 16, 2021 at 9:55 AM Jim Wilson <jim.wilson.gcc@gmail.com> wrote: > > On Mon, Nov 15, 2021 at 6:14 PM Khem Raj <raj.khem@gmail.com> wrote: >> >> On 11/15/21 17:44, Jim Wilson wrote: >> > This fixes an arch linux gdb configure error with liblzma installed. >> >> this looks ok to me. Although I wonder why gdb's configure is not able >> to find it in staging sysroot automatically, I have seen similar >> behavior in gmp and mpfr in past as well. > > > I have no familiarity with the OE cross native build system. I didn't spend much time looking at that. There might be something wrong with gdb configure, or there might be something wrong with options or environment variables passed to gdb configure. But since we already passed the --with-expat-prefix option to configure, doing the same for liblzma was the easiest way to get this working. > yes, this patch is fine in itself. > Jim >
On Tue, Nov 16, 2021 at 9:59 AM Khem Raj <raj.khem@gmail.com> wrote: > yes, this patch is fine in itself. > Thanks. I see that the patch got applied last week. Jim
diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc index f3ab3544da..925b0c2f80 100644 --- a/meta/recipes-devtools/gdb/gdb-common.inc +++ b/meta/recipes-devtools/gdb/gdb-common.inc @@ -37,7 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" # ncurses is already a hard DEPENDS, but would be added here if it weren't PACKAGECONFIG[tui] = "--enable-tui,--disable-tui" -PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz" +PACKAGECONFIG[xz] = "--with-lzma --with-liblzma-prefix=${STAGING_DIR_HOST},--without-lzma,xz" PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils" GDBPROPREFIX = "--program-prefix=''"
This fixes an arch linux gdb configure error with liblzma installed. Without the --with-liblzma-prefix option, when configuring the target gdb, gdb configure may find the native liblzma (on a non-multiarch system) and try to use it, which gives a configure error. We already use --with-libexpat-prefix for expat, we just need to do the same for liblzma. This was reported here: https://github.com/sifive/meta-sifive/issues/34 https://github.com/sifive/freedom-u-sdk/issues/148 Signed-off-by: Jim Wilson <jim.wilson.gcc@gmail.com> --- meta/recipes-devtools/gdb/gdb-common.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)