diff mbox series

[v2] systemd-boot: upgrade 256.8 -> 256.9

Message ID 1733964540-5537-2-git-send-email-wangmy@fujitsu.com
State New
Headers show
Series [v2] systemd-boot: upgrade 256.8 -> 256.9 | expand

Commit Message

Mingyu Wang (Fujitsu) Dec. 12, 2024, 12:49 a.m. UTC
From: Wang Mingyu <wangmy@cn.fujitsu.com>

Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
---
 ...ystemd-boot-native_256.8.bb => systemd-boot-native_256.9.bb} | 0
 .../systemd/{systemd-boot_256.8.bb => systemd-boot_256.9.bb}    | 0
 meta/recipes-core/systemd/systemd.inc                           | 2 +-
 .../recipes-core/systemd/{systemd_256.8.bb => systemd_256.9.bb} | 0
 4 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-core/systemd/{systemd-boot-native_256.8.bb => systemd-boot-native_256.9.bb} (100%)
 rename meta/recipes-core/systemd/{systemd-boot_256.8.bb => systemd-boot_256.9.bb} (100%)
 rename meta/recipes-core/systemd/{systemd_256.8.bb => systemd_256.9.bb} (100%)

Comments

Mikko Rapeli Dec. 12, 2024, 7:42 a.m. UTC | #1
Hi,

On Thu, Dec 12, 2024 at 08:49:00AM +0800, wangmy via lists.openembedded.org wrote:
> From: Wang Mingyu <wangmy@cn.fujitsu.com>
> 
> Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
> ---
>  ...ystemd-boot-native_256.8.bb => systemd-boot-native_256.9.bb} | 0
>  .../systemd/{systemd-boot_256.8.bb => systemd-boot_256.9.bb}    | 0
>  meta/recipes-core/systemd/systemd.inc                           | 2 +-
>  .../recipes-core/systemd/{systemd_256.8.bb => systemd_256.9.bb} | 0
>  4 files changed, 1 insertion(+), 1 deletion(-)
>  rename meta/recipes-core/systemd/{systemd-boot-native_256.8.bb => systemd-boot-native_256.9.bb} (100%)
>  rename meta/recipes-core/systemd/{systemd-boot_256.8.bb => systemd-boot_256.9.bb} (100%)
>  rename meta/recipes-core/systemd/{systemd_256.8.bb => systemd_256.9.bb} (100%)
> 
> diff --git a/meta/recipes-core/systemd/systemd-boot-native_256.8.bb b/meta/recipes-core/systemd/systemd-boot-native_256.9.bb
> similarity index 100%
> rename from meta/recipes-core/systemd/systemd-boot-native_256.8.bb
> rename to meta/recipes-core/systemd/systemd-boot-native_256.9.bb
> diff --git a/meta/recipes-core/systemd/systemd-boot_256.8.bb b/meta/recipes-core/systemd/systemd-boot_256.9.bb
> similarity index 100%
> rename from meta/recipes-core/systemd/systemd-boot_256.8.bb
> rename to meta/recipes-core/systemd/systemd-boot_256.9.bb
> diff --git a/meta/recipes-core/systemd/systemd.inc b/meta/recipes-core/systemd/systemd.inc
> index 989ca667b7..b85d5b187d 100644
> --- a/meta/recipes-core/systemd/systemd.inc
> +++ b/meta/recipes-core/systemd/systemd.inc
> @@ -15,7 +15,7 @@ LICENSE:libsystemd = "LGPL-2.1-or-later"
>  LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
>                      file://LICENSE.LGPL2.1;md5=4fbd65380cdd255951079008b364516c"
>  
> -SRCREV = "a2240d1cf9f3515728186c2c98a6f4b64a40e4da"
> +SRCREV = "f15fd96efd5ebdfb18746acb0cbb35a4331b4d8b"
>  SRCBRANCH = "v256-stable"
>  SRC_URI = "git://github.com/systemd/systemd.git;protocol=https;branch=${SRCBRANCH}"

NACK: must also update systemd and systemd-boot-native recipe versions since
systemd, systemd-boot and systemd-boot-native all use systemd.inc.

If this update is automated, then that automation needs to be fixed to update all
affected recipes. This same issue has been in a lot of update patches.

Cheers,

-Mikko
Alexander Kanavin Dec. 12, 2024, 7:58 a.m. UTC | #2
On Thu, 12 Dec 2024 at 08:42, Mikko Rapeli via lists.openembedded.org
<mikko.rapeli=linaro.org@lists.openembedded.org> wrote:
> >  ...ystemd-boot-native_256.8.bb => systemd-boot-native_256.9.bb} | 0
> >  .../systemd/{systemd-boot_256.8.bb => systemd-boot_256.9.bb}    | 0
> >  meta/recipes-core/systemd/systemd.inc                           | 2 +-
> >  .../recipes-core/systemd/{systemd_256.8.bb => systemd_256.9.bb} | 0


> NACK: must also update systemd and systemd-boot-native recipe versions since
> systemd, systemd-boot and systemd-boot-native all use systemd.inc.

The patch actually does this. Is something still missing?

Alex
Mikko Rapeli Dec. 12, 2024, 8:30 a.m. UTC | #3
Hi,

On Thu, Dec 12, 2024 at 08:58:51AM +0100, Alexander Kanavin wrote:
> On Thu, 12 Dec 2024 at 08:42, Mikko Rapeli via lists.openembedded.org
> <mikko.rapeli=linaro.org@lists.openembedded.org> wrote:
> > >  ...ystemd-boot-native_256.8.bb => systemd-boot-native_256.9.bb} | 0
> > >  .../systemd/{systemd-boot_256.8.bb => systemd-boot_256.9.bb}    | 0
> > >  meta/recipes-core/systemd/systemd.inc                           | 2 +-
> > >  .../recipes-core/systemd/{systemd_256.8.bb => systemd_256.9.bb} | 0
> 
> 
> > NACK: must also update systemd and systemd-boot-native recipe versions since
> > systemd, systemd-boot and systemd-boot-native all use systemd.inc.
> 
> The patch actually does this. Is something still missing?

You're right and I was wrong, sorry. I guess v1 of the patch was in current
master-next which was missing systemd recipe update. Would be nice to
change patch title prefix from systemd-boot to systemd though.

Cheers,

-Mikko
diff mbox series

Patch

diff --git a/meta/recipes-core/systemd/systemd-boot-native_256.8.bb b/meta/recipes-core/systemd/systemd-boot-native_256.9.bb
similarity index 100%
rename from meta/recipes-core/systemd/systemd-boot-native_256.8.bb
rename to meta/recipes-core/systemd/systemd-boot-native_256.9.bb
diff --git a/meta/recipes-core/systemd/systemd-boot_256.8.bb b/meta/recipes-core/systemd/systemd-boot_256.9.bb
similarity index 100%
rename from meta/recipes-core/systemd/systemd-boot_256.8.bb
rename to meta/recipes-core/systemd/systemd-boot_256.9.bb
diff --git a/meta/recipes-core/systemd/systemd.inc b/meta/recipes-core/systemd/systemd.inc
index 989ca667b7..b85d5b187d 100644
--- a/meta/recipes-core/systemd/systemd.inc
+++ b/meta/recipes-core/systemd/systemd.inc
@@ -15,7 +15,7 @@  LICENSE:libsystemd = "LGPL-2.1-or-later"
 LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
                     file://LICENSE.LGPL2.1;md5=4fbd65380cdd255951079008b364516c"
 
-SRCREV = "a2240d1cf9f3515728186c2c98a6f4b64a40e4da"
+SRCREV = "f15fd96efd5ebdfb18746acb0cbb35a4331b4d8b"
 SRCBRANCH = "v256-stable"
 SRC_URI = "git://github.com/systemd/systemd.git;protocol=https;branch=${SRCBRANCH}"
 
diff --git a/meta/recipes-core/systemd/systemd_256.8.bb b/meta/recipes-core/systemd/systemd_256.9.bb
similarity index 100%
rename from meta/recipes-core/systemd/systemd_256.8.bb
rename to meta/recipes-core/systemd/systemd_256.9.bb