diff mbox series

[2/4] vala: Fix install conflict when enable multilib.

Message ID 1677206695-16822-2-git-send-email-wangmy@fujitsu.com
State New
Headers show
Series [1/4] lua: Fix install conflict when enable multilib. | expand

Commit Message

Mingyu Wang (Fujitsu) Feb. 24, 2023, 2:44 a.m. UTC
From: Wang Mingyu <wangmy@fujitsu.com>

Error: Transaction test error:
  file /usr/bin/vala-gen-introspect-0.56 conflicts between attempted installs of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
  file /usr/bin/vapigen-wrapper conflicts between attempted installs of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 meta/recipes-devtools/vala/vala.inc | 3 +++
 1 file changed, 3 insertions(+)

Comments

Richard Purdie Feb. 24, 2023, 10:15 a.m. UTC | #1
On Fri, 2023-02-24 at 10:44 +0800, wangmy wrote:
> From: Wang Mingyu <wangmy@fujitsu.com>
> 
> Error: Transaction test error:
>   file /usr/bin/vala-gen-introspect-0.56 conflicts between attempted installs of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
>   file /usr/bin/vapigen-wrapper conflicts between attempted installs of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
> 
> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> ---
>  meta/recipes-devtools/vala/vala.inc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-devtools/vala/vala.inc b/meta/recipes-devtools/vala/vala.inc
> index d3daee37dc..90689662cb 100644
> --- a/meta/recipes-devtools/vala/vala.inc
> +++ b/meta/recipes-devtools/vala/vala.inc
> @@ -66,3 +66,6 @@ PACKAGE_PREPROCESS_FUNCS += "vala_package_preprocess"
>  vala_package_preprocess () {
>  	sed -i -e 's:${RECIPE_SYSROOT}::g;' ${PKGD}${bindir_crossscripts}/vapigen-wrapper
>  }
> +
> +inherit multilib_script
> +MULTILIB_SCRIPTS = "${PN}:${bindir}/crossscripts/vapigen-wrapper ${PN}:${bindir}/vala-gen-introspect-0.56"

This looks a bit odd since crossscripts wouldn't be installed on the
target?

Also, when posting these kinds of changes, can you show a diff of the
two files please?

Sometimes we can tweak the files so that they can become the same but
it is hard to know without context.

Cheers,

Richard
Mingyu Wang (Fujitsu) Feb. 27, 2023, 6:51 a.m. UTC | #2
> This looks a bit odd since crossscripts wouldn't be installed on the target?
I also feel a little strange. It seems that this file should not be installed on target. But I'm not sure, so I didn't delete this file from target

> Also, when posting these kinds of changes, can you show a diff of the two files
Compare the contents of the two files as follows:
diff -r armv7ahf-neon-pokymllib32-linux-gnueabi/lib32-vala/0.56.4-r0/image/usr/bin/vala-gen-introspect-0.56 cortexa57-poky-linux/vala/0.56.4-r0/image/usr/bin/vala-gen-introspect-0.56:

<libdir=/usr/lib
>libdir=/usr/lib64

  --
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com
http://www.fujitsu.com/cn/fnst/

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org
> <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: Friday, February 24, 2023 6:16 PM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 2/4] vala: Fix install conflict when enable multilib.
> 
> On Fri, 2023-02-24 at 10:44 +0800, wangmy wrote:
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Error: Transaction test error:
> >   file /usr/bin/vala-gen-introspect-0.56 conflicts between attempted installs
> of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
> >   file /usr/bin/vapigen-wrapper conflicts between attempted installs
> > of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> >  meta/recipes-devtools/vala/vala.inc | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-devtools/vala/vala.inc
> > b/meta/recipes-devtools/vala/vala.inc
> > index d3daee37dc..90689662cb 100644
> > --- a/meta/recipes-devtools/vala/vala.inc
> > +++ b/meta/recipes-devtools/vala/vala.inc
> > @@ -66,3 +66,6 @@ PACKAGE_PREPROCESS_FUNCS +=
> "vala_package_preprocess"
> >  vala_package_preprocess () {
> >  	sed -i -e 's:${RECIPE_SYSROOT}::g;'
> > ${PKGD}${bindir_crossscripts}/vapigen-wrapper
> >  }
> > +
> > +inherit multilib_script
> > +MULTILIB_SCRIPTS = "${PN}:${bindir}/crossscripts/vapigen-wrapper
> ${PN}:${bindir}/vala-gen-introspect-0.56"
> 
> This looks a bit odd since crossscripts wouldn't be installed on the target?
> 
> Also, when posting these kinds of changes, can you show a diff of the two files
> please?
> 
> Sometimes we can tweak the files so that they can become the same but it is
> hard to know without context.
> 
> Cheers,
> 
> Richard
Alexander Kanavin Feb. 27, 2023, 9:26 a.m. UTC | #3
You might want to look into why this item gets installed in the first
place. Multilib as its name says is meant for multiple sets of
libraries, but not executables.

Alex

On Mon, 27 Feb 2023 at 07:51, wangmy <wangmy@fujitsu.com> wrote:
>
> > This looks a bit odd since crossscripts wouldn't be installed on the target?
> I also feel a little strange. It seems that this file should not be installed on target. But I'm not sure, so I didn't delete this file from target
>
> > Also, when posting these kinds of changes, can you show a diff of the two files
> Compare the contents of the two files as follows:
> diff -r armv7ahf-neon-pokymllib32-linux-gnueabi/lib32-vala/0.56.4-r0/image/usr/bin/vala-gen-introspect-0.56 cortexa57-poky-linux/vala/0.56.4-r0/image/usr/bin/vala-gen-introspect-0.56:
>
> <libdir=/usr/lib
> >libdir=/usr/lib64
>
>   --
> Best Regards
> ---------------------------------------------------
> Wang Mingyu
> Development Dept.I
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
> TEL: +86+25-86630566-8568
> COINS: 79988548
> FAX: +86+25-83317685
> MAIL: wangmy@fujitsu.com
> http://www.fujitsu.com/cn/fnst/
>
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org
> > <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> > Sent: Friday, February 24, 2023 6:16 PM
> > To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>;
> > openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH 2/4] vala: Fix install conflict when enable multilib.
> >
> > On Fri, 2023-02-24 at 10:44 +0800, wangmy wrote:
> > > From: Wang Mingyu <wangmy@fujitsu.com>
> > >
> > > Error: Transaction test error:
> > >   file /usr/bin/vala-gen-introspect-0.56 conflicts between attempted installs
> > of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
> > >   file /usr/bin/vapigen-wrapper conflicts between attempted installs
> > > of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
> > >
> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > > ---
> > >  meta/recipes-devtools/vala/vala.inc | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/meta/recipes-devtools/vala/vala.inc
> > > b/meta/recipes-devtools/vala/vala.inc
> > > index d3daee37dc..90689662cb 100644
> > > --- a/meta/recipes-devtools/vala/vala.inc
> > > +++ b/meta/recipes-devtools/vala/vala.inc
> > > @@ -66,3 +66,6 @@ PACKAGE_PREPROCESS_FUNCS +=
> > "vala_package_preprocess"
> > >  vala_package_preprocess () {
> > >     sed -i -e 's:${RECIPE_SYSROOT}::g;'
> > > ${PKGD}${bindir_crossscripts}/vapigen-wrapper
> > >  }
> > > +
> > > +inherit multilib_script
> > > +MULTILIB_SCRIPTS = "${PN}:${bindir}/crossscripts/vapigen-wrapper
> > ${PN}:${bindir}/vala-gen-introspect-0.56"
> >
> > This looks a bit odd since crossscripts wouldn't be installed on the target?
> >
> > Also, when posting these kinds of changes, can you show a diff of the two files
> > please?
> >
> > Sometimes we can tweak the files so that they can become the same but it is
> > hard to know without context.
> >
> > Cheers,
> >
> > Richard
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#177774): https://lists.openembedded.org/g/openembedded-core/message/177774
> Mute This Topic: https://lists.openembedded.org/mt/97198850/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Mingyu Wang (Fujitsu) March 2, 2023, 2:01 a.m. UTC | #4
For the solution to this problem, can I delete this file from the target?

  --
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com
http://www.fujitsu.com/cn/fnst/

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org
> <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: Friday, February 24, 2023 6:16 PM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 2/4] vala: Fix install conflict when enable multilib.
> 
> On Fri, 2023-02-24 at 10:44 +0800, wangmy wrote:
> > From: Wang Mingyu <wangmy@fujitsu.com>
> >
> > Error: Transaction test error:
> >   file /usr/bin/vala-gen-introspect-0.56 conflicts between attempted installs
> of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
> >   file /usr/bin/vapigen-wrapper conflicts between attempted installs
> > of lib32-vala-0.56.3-r0.armv7ahf_neon and vala-0.56.3-r0.aarch64
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> >  meta/recipes-devtools/vala/vala.inc | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-devtools/vala/vala.inc
> > b/meta/recipes-devtools/vala/vala.inc
> > index d3daee37dc..90689662cb 100644
> > --- a/meta/recipes-devtools/vala/vala.inc
> > +++ b/meta/recipes-devtools/vala/vala.inc
> > @@ -66,3 +66,6 @@ PACKAGE_PREPROCESS_FUNCS +=
> "vala_package_preprocess"
> >  vala_package_preprocess () {
> >  	sed -i -e 's:${RECIPE_SYSROOT}::g;'
> > ${PKGD}${bindir_crossscripts}/vapigen-wrapper
> >  }
> > +
> > +inherit multilib_script
> > +MULTILIB_SCRIPTS = "${PN}:${bindir}/crossscripts/vapigen-wrapper
> ${PN}:${bindir}/vala-gen-introspect-0.56"
> 
> This looks a bit odd since crossscripts wouldn't be installed on the target?
> 
> Also, when posting these kinds of changes, can you show a diff of the two files
> please?
> 
> Sometimes we can tweak the files so that they can become the same but it is
> hard to know without context.
> 
> Cheers,
> 
> Richard
Alexander Kanavin March 2, 2023, 10:10 a.m. UTC | #5
On Thu, 2 Mar 2023 at 03:01, wangmy <wangmy@fujitsu.com> wrote:
> For the solution to this problem, can I delete this file from the target?

This looks like a packaging or dependencies problem, so before you
act, you need to investigate why these files get installed, and
whether you need two multilib copies of them.

Alex
diff mbox series

Patch

diff --git a/meta/recipes-devtools/vala/vala.inc b/meta/recipes-devtools/vala/vala.inc
index d3daee37dc..90689662cb 100644
--- a/meta/recipes-devtools/vala/vala.inc
+++ b/meta/recipes-devtools/vala/vala.inc
@@ -66,3 +66,6 @@  PACKAGE_PREPROCESS_FUNCS += "vala_package_preprocess"
 vala_package_preprocess () {
 	sed -i -e 's:${RECIPE_SYSROOT}::g;' ${PKGD}${bindir_crossscripts}/vapigen-wrapper
 }
+
+inherit multilib_script
+MULTILIB_SCRIPTS = "${PN}:${bindir}/crossscripts/vapigen-wrapper ${PN}:${bindir}/vala-gen-introspect-0.56"