Message ID | 1667204240-3627-1-git-send-email-wangmy@fujitsu.com |
---|---|
State | New |
Headers | show |
Series | Add nativesdk of systemd-systemctl | expand |
You need to explain the use case. Why is this beneficial to have on oe-core? Alex On Mon, 31 Oct 2022 at 09:17, wangmy <wangmy@fujitsu.com> wrote: > > From: Wang Mingyu <wangmy@fujitsu.com> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > --- > .../systemd/nativesdk-systemd-systemctl.bb | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > new file mode 100644 > index 0000000000..66b5ec5e6e > --- /dev/null > +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > @@ -0,0 +1,17 @@ > +SUMMARY = "Wrapper for enabling systemd services" > + > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" > + > +PR = "r0" > + > +inherit nativesdk > + > +SRC_URI = "file://systemctl" > + > +S = "${WORKDIR}" > + > +do_install() { > + install -d ${D}${bindir} > + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} > +} > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#172293): https://lists.openembedded.org/g/openembedded-core/message/172293 > Mute This Topic: https://lists.openembedded.org/mt/94680777/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
I need to use nativesdk-systemd-systemctl. I added this file in meta-oe, and the maintainers received it. However, they suggested that it was better to contribute to oe-core. -- Best Regards --------------------------------------------------- Wang Mingyu Development Dept.I Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China TEL: +86+25-86630566-8568 COINS: 79988548 FAX: +86+25-83317685 MAIL: wangmy@fujitsu.com http://www.fujitsu.com/cn/fnst/ > -----Original Message----- > From: Alexander Kanavin <alex.kanavin@gmail.com> > Sent: Monday, October 31, 2022 4:24 PM > To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com> > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH] Add nativesdk of systemd-systemctl > > You need to explain the use case. Why is this beneficial to have on oe-core? > > Alex > > On Mon, 31 Oct 2022 at 09:17, wangmy <wangmy@fujitsu.com> wrote: > > > > From: Wang Mingyu <wangmy@fujitsu.com> > > > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > > --- > > .../systemd/nativesdk-systemd-systemctl.bb | 17 > +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > create mode 100644 > > meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > > > diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > new file mode 100644 > > index 0000000000..66b5ec5e6e > > --- /dev/null > > +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > @@ -0,0 +1,17 @@ > > +SUMMARY = "Wrapper for enabling systemd services" > > + > > +LICENSE = "MIT" > > +LIC_FILES_CHKSUM = > "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de > 20420" > > + > > +PR = "r0" > > + > > +inherit nativesdk > > + > > +SRC_URI = "file://systemctl" > > + > > +S = "${WORKDIR}" > > + > > +do_install() { > > + install -d ${D}${bindir} > > + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} } > > -- > > 2.25.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#172293): > > https://lists.openembedded.org/g/openembedded-core/message/172293 > > Mute This Topic: https://lists.openembedded.org/mt/94680777/1686489 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub > > [alex.kanavin@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
You need to explain why this is useful to the broader community. What is the use case? Each addition to oe-core adds to the maintenance costs, so it needs to be justified and explained. Alex On Mon, 31 Oct 2022 at 09:38, wangmy@fujitsu.com <wangmy@fujitsu.com> wrote: > > I need to use nativesdk-systemd-systemctl. > I added this file in meta-oe, and the maintainers received it. > However, they suggested that it was better to contribute to oe-core. > > -- > Best Regards > --------------------------------------------------- > Wang Mingyu > Development Dept.I > Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China > TEL: +86+25-86630566-8568 > COINS: 79988548 > FAX: +86+25-83317685 > MAIL: wangmy@fujitsu.com > http://www.fujitsu.com/cn/fnst/ > > > -----Original Message----- > > From: Alexander Kanavin <alex.kanavin@gmail.com> > > Sent: Monday, October 31, 2022 4:24 PM > > To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com> > > Cc: openembedded-core@lists.openembedded.org > > Subject: Re: [OE-core] [PATCH] Add nativesdk of systemd-systemctl > > > > You need to explain the use case. Why is this beneficial to have on oe-core? > > > > Alex > > > > On Mon, 31 Oct 2022 at 09:17, wangmy <wangmy@fujitsu.com> wrote: > > > > > > From: Wang Mingyu <wangmy@fujitsu.com> > > > > > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > > > --- > > > .../systemd/nativesdk-systemd-systemctl.bb | 17 > > +++++++++++++++++ > > > 1 file changed, 17 insertions(+) > > > create mode 100644 > > > meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > > > > > diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > > b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > > new file mode 100644 > > > index 0000000000..66b5ec5e6e > > > --- /dev/null > > > +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > > @@ -0,0 +1,17 @@ > > > +SUMMARY = "Wrapper for enabling systemd services" > > > + > > > +LICENSE = "MIT" > > > +LIC_FILES_CHKSUM = > > "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de > > 20420" > > > + > > > +PR = "r0" > > > + > > > +inherit nativesdk > > > + > > > +SRC_URI = "file://systemctl" > > > + > > > +S = "${WORKDIR}" > > > + > > > +do_install() { > > > + install -d ${D}${bindir} > > > + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} } > > > -- > > > 2.25.1 > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > View/Reply Online (#172293): > > > https://lists.openembedded.org/g/openembedded-core/message/172293 > > > Mute This Topic: https://lists.openembedded.org/mt/94680777/1686489 > > > Group Owner: openembedded-core+owner@lists.openembedded.org > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub > > > [alex.kanavin@gmail.com] > > > -=-=-=-=-=-=-=-=-=-=-=- > > >
Hello, this causses the following failure on the AB: AssertionError: The following recipes do not have a maintainer assigned to them. Please add an entry to meta/conf/distro/include/maintainers.inc file. nativesdk-systemd-systemctl (/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb) On 31/10/2022 16:17:20+0800, wangmy wrote: > From: Wang Mingyu <wangmy@fujitsu.com> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > --- > .../systemd/nativesdk-systemd-systemctl.bb | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > new file mode 100644 > index 0000000000..66b5ec5e6e > --- /dev/null > +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > @@ -0,0 +1,17 @@ > +SUMMARY = "Wrapper for enabling systemd services" > + > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" > + > +PR = "r0" > + > +inherit nativesdk > + > +SRC_URI = "file://systemctl" > + > +S = "${WORKDIR}" > + > +do_install() { > + install -d ${D}${bindir} > + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} > +} > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#172293): https://lists.openembedded.org/g/openembedded-core/message/172293 > Mute This Topic: https://lists.openembedded.org/mt/94680777/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 31 Oct 2022, at 08:17, wangmy via lists.openembedded.org <wangmy=fujitsu.com@lists.openembedded.org> wrote: > > From: Wang Mingyu <wangmy@fujitsu.com> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > --- > .../systemd/nativesdk-systemd-systemctl.bb | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > new file mode 100644 > index 0000000000..66b5ec5e6e > --- /dev/null > +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > @@ -0,0 +1,17 @@ > +SUMMARY = "Wrapper for enabling systemd services" > + > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" > + > +PR = "r0" > + > +inherit nativesdk > + > +SRC_URI = "file://systemctl" > + > +S = "${WORKDIR}" > + > +do_install() { > + install -d ${D}${bindir} > + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} > +} As the native and nativesdk recipes are almost identical, write a single recipe called systemd-systemctl which uses BBCLASSEXTEND which replaces this recipe and the existing native form. You can then fix the ownership in maintainers to refer to the base recipe, and solve the oe-selftest failure too. Ross
Hi, I think this is not the correct approach, but here are my use cases: I recently discovered that the python script replacement of the native build of systemctl mishandles services with multiple RequiredBy= and WantedBy= clauses in the [Install] section and only creates the symlink for the first service or target in the list. It doesn't matter if there are multiple RequiredBy= or WantedBy= lines, or the services/targets are listed in a single clause line. It also doesn't handle "systemctl set-default custom.target". I need it for some custom images, currently I am setting the target symlink manually in an image postprocess script. With a cross-script setting the proper --root option for calling the native systemctl, both would be solved. Also, to be able to include libfprint / fprintd in Yocto, the native build of systend is needed for the dependency list: libfprint -> libfprint-native (for native generator binaries) -> libgusb-native -> systemd-native (for native libudev) Best regards, Zoltán Böszörményi 2022. 10. 31. 9:52 keltezéssel, Alexander Kanavin írta: > You need to explain why this is useful to the broader community. What > is the use case? Each addition to oe-core adds to the maintenance > costs, so it needs to be justified and explained. > > Alex > > On Mon, 31 Oct 2022 at 09:38, wangmy@fujitsu.com <wangmy@fujitsu.com> wrote: >> >> I need to use nativesdk-systemd-systemctl. >> I added this file in meta-oe, and the maintainers received it. >> However, they suggested that it was better to contribute to oe-core. >> >> -- >> Best Regards >> --------------------------------------------------- >> Wang Mingyu >> Development Dept.I >> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China >> TEL: +86+25-86630566-8568 >> COINS: 79988548 >> FAX: +86+25-83317685 >> MAIL: wangmy@fujitsu.com >> http://www.fujitsu.com/cn/fnst/ >> >>> -----Original Message----- >>> From: Alexander Kanavin <alex.kanavin@gmail.com> >>> Sent: Monday, October 31, 2022 4:24 PM >>> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com> >>> Cc: openembedded-core@lists.openembedded.org >>> Subject: Re: [OE-core] [PATCH] Add nativesdk of systemd-systemctl >>> >>> You need to explain the use case. Why is this beneficial to have on oe-core? >>> >>> Alex >>> >>> On Mon, 31 Oct 2022 at 09:17, wangmy <wangmy@fujitsu.com> wrote: >>>> >>>> From: Wang Mingyu <wangmy@fujitsu.com> >>>> >>>> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> >>>> --- >>>> .../systemd/nativesdk-systemd-systemctl.bb | 17 >>> +++++++++++++++++ >>>> 1 file changed, 17 insertions(+) >>>> create mode 100644 >>>> meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb >>>> >>>> diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb >>>> b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb >>>> new file mode 100644 >>>> index 0000000000..66b5ec5e6e >>>> --- /dev/null >>>> +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb >>>> @@ -0,0 +1,17 @@ >>>> +SUMMARY = "Wrapper for enabling systemd services" >>>> + >>>> +LICENSE = "MIT" >>>> +LIC_FILES_CHKSUM = >>> "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de >>> 20420" >>>> + >>>> +PR = "r0" >>>> + >>>> +inherit nativesdk >>>> + >>>> +SRC_URI = "file://systemctl" >>>> + >>>> +S = "${WORKDIR}" >>>> + >>>> +do_install() { >>>> + install -d ${D}${bindir} >>>> + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} } >>>> -- >>>> 2.25.1 >>>> >>>> >>>> >>>> >>>> >>>> >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>> Links: You receive all messages sent to this group. >>>> View/Reply Online (#172297): https://lists.openembedded.org/g/openembedded-core/message/172297 >>>> Mute This Topic: https://lists.openembedded.org/mt/94680777/3617728 >>>> Group Owner: openembedded-core+owner@lists.openembedded.org >>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [zboszor@pr.hu] >>>> -=-=-=-=-=-=-=-=-=-=-=- >>>>
Sorry, I missed your email. Thanks for telling me how to modify it I already know about this modification, and I will submit the patch again after the test is OK. -- Best Regards --------------------------------------------------- Wang Mingyu Development Dept.I Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China TEL: +86+25-86630566-8568 COINS: 79988548 FAX: +86+25-83317685 MAIL: wangmy@fujitsu.com http://www.fujitsu.com/cn/fnst/ > -----Original Message----- > From: Ross Burton <Ross.Burton@arm.com> > Sent: Tuesday, November 1, 2022 12:19 AM > To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com> > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH] Add nativesdk of systemd-systemctl > > On 31 Oct 2022, at 08:17, wangmy via lists.openembedded.org > <wangmy=fujitsu.com@lists.openembedded.org> wrote: > > > > From: Wang Mingyu <wangmy@fujitsu.com> > > > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com> > > --- > > .../systemd/nativesdk-systemd-systemctl.bb | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > create mode 100644 > > meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > > > diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > new file mode 100644 > > index 0000000000..66b5ec5e6e > > --- /dev/null > > +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb > > @@ -0,0 +1,17 @@ > > +SUMMARY = "Wrapper for enabling systemd services" > > + > > +LICENSE = "MIT" > > +LIC_FILES_CHKSUM = > "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de > 20420" > > + > > +PR = "r0" > > + > > +inherit nativesdk > > + > > +SRC_URI = "file://systemctl" > > + > > +S = "${WORKDIR}" > > + > > +do_install() { > > + install -d ${D}${bindir} > > + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} } > > As the native and nativesdk recipes are almost identical, write a single recipe > called systemd-systemctl which uses BBCLASSEXTEND which replaces this recipe > and the existing native form. > > You can then fix the ownership in maintainers to refer to the base recipe, and > solve the oe-selftest failure too. > > Ross
diff --git a/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb new file mode 100644 index 0000000000..66b5ec5e6e --- /dev/null +++ b/meta/recipes-core/systemd/nativesdk-systemd-systemctl.bb @@ -0,0 +1,17 @@ +SUMMARY = "Wrapper for enabling systemd services" + +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" + +PR = "r0" + +inherit nativesdk + +SRC_URI = "file://systemctl" + +S = "${WORKDIR}" + +do_install() { + install -d ${D}${bindir} + install -m 0755 ${WORKDIR}/systemctl ${D}${bindir} +}