lttng-tools: upgrade 2.13.4 -> 2.13.6

Message ID 1649011392-28818-5-git-send-email-wangmy@fujitsu.com
State New
Headers show
Series lttng-tools: upgrade 2.13.4 -> 2.13.6 | expand

Commit Message

Mingyu Wang (Fujitsu) April 3, 2022, 6:43 p.m. UTC
Changelog:
=========
Fix: hide symbols erroneously exported in 2.13.5

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 .../lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb}      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-kernel/lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb} (98%)

Comments

Alexandre Belloni April 6, 2022, 12:34 p.m. UTC | #1
Hello,

Last time I tried that, we got new ptest failures:

{'lttng-tools': ['kernel/test_callstack_11_-_Validate_userspace_callstack',
                 'kernel/test_userspace_probe_94_-_Enable_kernel_userspace_probe_event_for_session_test_userprobe_elf_cxx_function',
                 'kernel/test_userspace_probe_95_-_Start_tracing_for_session_test_userprobe_elf_cxx_function',
                 'kernel/test_userspace_probe_96_-_Stop_lttng_tracing_for_session_test_userprobe_elf_cxx_function',
                 'kernel/test_userspace_probe_97_-_Validate_trace_for_event_userspace_probe_test_event',
                 'kernel/test_userspace_probe_100_-_Enable_kernel_userspace_probe_event_for_session_test_userprobe_elf_cxx_method',
                 'kernel/test_userspace_probe_101_-_Start_tracing_for_session_test_userprobe_elf_cxx_method',
                 'kernel/test_userspace_probe_102_-_Stop_lttng_tracing_for_session_test_userprobe_elf_cxx_method',
                 'kernel/test_userspace_probe_103_-_Validate_trace_for_event_userspace_probe_test_event']}

Did you have a look at and fix those?

On 04/04/2022 02:43:12+0800, wangmy wrote:
> Changelog:
> =========
> Fix: hide symbols erroneously exported in 2.13.5
> 
> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> ---
>  .../lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb}      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  rename meta/recipes-kernel/lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb} (98%)
> 
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> similarity index 98%
> rename from meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> rename to meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> index 0ea4da05ce..d40d0a2dd0 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> @@ -39,7 +39,7 @@ SRC_URI = "https://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
>             file://disable-tests.patch \
>             "
>  
> -SRC_URI[sha256sum] = "565f3102410a53d484f4c8ff517978f1dc59f67f9d16f872f4357f3ca12200f6"
> +SRC_URI[sha256sum] = "1d52d249437b3f7ba23a45a22c3e26dde006a5da10e96753952084a98e0523e3"
>  
>  inherit autotools ptest pkgconfig useradd python3-dir manpages systemd
>  
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#164067): https://lists.openembedded.org/g/openembedded-core/message/164067
> Mute This Topic: https://lists.openembedded.org/mt/90287422/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Mingyu Wang (Fujitsu) April 6, 2022, 1:18 p.m. UTC | #2
Sorry, I missed this failure. I will investigate it immediately and send it again after solving it

  --
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com
http://www.fujitsu.com/cn/fnst/

> -----Original Message-----
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Sent: Wednesday, April 6, 2022 8:35 PM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] lttng-tools: upgrade 2.13.4 -> 2.13.6
> 
> Hello,
> 
> Last time I tried that, we got new ptest failures:
> 
> {'lttng-tools': ['kernel/test_callstack_11_-_Validate_userspace_callstack',
> 
> 'kernel/test_userspace_probe_94_-_Enable_kernel_userspace_probe_even
> t_for_session_test_userprobe_elf_cxx_function',
> 
> 'kernel/test_userspace_probe_95_-_Start_tracing_for_session_test_userpr
> obe_elf_cxx_function',
> 
> 'kernel/test_userspace_probe_96_-_Stop_lttng_tracing_for_session_test_u
> serprobe_elf_cxx_function',
> 
> 'kernel/test_userspace_probe_97_-_Validate_trace_for_event_userspace_p
> robe_test_event',
> 
> 'kernel/test_userspace_probe_100_-_Enable_kernel_userspace_probe_eve
> nt_for_session_test_userprobe_elf_cxx_method',
> 
> 'kernel/test_userspace_probe_101_-_Start_tracing_for_session_test_userp
> robe_elf_cxx_method',
> 
> 'kernel/test_userspace_probe_102_-_Stop_lttng_tracing_for_session_test_
> userprobe_elf_cxx_method',
> 
> 'kernel/test_userspace_probe_103_-_Validate_trace_for_event_userspace_
> probe_test_event']}
> 
> Did you have a look at and fix those?
> 
> On 04/04/2022 02:43:12+0800, wangmy wrote:
> > Changelog:
> > =========
> > Fix: hide symbols erroneously exported in 2.13.5
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> >  .../lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb}      | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)  rename
> > meta/recipes-kernel/lttng/{lttng-tools_2.13.4.bb =>
> > lttng-tools_2.13.6.bb} (98%)
> >
> > diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> > b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > similarity index 98%
> > rename from meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> > rename to meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > index 0ea4da05ce..d40d0a2dd0 100644
> > --- a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> > +++ b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > @@ -39,7 +39,7 @@ SRC_URI =
> "https://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
> >             file://disable-tests.patch \
> >             "
> >
> > -SRC_URI[sha256sum] =
> "565f3102410a53d484f4c8ff517978f1dc59f67f9d16f872f4357f3ca12200f6"
> > +SRC_URI[sha256sum] =
> "1d52d249437b3f7ba23a45a22c3e26dde006a5da10e96753952084a98e052
> 3e3"
> >
> >  inherit autotools ptest pkgconfig useradd python3-dir manpages
> > systemd
> >
> > --
> > 2.25.1
> >
> 
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#164067):
> https://lists.openembedded.org/g/openembedded-core/message/164067
> > Mute This Topic: https://lists.openembedded.org/mt/90287422/3617179
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub
> [alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
> 
> 
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Alexander Kanavin May 4, 2022, 3:47 p.m. UTC | #3
I have fixed the test_userspace_probe fails, and obtained slightly
more detailed logs for the test_callstack:

not ok 11 - Validate userspace callstack
FAIL: kernel/test_callstack 11 - Validate userspace callstack
#   Failed test 'Validate userspace callstack'
#   in ./kernel/test_callstack:test_user_callstack() at line 80.
# Kernel callstack test

Line 80 in ./tests/regression/kernel/test_callstack is:

        "$BABELTRACE_BIN" "$TRACE_PATH" | grep $EVENT_NAME |
./"$PARSE_CALLSTACK" --user "$TEST_APP_USERSPACE" $USER_CS_EXPECTED
        ok $? "Validate userspace callstack"

I have obtained the failing TRACE_PATH output, and attached it to this
upstream bug:
https://bugs.lttng.org/issues/1353

To unblock the update I'll add a patch that disables the failing test.

Alex


On Wed, 6 Apr 2022 at 14:35, Alexandre Belloni via
lists.openembedded.org
<alexandre.belloni=bootlin.com@lists.openembedded.org> wrote:
>
> Hello,
>
> Last time I tried that, we got new ptest failures:
>
> {'lttng-tools': ['kernel/test_callstack_11_-_Validate_userspace_callstack',
>                  'kernel/test_userspace_probe_94_-_Enable_kernel_userspace_probe_event_for_session_test_userprobe_elf_cxx_function',
>                  'kernel/test_userspace_probe_95_-_Start_tracing_for_session_test_userprobe_elf_cxx_function',
>                  'kernel/test_userspace_probe_96_-_Stop_lttng_tracing_for_session_test_userprobe_elf_cxx_function',
>                  'kernel/test_userspace_probe_97_-_Validate_trace_for_event_userspace_probe_test_event',
>                  'kernel/test_userspace_probe_100_-_Enable_kernel_userspace_probe_event_for_session_test_userprobe_elf_cxx_method',
>                  'kernel/test_userspace_probe_101_-_Start_tracing_for_session_test_userprobe_elf_cxx_method',
>                  'kernel/test_userspace_probe_102_-_Stop_lttng_tracing_for_session_test_userprobe_elf_cxx_method',
>                  'kernel/test_userspace_probe_103_-_Validate_trace_for_event_userspace_probe_test_event']}
>
> Did you have a look at and fix those?
>
> On 04/04/2022 02:43:12+0800, wangmy wrote:
> > Changelog:
> > =========
> > Fix: hide symbols erroneously exported in 2.13.5
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> >  .../lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb}      | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >  rename meta/recipes-kernel/lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb} (98%)
> >
> > diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > similarity index 98%
> > rename from meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> > rename to meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > index 0ea4da05ce..d40d0a2dd0 100644
> > --- a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> > +++ b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > @@ -39,7 +39,7 @@ SRC_URI = "https://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
> >             file://disable-tests.patch \
> >             "
> >
> > -SRC_URI[sha256sum] = "565f3102410a53d484f4c8ff517978f1dc59f67f9d16f872f4357f3ca12200f6"
> > +SRC_URI[sha256sum] = "1d52d249437b3f7ba23a45a22c3e26dde006a5da10e96753952084a98e0523e3"
> >
> >  inherit autotools ptest pkgconfig useradd python3-dir manpages systemd
> >
> > --
> > 2.25.1
> >
>
> >
> >
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#164080): https://lists.openembedded.org/g/openembedded-core/message/164080
> Mute This Topic: https://lists.openembedded.org/mt/90287422/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Alexander Kanavin May 4, 2022, 4:51 p.m. UTC | #4
The issue was that we used a stripped binary where a non-stripped one
is expected. I have corrected this, so the problem was on our side.
Version update patch will be coming in a few.

Alex

On Wed, 4 May 2022 at 17:47, Alexander Kanavin via
lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
wrote:
>
> I have fixed the test_userspace_probe fails, and obtained slightly
> more detailed logs for the test_callstack:
>
> not ok 11 - Validate userspace callstack
> FAIL: kernel/test_callstack 11 - Validate userspace callstack
> #   Failed test 'Validate userspace callstack'
> #   in ./kernel/test_callstack:test_user_callstack() at line 80.
> # Kernel callstack test
>
> Line 80 in ./tests/regression/kernel/test_callstack is:
>
>         "$BABELTRACE_BIN" "$TRACE_PATH" | grep $EVENT_NAME |
> ./"$PARSE_CALLSTACK" --user "$TEST_APP_USERSPACE" $USER_CS_EXPECTED
>         ok $? "Validate userspace callstack"
>
> I have obtained the failing TRACE_PATH output, and attached it to this
> upstream bug:
> https://bugs.lttng.org/issues/1353
>
> To unblock the update I'll add a patch that disables the failing test.
>
> Alex
>
>
> On Wed, 6 Apr 2022 at 14:35, Alexandre Belloni via
> lists.openembedded.org
> <alexandre.belloni=bootlin.com@lists.openembedded.org> wrote:
> >
> > Hello,
> >
> > Last time I tried that, we got new ptest failures:
> >
> > {'lttng-tools': ['kernel/test_callstack_11_-_Validate_userspace_callstack',
> >                  'kernel/test_userspace_probe_94_-_Enable_kernel_userspace_probe_event_for_session_test_userprobe_elf_cxx_function',
> >                  'kernel/test_userspace_probe_95_-_Start_tracing_for_session_test_userprobe_elf_cxx_function',
> >                  'kernel/test_userspace_probe_96_-_Stop_lttng_tracing_for_session_test_userprobe_elf_cxx_function',
> >                  'kernel/test_userspace_probe_97_-_Validate_trace_for_event_userspace_probe_test_event',
> >                  'kernel/test_userspace_probe_100_-_Enable_kernel_userspace_probe_event_for_session_test_userprobe_elf_cxx_method',
> >                  'kernel/test_userspace_probe_101_-_Start_tracing_for_session_test_userprobe_elf_cxx_method',
> >                  'kernel/test_userspace_probe_102_-_Stop_lttng_tracing_for_session_test_userprobe_elf_cxx_method',
> >                  'kernel/test_userspace_probe_103_-_Validate_trace_for_event_userspace_probe_test_event']}
> >
> > Did you have a look at and fix those?
> >
> > On 04/04/2022 02:43:12+0800, wangmy wrote:
> > > Changelog:
> > > =========
> > > Fix: hide symbols erroneously exported in 2.13.5
> > >
> > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > > ---
> > >  .../lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb}      | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >  rename meta/recipes-kernel/lttng/{lttng-tools_2.13.4.bb => lttng-tools_2.13.6.bb} (98%)
> > >
> > > diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > > similarity index 98%
> > > rename from meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> > > rename to meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > > index 0ea4da05ce..d40d0a2dd0 100644
> > > --- a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
> > > +++ b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
> > > @@ -39,7 +39,7 @@ SRC_URI = "https://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
> > >             file://disable-tests.patch \
> > >             "
> > >
> > > -SRC_URI[sha256sum] = "565f3102410a53d484f4c8ff517978f1dc59f67f9d16f872f4357f3ca12200f6"
> > > +SRC_URI[sha256sum] = "1d52d249437b3f7ba23a45a22c3e26dde006a5da10e96753952084a98e0523e3"
> > >
> > >  inherit autotools ptest pkgconfig useradd python3-dir manpages systemd
> > >
> > > --
> > > 2.25.1
> > >
> >
> > >
> > >
> > >
> >
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >
> >
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#165223): https://lists.openembedded.org/g/openembedded-core/message/165223
> Mute This Topic: https://lists.openembedded.org/mt/90287422/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Patch

diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
similarity index 98%
rename from meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
rename to meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
index 0ea4da05ce..d40d0a2dd0 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_2.13.4.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_2.13.6.bb
@@ -39,7 +39,7 @@  SRC_URI = "https://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
            file://disable-tests.patch \
            "
 
-SRC_URI[sha256sum] = "565f3102410a53d484f4c8ff517978f1dc59f67f9d16f872f4357f3ca12200f6"
+SRC_URI[sha256sum] = "1d52d249437b3f7ba23a45a22c3e26dde006a5da10e96753952084a98e0523e3"
 
 inherit autotools ptest pkgconfig useradd python3-dir manpages systemd