| Message ID | 0468feeac5c3c42078b6cf9085f7707de5f09cc9.1763295498.git.liezhi.yang@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] buildhistory.bbclass: Warn when PRSERV_HOST is not enabled | expand |
On Sun, 2025-11-16 at 04:18 -0800, Robert Yang via lists.openembedded.org wrote: > From: Robert Yang <liezhi.yang@windriver.com> > > The version-going-backwards check may fail without PRServer, and it's not easy > to debug, so warn for that. > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > meta/classes/buildhistory.bbclass | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass > index 4a380c10c6..859fded472 100644 > --- a/meta/classes/buildhistory.bbclass > +++ b/meta/classes/buildhistory.bbclass > @@ -57,6 +57,11 @@ BUILDHISTORY_PRESERVE = "latest latest_srcrev sysroot" > PATCH_GIT_USER_EMAIL ?= "buildhistory@oe" > PATCH_GIT_USER_NAME ?= "OpenEmbedded" > > +python() { > + if not d.getVar('PRSERV_HOST'): > + bb.warn('PRServer is not enabled, version-going-backwards check may fail!') > +} > + Shouldn't this be conditional on that test being enabled? Cheers, Richard
diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass index 4a380c10c6..859fded472 100644 --- a/meta/classes/buildhistory.bbclass +++ b/meta/classes/buildhistory.bbclass @@ -57,6 +57,11 @@ BUILDHISTORY_PRESERVE = "latest latest_srcrev sysroot" PATCH_GIT_USER_EMAIL ?= "buildhistory@oe" PATCH_GIT_USER_NAME ?= "OpenEmbedded" +python() { + if not d.getVar('PRSERV_HOST'): + bb.warn('PRServer is not enabled, version-going-backwards check may fail!') +} + # # Write out the contents of the sysroot #