| Message ID | 010101901d23b565-1b4bf3ea-3f04-49f7-95ba-1887fdccc735-000000@us-west-2.amazonses.com |
|---|---|
| State | New |
| Headers | show |
| Series | [AUH] bluez5: upgrading to 5.76 FAILED | expand |
I'm personally interested in this upgrade so took a shot at upgrading locally. The patch *0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch* is very problematic, and the only issue on my end. It started breaking things in BlueZ 5.73. Some of the changes are now in upstream, and some have been removed which creates conflicts. I wonder if this patch is even relevant today? it's ~8 years old After removing the patch, bluez5 builds fine on my end after upgrading via devtool. I can submit a patch to this mailing list for review if it helps
There seems to be another issue introduced in BlueZ 5.73 where --disable-cups is broken. Someone made a pull request but it was never merged https://github.com/bluez/bluez/pull/787 I guess we'll need to patch this. :)
I found a Github issue which is related to the problematic obexd patch: https://github.com/bluez/bluez/issues/806 ( https://github.com/bluez/bluez/issues/806 ) I think the only relevant part of that patch today is to enable the D-bus service when systemd is not in DISTRO_FEATURES.
I'd say just drop the problematic patch. If someone still needs it, they should come up with a correct, rebased version after the fact. Alex On Sun, 30 Jun 2024 at 13:38, Guðni Már Gilbert via lists.openembedded.org <gudnimar=noxmedical.com@lists.openembedded.org> wrote: > > I found a Github issue which is related to the problematic obexd patch: https://github.com/bluez/bluez/issues/806 > > I think the only relevant part of that patch today is to enable the D-bus service when systemd is not in DISTRO_FEATURES. > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#201234): https://lists.openembedded.org/g/openembedded-core/message/201234 > Mute This Topic: https://lists.openembedded.org/mt/106692130/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Then to complete the upgrade there are two tasks: 1) Remove patch file: 0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch 2) Create a patch file for https://marc.info/?l=linux-bluetooth&m=171324504410000&w=2 to fix the issue where --disable-cups option fails the build. This patch is ~3 months old, anyone know if that is unusually long review for the Linux kernel? Might it be worth it to submit a new patch which at least signs the commit? I probably won't be able to look at this until next weekend earliest.
diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-test-gatt-Fix-hung-issue.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-test-gatt-Fix-hung-issue.patch index b1e93dbe19..0dcc4bae75 100644 --- a/meta/recipes-connectivity/bluez5/bluez5/0001-test-gatt-Fix-hung-issue.patch +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-test-gatt-Fix-hung-issue.patch @@ -1,4 +1,4 @@ -From fb583a57f9f4ab956a09e9bb96d89aa13553bf21 Mon Sep 17 00:00:00 2001 +From cc17b454fea7b14a738214273133dfb6c77e6e93 Mon Sep 17 00:00:00 2001 From: Mingli Yu <Mingli.Yu@windriver.com> Date: Fri, 24 Aug 2018 12:04:03 +0800 Subject: [PATCH] test-gatt: Fix hung issue @@ -21,16 +21,15 @@ no action. Upstream-Status: Submitted [https://marc.info/?l=linux-bluetooth&m=153508881804635&w=2] Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com> - --- unit/test-gatt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unit/test-gatt.c b/unit/test-gatt.c -index 5e06d4e..4864d36 100644 +index 1613fbc..25dd614 100644 --- a/unit/test-gatt.c +++ b/unit/test-gatt.c -@@ -4546,7 +4546,7 @@ int main(int argc, char *argv[]) +@@ -4547,7 +4547,7 @@ int main(int argc, char *argv[]) test_server, service_db_1, NULL, raw_pdu(0x03, 0x00, 0x02), raw_pdu(0xbf, 0x00), diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-tests-add-a-target-for-building-tests-without-runnin.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-tests-add-a-target-for-building-tests-without-runnin.patch index 881494a354..89378dab7e 100644 --- a/meta/recipes-connectivity/bluez5/bluez5/0001-tests-add-a-target-for-building-tests-without-runnin.patch +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-tests-add-a-target-for-building-tests-without-runnin.patch @@ -1,20 +1,19 @@ -From 738e73b386352fd90f1f26cc1ee75427cf4dc23b Mon Sep 17 00:00:00 2001 +From 890eb794513bdc8df9b59167013aea6e9763bcfd Mon Sep 17 00:00:00 2001 From: Alexander Kanavin <alex.kanavin@gmail.com> Date: Fri, 1 Apr 2016 17:07:34 +0300 Subject: [PATCH] tests: add a target for building tests without running them Upstream-Status: Inappropriate [oe specific] Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> - --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.am b/Makefile.am -index e738eb3..dab17dd 100644 +index 05d0293..534a340 100644 --- a/Makefile.am +++ b/Makefile.am -@@ -710,6 +710,9 @@ endif +@@ -708,6 +708,9 @@ endif TESTS = $(unit_tests) AM_TESTS_ENVIRONMENT = MALLOC_CHECK_=3 MALLOC_PERTURB_=69 diff --git a/meta/recipes-connectivity/bluez5/bluez5/0004-src-shared-util.c-include-linux-limits.h.patch b/meta/recipes-connectivity/bluez5/bluez5/0004-src-shared-util.c-include-linux-limits.h.patch index 516d859069..637feb6fb8 100644 --- a/meta/recipes-connectivity/bluez5/bluez5/0004-src-shared-util.c-include-linux-limits.h.patch +++ b/meta/recipes-connectivity/bluez5/bluez5/0004-src-shared-util.c-include-linux-limits.h.patch @@ -1,4 +1,4 @@ -From b53df61b41088b68c127ac76cc71683ac3453b9d Mon Sep 17 00:00:00 2001 +From 41a4d6456c68014446afcd68c837049c241fc409 Mon Sep 17 00:00:00 2001 From: Alexander Kanavin <alex@linutronix.de> Date: Mon, 12 Dec 2022 13:10:19 +0100 Subject: [PATCH] src/shared/util.c: include linux/limits.h @@ -8,13 +8,12 @@ systems such as those using musl. Upstream-Status: Submitted [to linux-bluetooth@vger.kernel.org,luiz.von.dentz@intel.com,frederic.danis@collabora.com] Signed-off-by: Alexander Kanavin <alex@linutronix.de> - --- src/shared/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/util.c b/src/shared/util.c -index c0c2c4a..036dc0d 100644 +index ee59b94..84e5820 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -23,6 +23,7 @@ diff --git a/meta/recipes-connectivity/bluez5/bluez5_5.72.bb b/meta/recipes-connectivity/bluez5/bluez5_5.76.bb similarity index 94% rename from meta/recipes-connectivity/bluez5/bluez5_5.72.bb rename to meta/recipes-connectivity/bluez5/bluez5_5.76.bb index 9fda960ea7..86ae191837 100644 --- a/meta/recipes-connectivity/bluez5/bluez5_5.72.bb +++ b/meta/recipes-connectivity/bluez5/bluez5_5.76.bb @@ -1,6 +1,6 @@ require bluez5.inc -SRC_URI[sha256sum] = "499d7fa345a996c1bb650f5c6749e1d929111fa6ece0be0e98687fee6124536e" +SRC_URI[sha256sum] = "55e2c645909ad82d833c42ce85ec20434e0ef0070941b1eab73facdd240bbd63" CVE_STATUS[CVE-2020-24490] = "cpe-incorrect: This issue has kernel fixes rather than bluez fixes"
Hello, this email is a notification from the Auto Upgrade Helper that the automatic attempt to upgrade the recipe *bluez5* to *5.76* has Failed(do_compile). Detailed error information: do_compile failed Next steps: - apply the patch: git am 0001-bluez5-upgrade-5.72-5.76.patch - check the changes to upstream patches and summarize them in the commit message, - compile an image that contains the package - perform some basic sanity tests - amend the patch and sign it off: git commit -s --reset-author --amend - send it to the appropriate mailing list Alternatively, if you believe the recipe should not be upgraded at this time, you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that automatic upgrades would no longer be attempted. Please review the attached files for further information and build/update failures. Any problem please file a bug at https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler Regards, The Upgrade Helper -- >8 -- From f86a21d74b4cbccfc9bb1411bafe7b2c41b44222 Mon Sep 17 00:00:00 2001 From: Upgrade Helper <auh@yoctoproject.org> Date: Sat, 15 Jun 2024 05:11:32 +0000 Subject: [PATCH] bluez5: upgrade 5.72 -> 5.76 --- .../bluez5/bluez5/0001-test-gatt-Fix-hung-issue.patch | 7 +++---- ...ts-add-a-target-for-building-tests-without-runnin.patch | 7 +++---- .../0004-src-shared-util.c-include-linux-limits.h.patch | 5 ++--- .../bluez5/{bluez5_5.72.bb => bluez5_5.76.bb} | 2 +- 4 files changed, 9 insertions(+), 12 deletions(-) rename meta/recipes-connectivity/bluez5/{bluez5_5.72.bb => bluez5_5.76.bb} (94%)