| Message ID | 20261110061608.4043909-1-sunilkumar.dora@windriver.com |
|---|---|
| Headers | show |
| Series | clang/llvm: Upgrade to 23.1.5 | expand |
This patch looks good to me On Mon, Nov 9, 2026 at 10:16 PM Dora, Sunil Kumar via openembedded-core <SunilKumar.Dora=windriver.com@lists.openembedded.org> wrote: > From: Sunil Dora <sunilkumar.dora@windriver.com> > > This moves clang/llvm from 23.1.3 to 23.1.5. All 35 carried patches > apply as is, nothing they touch changed between the two tags. > > 23.1.4 failed the toolchain selftest on all five -tc builders in the two > new tools/extract_symbols/registry-* tests. Their lit config runs the > python cmake found at configure time, the build host python, which is > not there on the target. Other python based tests go through lit's > %python, the python running lit, so this never showed up before. Clang > has the same problem in its own substitutions. > > Patch 2 rewrites the recorded python path to the target one in both > recipes when CLANG_ENABLE_TESTSUITE is set. Patch 3 brings back the > tests excluded only for this reason: 99 pass in clang and 67 in llvm on > target, the other 9 are UpdateTestChecks tests unsupported in this build. > > The extract_symbols config is being fixed upstream in > https://github.com/llvm/llvm-project/pull/240530, but that covers just > those two tests. Clang and the other llvm substitutions still use the > configured python, so the recipe fix covers all of them at once and > leaves nothing to rebase on the next bump. > > Tested locally: clang family, core-image-minimal, spirv-llvm-translator, > rust and mesa for qemux86-64 glibc; musl family and image; lib32-llvm and > openmp with multilib; clang and compiler-rt for qemux86, qemuarm and > qemuarm64. oe-selftest llvm, clang and lld pass on qemux86-64, llvm on > qemux86. On the autobuilder all five -tc builders (qemux86-64, qemux86, > qemuarm, qemuarm64, qemuriscv64) pass the llvm, clang and lld selftests > with the re-enabled tests; multilib, musl-qemuarm64, musl-qemux86 and > musl-qemux86-64 pass as well. > > Sunil Dora (3): > clang/llvm: Upgrade from 23.1.3 to 23.1.5 release > clang/llvm: Point lit at the target python for the test suite > oeqa/selftest/clang: Re-enable tests that only needed the target > python > > meta/conf/distro/include/maintainers.inc | 2 +- > meta/lib/oeqa/selftest/cases/clang.py | 25 -------------------- > meta/recipes-devtools/clang/clang_git.bb | 12 ++++++++++ > meta/recipes-devtools/clang/common-clang.inc | 2 +- > meta/recipes-devtools/clang/common.inc | 2 +- > meta/recipes-devtools/clang/llvm_git.bb | 9 +++++++ > 6 files changed, 24 insertions(+), 28 deletions(-) > > -- > 2.49.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#249900): > https://lists.openembedded.org/g/openembedded-core/message/249900 > Mute This Topic: https://lists.openembedded.org/mt/122189926/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
From: Sunil Dora <sunilkumar.dora@windriver.com> This moves clang/llvm from 23.1.3 to 23.1.5. All 35 carried patches apply as is, nothing they touch changed between the two tags. 23.1.4 failed the toolchain selftest on all five -tc builders in the two new tools/extract_symbols/registry-* tests. Their lit config runs the python cmake found at configure time, the build host python, which is not there on the target. Other python based tests go through lit's %python, the python running lit, so this never showed up before. Clang has the same problem in its own substitutions. Patch 2 rewrites the recorded python path to the target one in both recipes when CLANG_ENABLE_TESTSUITE is set. Patch 3 brings back the tests excluded only for this reason: 99 pass in clang and 67 in llvm on target, the other 9 are UpdateTestChecks tests unsupported in this build. The extract_symbols config is being fixed upstream in https://github.com/llvm/llvm-project/pull/240530, but that covers just those two tests. Clang and the other llvm substitutions still use the configured python, so the recipe fix covers all of them at once and leaves nothing to rebase on the next bump. Tested locally: clang family, core-image-minimal, spirv-llvm-translator, rust and mesa for qemux86-64 glibc; musl family and image; lib32-llvm and openmp with multilib; clang and compiler-rt for qemux86, qemuarm and qemuarm64. oe-selftest llvm, clang and lld pass on qemux86-64, llvm on qemux86. On the autobuilder all five -tc builders (qemux86-64, qemux86, qemuarm, qemuarm64, qemuriscv64) pass the llvm, clang and lld selftests with the re-enabled tests; multilib, musl-qemuarm64, musl-qemux86 and musl-qemux86-64 pass as well. Sunil Dora (3): clang/llvm: Upgrade from 23.1.3 to 23.1.5 release clang/llvm: Point lit at the target python for the test suite oeqa/selftest/clang: Re-enable tests that only needed the target python meta/conf/distro/include/maintainers.inc | 2 +- meta/lib/oeqa/selftest/cases/clang.py | 25 -------------------- meta/recipes-devtools/clang/clang_git.bb | 12 ++++++++++ meta/recipes-devtools/clang/common-clang.inc | 2 +- meta/recipes-devtools/clang/common.inc | 2 +- meta/recipes-devtools/clang/llvm_git.bb | 9 +++++++ 6 files changed, 24 insertions(+), 28 deletions(-)