| Message ID | 20250712125103.3404739-1-adrian.freihofer@siemens.com |
|---|---|
| Headers | show |
| Series | oe-selftest: devtool: split tap detection into function | expand |
On Sat, 12 Jul 2025 at 14:51, Adrian Freihofer via lists.openembedded.org <adrian.freihofer=siemens.com@lists.openembedded.org> wrote: > - Dropped the part which removed the test for the /etc/runqemu-nosudo > file. This was discussed controversially in the patch review meeting. > The file is kind of an API and is used in multiple scripts, not only > by oe-selftest. I'd like to see that argument. runqemu-nosudo is not used in 'multiple scripts', it's used in one other places (runqemu) to determine whether runqemu should attempt creating the devices. Please bring it back, this check does get in the way, and isn't used anywhere else. Alex
On Mon, 14 Jul 2025 at 15:17, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote: > > - Dropped the part which removed the test for the /etc/runqemu-nosudo > > file. This was discussed controversially in the patch review meeting. > > The file is kind of an API and is used in multiple scripts, not only > > by oe-selftest. > > I'd like to see that argument. runqemu-nosudo is not used in 'multiple > scripts', it's used in one other places (runqemu) to determine whether > runqemu should attempt creating the devices. > > Please bring it back, this check does get in the way, and isn't used > anywhere else. But I guess it should be turned into a separate patch, so it can be discussed on its own merit, and not as a bundle with other changes. Alex
From: Adrian Freihofer <adrian.freihofer@siemens.com> Changes compared to the previous v1: - Split the changes into two patches, rather than one patch that makes three changes at once. - Dropped the part which removed the test for the /etc/runqemu-nosudo file. This was discussed controversially in the patch review meeting. The file is kind of an API and is used in multiple scripts, not only by oe-selftest. The first patch (moving the function) is a pre-requisite for https://patchwork.yoctoproject.org/project/Poky/list/?series=36153. Adrian Freihofer (2): oe-selftest: devtool: split tap detection into function oeqa/utils/command: simplify tap detection meta/lib/oeqa/selftest/cases/devtool.py | 14 ++------------ meta/lib/oeqa/utils/commands.py | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 12 deletions(-)