| Message ID | 20250203-b4-support-v2-0-848008ad29ea@cherry.de |
|---|---|
| Headers | show |
| Series | add basic b4 config file | expand |
On Mon, Feb 3, 2025 at 7:18 AM Quentin Schulz via lists.openembedded.org <foss=0leil.net@lists.openembedded.org> wrote: > > This adds very basic support for using b4 in OE-Core. This essentially > just automatically adds the proper mailing list when running b4 prep > --auto-to-cc. > > This also adds the b4 wrapper script that poky will need to use in order > to identify which mailing list a patch needs to be sent to and do some > additional per-patch checks that aren't necessary when running from > vanilla OE-Core. > > Once this is merged, poky will need to merge OE-Core into itself and > override with its own .b4-config that makes use of that script. > > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > Changes in v2: > - add mention to first patch that running patchtest for b4 prep --check > is what we're eventually aiming for, > - add poky b4 wrapper script (it used to be in the patch series for > poky, c.f. https://lore.kernel.org/poky/20250123-b4-support-v1-1-4841f52eccbb@cherry.de/T/#m95d6aa25cc42352416da477cf07d7b3cbd671231 > - poky b4 wrapper script properly identifies patches with files modified > in both OE-Core and other repos part of poky, > - poky b4 wrapper script pretty prints when there's more than one > project modified by a script, instead of lazily printing a Python > list, > - Link to v1: https://lore.kernel.org/r/20250117-b4-support-v1-1-fe74a5f50eb6@cherry.de > > --- > Quentin Schulz (2): > add basic b4 config file > scripts: add b4-wrapper for poky > > .b4-config | 3 + > scripts/b4-wrapper-poky.py | 170 +++++++++++++++++++++++++++++++++++++++++++++ is there anything specific to poky in this script ? if not then it should not use that in name, it will make it confusing. In oe-core we do not refer to particular distros if not needed. > 2 files changed, 173 insertions(+) > --- > base-commit: 30ea609d3357fb3de911f2f6a5e6856c151b976a > change-id: 20250117-b4-support-10de313f53b7 > > Best regards, > -- > Quentin Schulz <quentin.schulz@cherry.de> > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#210655): https://lists.openembedded.org/g/openembedded-core/message/210655 > Mute This Topic: https://lists.openembedded.org/mt/110972445/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Hi Khem, On 2/3/25 8:42 PM, Khem Raj wrote: > On Mon, Feb 3, 2025 at 7:18 AM Quentin Schulz via > lists.openembedded.org <foss=0leil.net@lists.openembedded.org> wrote: >> >> This adds very basic support for using b4 in OE-Core. This essentially >> just automatically adds the proper mailing list when running b4 prep >> --auto-to-cc. >> >> This also adds the b4 wrapper script that poky will need to use in order >> to identify which mailing list a patch needs to be sent to and do some >> additional per-patch checks that aren't necessary when running from >> vanilla OE-Core. >> >> Once this is merged, poky will need to merge OE-Core into itself and >> override with its own .b4-config that makes use of that script. >> >> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> >> --- >> Changes in v2: >> - add mention to first patch that running patchtest for b4 prep --check >> is what we're eventually aiming for, >> - add poky b4 wrapper script (it used to be in the patch series for >> poky, c.f. https://lore.kernel.org/poky/20250123-b4-support-v1-1-4841f52eccbb@cherry.de/T/#m95d6aa25cc42352416da477cf07d7b3cbd671231 >> - poky b4 wrapper script properly identifies patches with files modified >> in both OE-Core and other repos part of poky, >> - poky b4 wrapper script pretty prints when there's more than one >> project modified by a script, instead of lazily printing a Python >> list, >> - Link to v1: https://lore.kernel.org/r/20250117-b4-support-v1-1-fe74a5f50eb6@cherry.de >> >> --- >> Quentin Schulz (2): >> add basic b4 config file >> scripts: add b4-wrapper for poky >> >> .b4-config | 3 + >> scripts/b4-wrapper-poky.py | 170 +++++++++++++++++++++++++++++++++++++++++++++ > > is there anything specific to poky in this script ? if not then it > should not use that in name, it will Yes it is poky specific... > make it confusing. In oe-core we do not refer to particular distros if > not needed. > ...git-repo poky specific, not poky distro specific. Do you have something better to suggest than this? Cheers, Quentin
On Tue, 2025-02-04 at 10:13 +0100, Quentin Schulz via lists.openembedded.org wrote: > On 2/3/25 8:42 PM, Khem Raj wrote: > > On Mon, Feb 3, 2025 at 7:18 AM Quentin Schulz via > > lists.openembedded.org <foss=0leil.net@lists.openembedded.org> wrote: > > > > > > This adds very basic support for using b4 in OE-Core. This essentially > > > just automatically adds the proper mailing list when running b4 prep > > > --auto-to-cc. > > > > > > This also adds the b4 wrapper script that poky will need to use in order > > > to identify which mailing list a patch needs to be sent to and do some > > > additional per-patch checks that aren't necessary when running from > > > vanilla OE-Core. > > > > > > Once this is merged, poky will need to merge OE-Core into itself and > > > override with its own .b4-config that makes use of that script. > > > > > > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > > > --- > > > Changes in v2: > > > - add mention to first patch that running patchtest for b4 prep --check > > > is what we're eventually aiming for, > > > - add poky b4 wrapper script (it used to be in the patch series for > > > poky, c.f. https://lore.kernel.org/poky/20250123-b4-support-v1-1-4841f52eccbb@cherry.de/T/#m95d6aa25cc42352416da477cf07d7b3cbd671231 > > > - poky b4 wrapper script properly identifies patches with files modified > > > in both OE-Core and other repos part of poky, > > > - poky b4 wrapper script pretty prints when there's more than one > > > project modified by a script, instead of lazily printing a Python > > > list, > > > - Link to v1: https://lore.kernel.org/r/20250117-b4-support-v1-1-fe74a5f50eb6@cherry.de > > > > > > --- > > > Quentin Schulz (2): > > > add basic b4 config file > > > scripts: add b4-wrapper for poky > > > > > > .b4-config | 3 + > > > scripts/b4-wrapper-poky.py | 170 +++++++++++++++++++++++++++++++++++++++++++++ > > > > is there anything specific to poky in this script ? if not then it > > should not use that in name, it will > > Yes it is poky specific... > > > make it confusing. In oe-core we do not refer to particular distros if > > not needed. > > > > ...git-repo poky specific, not poky distro specific. Do you have > something better to suggest than this? To be clear, we could "bury" this b4 helper script in some other layer/place. I'm a bit reluctant to do it since I think there are things in here which may help anyone else trying to split a repo into multiple different submission locations, even just as a reference implementation. As such I did suggest it go into core, even if that looks slightly unusual. As Quentin says, we're open to better ideas on naming but I do fairly strongly believe hiding it somewhere else will just confuse things. Cheers, Richard
This adds very basic support for using b4 in OE-Core. This essentially just automatically adds the proper mailing list when running b4 prep --auto-to-cc. This also adds the b4 wrapper script that poky will need to use in order to identify which mailing list a patch needs to be sent to and do some additional per-patch checks that aren't necessary when running from vanilla OE-Core. Once this is merged, poky will need to merge OE-Core into itself and override with its own .b4-config that makes use of that script. Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> --- Changes in v2: - add mention to first patch that running patchtest for b4 prep --check is what we're eventually aiming for, - add poky b4 wrapper script (it used to be in the patch series for poky, c.f. https://lore.kernel.org/poky/20250123-b4-support-v1-1-4841f52eccbb@cherry.de/T/#m95d6aa25cc42352416da477cf07d7b3cbd671231 - poky b4 wrapper script properly identifies patches with files modified in both OE-Core and other repos part of poky, - poky b4 wrapper script pretty prints when there's more than one project modified by a script, instead of lazily printing a Python list, - Link to v1: https://lore.kernel.org/r/20250117-b4-support-v1-1-fe74a5f50eb6@cherry.de --- Quentin Schulz (2): add basic b4 config file scripts: add b4-wrapper for poky .b4-config | 3 + scripts/b4-wrapper-poky.py | 170 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 173 insertions(+) --- base-commit: 30ea609d3357fb3de911f2f6a5e6856c151b976a change-id: 20250117-b4-support-10de313f53b7 Best regards,