mbox series

[0/7] De-globalization of 'devtool'

Message ID 20250112145359.607585-1-chris.laplante@agilent.com
Headers show
Series De-globalization of 'devtool' | expand

Message

chris.laplante@agilent.com Jan. 12, 2025, 2:53 p.m. UTC 
From: Chris Laplante <chris.laplante@agilent.com>

This patchset removes global variables from the 'devtool' script. It
also changes `Context` to be a dataclass.

All devtool self-tests pass, tested via: oe-selftest -r devtool

Chris Laplante (7):
  devtool: un-globalize the 'basepath' variable
  devtool: un-globalize 'workspace' variable
  devtool: un-globalize 'context' variable and convert it to a dataclass
  devtool: un-globalize 'config' variable
  devtool: un-globalize 'plugins' variable
  devtool: misc cleanups
  devtool: remove unused 'config' param from '_create_workspace' method

 scripts/devtool | 88 +++++++++++++++++++++++++------------------------
 1 file changed, 45 insertions(+), 43 deletions(-)

--
2.43.0

Comments

Alexander Kanavin Jan. 13, 2025, 11:31 a.m. UTC | #1 
On Sun, 12 Jan 2025 at 15:55, Chris Laplante via
lists.openembedded.org
<chris.laplante=agilent.com@lists.openembedded.org> wrote:
> This patchset removes global variables from the 'devtool' script. It
> also changes `Context` to be a dataclass.

Thanks, these changes look really nice.

Alex
Mathieu Dubois-Briand Jan. 13, 2025, 2:35 p.m. UTC | #2 
On Sun Jan 12, 2025 at 3:53 PM CET, Chris Laplante via lists.openembedded.org wrote:
> From: Chris Laplante <chris.laplante@agilent.com>
>
> This patchset removes global variables from the 'devtool' script. It
> also changes `Context` to be a dataclass.
>
> All devtool self-tests pass, tested via: oe-selftest -r devtool
>
> Chris Laplante (7):
>   devtool: un-globalize the 'basepath' variable
>   devtool: un-globalize 'workspace' variable
>   devtool: un-globalize 'context' variable and convert it to a dataclass
>   devtool: un-globalize 'config' variable
>   devtool: un-globalize 'plugins' variable
>   devtool: misc cleanups
>   devtool: remove unused 'config' param from '_create_workspace' method
>
>  scripts/devtool | 88 +++++++++++++++++++++++++------------------------
>  1 file changed, 45 insertions(+), 43 deletions(-)
>
> --
> 2.43.0

Hi Chris,

I believe this series is breaking some builds on the autobuilder. We
got the following error:

devtool: error: argument <subcommand>: invalid choice: 'sdk-install' (choose from create-workspace, add, modify, extract, sync, rename, update-recipe, status, reset, finish, edit-recipe, find-recipe, configure-help, import, deploy-target, undeploy-target, build-image, ide-sdk, search, menuconfig, upgrade, latest-version, check-upgrade-status, build, export)

https://valkyrie.yoctoproject.org/#/builders/80/builds/725/steps/13/logs/stdio

Can you have a look at this issue please ?
chris.laplante@agilent.com Jan. 13, 2025, 2:50 p.m. UTC | #3 
Hi Mathieu,

> Hi Chris,
> 
> I believe this series is breaking some builds on the autobuilder. We got the
> following error:
> 
> devtool: error: argument <subcommand>: invalid choice: 'sdk-install' (choose
> from create-workspace, add, modify, extract, sync, rename, update-recipe,
> status, reset, finish, edit-recipe, find-recipe, configure-help, import, deploy-
> target, undeploy-target, build-image, ide-sdk, search, menuconfig, upgrade,
> latest-version, check-upgrade-status, build, export)
> 
> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fvalk
> yrie.yoctoproject.org%2F%23%2Fbuilders%2F80%2Fbuilds%2F725%2Fsteps
> %2F13%2Flogs%2Fstdio&data=05%7C02%7Cchris.laplante%40agilent.com%
> 7C90775d234a164700487a08dd33df95e8%7Ca9c0bc098b46420693512b
> a12fb4a5c0%7C0%7C0%7C638723757571791775%7CUnknown%7CTWFpb
> GZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4z
> MiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=WumZ5
> CzE%2BlW6df%2B0leHeHV9lFyknKFTpDPTWKDueRCU%3D&reserved=0
> 
> Can you have a look at this issue please ?


Absolutely, will do.

Chris
chris.laplante@agilent.com Jan. 13, 2025, 2:51 p.m. UTC | #4 
> 
> On Sun, 12 Jan 2025 at 15:55, Chris Laplante via lists.openembedded.org
> <chris.laplante=agilent.com@lists.openembedded.org> wrote:
> > This patchset removes global variables from the 'devtool' script. It
> > also changes `Context` to be a dataclass.
> 
> Thanks, these changes look really nice.


My pleasure :)

Thanks,
Chris