[PATCHv2,0/5] systemd split networkd package

v2 fixes the build warning

First of all, this patch series fixes a bug in systemd.bbclass that
forces service files with an Also= relationship to be in the same
package. This may often be the case, but as long as the RDEPENDS
between the packages are set correctly, it is no problem to distribute
the service files over several packages.

If service files referenced with Also= are no longer automatically added
to the list of FILES, build errors caused by unpacked files are
expected. A bitbake world has shown that there are only two recipes in
oe-core that use automatic packing: busybox and dropbear. There are 2
patches that fix this.

Also= relation are probably most often used for sockets. Consequently
the systemd.bbclass should also allow to split socket files into
separate packages. However, that's proably practically not used and
would cause tons of packaging errors. Therefore the automatic packaging
feature for sockets is not changed.

The latest patch splits systemd-networkd into its own package. This adds
a little extra complexity, but splitting systemd into packages is a good
step towards making Yocto more usable in binary form.

Adrian Freihofer (5):
  busybox: add klogd service to FILES
  dropbear: add dropbearkey.service to FILES
  systemd.bbclass: refactor adding files
  systemd.bbclass: do not automatically add Also services
  systemd: split networkd into its own package

 meta/classes-recipe/systemd.bbclass           | 28 ++++++++-----------
 meta/recipes-core/busybox/busybox.inc         |  9 +++++-
 .../recipes-core/dropbear/dropbear_2024.86.bb |  2 ++
 meta/recipes-core/systemd/systemd_256.8.bb    | 28 +++++++++++++++++--
 4 files changed, 47 insertions(+), 20 deletions(-)

On Thu, 2024-12-12 at 16:55 +0100, Adrian Freihofer via lists.openembedded.org wrote:
> v2 fixes the build warning
> 
> First of all, this patch series fixes a bug in systemd.bbclass that
> forces service files with an Also= relationship to be in the same
> package. This may often be the case, but as long as the RDEPENDS
> between the packages are set correctly, it is no problem to distribute
> the service files over several packages.
> 
> If service files referenced with Also= are no longer automatically added
> to the list of FILES, build errors caused by unpacked files are
> expected. A bitbake world has shown that there are only two recipes in
> oe-core that use automatic packing: busybox and dropbear. There are 2
> patches that fix this.
> 
> Also= relation are probably most often used for sockets. Consequently
> the systemd.bbclass should also allow to split socket files into
> separate packages. However, that's proably practically not used and
> would cause tons of packaging errors. Therefore the automatic packaging
> feature for sockets is not changed.
> 
> The latest patch splits systemd-networkd into its own package. This adds
> a little extra complexity, but splitting systemd into packages is a good
> step towards making Yocto more usable in binary form.

The changes to busybox and dropbear suggests there are some
considerations needed here from a migration perspective as people
upgrade past this change? Is there some documentation we should be
adding to the migration guide along with these changes?

Cheers,

Richard

Am Fr., 13. Dez. 2024 um 12:18 Uhr schrieb Richard Purdie <
richard.purdie@linuxfoundation.org>:

> On Thu, 2024-12-12 at 16:55 +0100, Adrian Freihofer via
> lists.openembedded.org wrote:
> > v2 fixes the build warning
> >
> > First of all, this patch series fixes a bug in systemd.bbclass that
> > forces service files with an Also= relationship to be in the same
> > package. This may often be the case, but as long as the RDEPENDS
> > between the packages are set correctly, it is no problem to distribute
> > the service files over several packages.
> >
> > If service files referenced with Also= are no longer automatically added
> > to the list of FILES, build errors caused by unpacked files are
> > expected. A bitbake world has shown that there are only two recipes in
> > oe-core that use automatic packing: busybox and dropbear. There are 2
> > patches that fix this.
> >
> > Also= relation are probably most often used for sockets. Consequently
> > the systemd.bbclass should also allow to split socket files into
> > separate packages. However, that's proably practically not used and
> > would cause tons of packaging errors. Therefore the automatic packaging
> > feature for sockets is not changed.
> >
> > The latest patch splits systemd-networkd into its own package. This adds
> > a little extra complexity, but splitting systemd into packages is a good
> > step towards making Yocto more usable in binary form.
>
> The changes to busybox and dropbear suggests there are some
> considerations needed here from a migration perspective as people
> upgrade past this change? Is there some documentation we should be
> adding to the migration guide along with these changes?
>

Yes, there is a certain risk that some recipes will require adjustments.
Maybe something like this would be helpful:

If a systemd service file had referred to other service files by “Also”
starting them, the other service files were automatically added to the
FILES variable of the same package.
This prevents such services from being packaged into different packages.
Therefore, this automatic has been removed for service files (but not for
socket files).
Now all service files must be explicitly added to FILES.

Adrian


>
> Cheers,
>
> Richard
>
>
>