mbox series

[v2,0/6] Remove automake patch that changes path to test-driver

Message ID 20241113144547.3121036-1-olani@axis.com
Headers show
Series Remove automake patch that changes path to test-driver | expand

Message

Ola x Nilsson Nov. 13, 2024, 2:45 p.m. UTC 
From: Ola x Nilsson <olani@axis.com>

Fixes [YOCTO #15635]

The automake patch
"Set relative to top_builddir path in Makefile to access"
sets the default path of `test-driver` to
`$(top_builddir)/$(config_aux_dir)` instead of the normal
`$(top_srcdir)/$(config_aux_dir)`.

This breaks `check test` for Automake projects in generated images.

To reproduce, use core-image-kernel-dev with git added.

git clone https://git.kernel.org/pub/scm/linux/kernel/git/kay/libabc.git
(cd libabc && ./autogen.sh)
mkdir build
cd build
../libabc/configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib
make check

/bin/sh: ./build-aux/test-driver: No such file or directory

Removing the patch makes the checks complete successfully.

Some ptests depend on this patch to find test-driver.  They need to be
addressed individually.  In all cases I've found so far this is just
another sed substitution and should work even before removing the
patch.

I have not verified the ptests in meta-openembedded yet, but I'm
working on it.

Ola x Nilsson (6):
  acl: Fix the ptest path to test-driver
  attr: Fix the ptest path to test-driver
  sed: Fix the ptest path to test-driver
  parted: Fix the ptest path to test-driver
  strace: Fix the ptest path to test-driver
  automake: Remove patch that changes path to test-driver

 ...top_builddir-path-in-Makefile-to-acc.patch | 50 -------------------
 .../automake/automake_1.17.bb                 |  1 -
 meta/recipes-devtools/strace/strace_6.11.bb   |  4 +-
 meta/recipes-extended/parted/parted_3.6.bb    | 16 +++---
 meta/recipes-extended/sed/sed_4.9.bb          |  1 +
 meta/recipes-support/attr/acl_2.3.2.bb        | 10 ++--
 meta/recipes-support/attr/attr.inc            | 11 ++--
 7 files changed, 26 insertions(+), 67 deletions(-)
 delete mode 100644 meta/recipes-devtools/automake/automake/0005-Set-relative-to-top_builddir-path-in-Makefile-to-acc.patch