| Message ID | 20241111083541.291594-1-olani@axis.com |
|---|---|
| Headers | show |
| Series | Remove automake patch that changes path to test-driver | expand |
Thanks, this seems reasonable. Alex On Mon, 11 Nov 2024 at 09:35, Ola x Nilsson via lists.openembedded.org <olani=axis.com@lists.openembedded.org> wrote: > > From: Ola x Nilsson <olani@axis.com> > > Fixes [YOCTO #15635] > > The automake patch > "Set relative to top_builddir path in Makefile to access" > sets the default path of `test-driver` to > `$(top_builddir)/$(config_aux_dir)` instead of the normal > `$(top_srcdir)/$(config_aux_dir)`. > > This breaks `check test` for Automake projects in generated images. > > To reproduce, use core-image-kernel-dev with git added. > > git clone https://git.kernel.org/pub/scm/linux/kernel/git/kay/libabc.git > (cd libabc && ./autogen.sh) > mkdir build > cd build > ../libabc/configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib > make check > > /bin/sh: ./build-aux/test-driver: No such file or directory > > Removing the patch makes the checks complete successfully. > > Some ptests depend on this patch to find test-driver. They need to be > addressed individually. In all cases I've found so far this is just > another sed substitution and should work even before removing the > patch. > > I have not verified the ptests in meta-openembedded yet, but I'm > working on it. > > Ola x Nilsson (5): > attr: Fix the ptest path to test-driver > sed: Fix the ptest path to test-driver > parted: Fix the ptest path to test-driver > strace: Fix the ptest path to test-driver > automake: Remove patch that changes path to test-driver > > ...top_builddir-path-in-Makefile-to-acc.patch | 50 ------------------- > .../automake/automake_1.17.bb | 1 - > meta/recipes-devtools/strace/strace_6.11.bb | 4 +- > meta/recipes-extended/parted/parted_3.6.bb | 16 +++--- > meta/recipes-extended/sed/sed_4.9.bb | 1 + > meta/recipes-support/attr/attr.inc | 11 ++-- > 6 files changed, 20 insertions(+), 63 deletions(-) > delete mode 100644 meta/recipes-devtools/automake/automake/0005-Set-relative-to-top_builddir-path-in-Makefile-to-acc.patch > > -- > 2.39.5 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#206937): https://lists.openembedded.org/g/openembedded-core/message/206937 > Mute This Topic: https://lists.openembedded.org/mt/109511699/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
From: Ola x Nilsson <olani@axis.com> Fixes [YOCTO #15635] The automake patch "Set relative to top_builddir path in Makefile to access" sets the default path of `test-driver` to `$(top_builddir)/$(config_aux_dir)` instead of the normal `$(top_srcdir)/$(config_aux_dir)`. This breaks `check test` for Automake projects in generated images. To reproduce, use core-image-kernel-dev with git added. git clone https://git.kernel.org/pub/scm/linux/kernel/git/kay/libabc.git (cd libabc && ./autogen.sh) mkdir build cd build ../libabc/configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib make check /bin/sh: ./build-aux/test-driver: No such file or directory Removing the patch makes the checks complete successfully. Some ptests depend on this patch to find test-driver. They need to be addressed individually. In all cases I've found so far this is just another sed substitution and should work even before removing the patch. I have not verified the ptests in meta-openembedded yet, but I'm working on it. Ola x Nilsson (5): attr: Fix the ptest path to test-driver sed: Fix the ptest path to test-driver parted: Fix the ptest path to test-driver strace: Fix the ptest path to test-driver automake: Remove patch that changes path to test-driver ...top_builddir-path-in-Makefile-to-acc.patch | 50 ------------------- .../automake/automake_1.17.bb | 1 - meta/recipes-devtools/strace/strace_6.11.bb | 4 +- meta/recipes-extended/parted/parted_3.6.bb | 16 +++--- meta/recipes-extended/sed/sed_4.9.bb | 1 + meta/recipes-support/attr/attr.inc | 11 ++-- 6 files changed, 20 insertions(+), 63 deletions(-) delete mode 100644 meta/recipes-devtools/automake/automake/0005-Set-relative-to-top_builddir-path-in-Makefile-to-acc.patch