| Message ID | 20241017084552.182136-1-mikko.rapeli@linaro.org |
|---|---|
| Headers | show |
| Series | systemd uki support | expand |
On 17 Oct 2024, at 09:45, Mikko Rapeli via lists.openembedded.org <mikko.rapeli=linaro.org@lists.openembedded.org> wrote: > v9: Fixed unrelated ext4 rawcopy wic test on genericarm64. Enabled new aarch64 target > wic test on x86_64 build host only since boot with qemu is currently > failing on aarch64 build host. Sorry, but I don’t think disabling tests based on the build machine is the right thing to do here. My gut reaction is that there is another test that is running with kvm enabled, thus breaking uboot. I’ll do a build on my own machine shortly and see if I can replicate. Ross
Hi, On Tue, Oct 22, 2024 at 10:26:52AM +0000, Ross Burton wrote: > On 17 Oct 2024, at 09:45, Mikko Rapeli via lists.openembedded.org <mikko.rapeli=linaro.org@lists.openembedded.org> wrote: > > v9: Fixed unrelated ext4 rawcopy wic test on genericarm64. Enabled new aarch64 target > > wic test on x86_64 build host only since boot with qemu is currently > > failing on aarch64 build host. > > Sorry, but I don’t think disabling tests based on the build machine is the right thing to do here. Well I'm running out of options to try. > My gut reaction is that there is another test that is running with kvm enabled, thus breaking uboot. I’ll do a build on my own machine shortly and see if I can replicate. IMO this is a generic problem. The selftest code is not fully in control of the bitbake build config, including runqemu. Snippets get enabled here and there. Difficult to know what the effective config in CI is. This also not visible in the AB build logs, or at least I could not find it. Thanks for helping, I hope you can reproduce this. Cheers, -Mikko
On Tue, 2024-10-22 at 22:34 +0300, Mikko Rapeli via lists.openembedded.org wrote: > Hi, > > On Tue, Oct 22, 2024 at 10:26:52AM +0000, Ross Burton wrote: > > On 17 Oct 2024, at 09:45, Mikko Rapeli via lists.openembedded.org <mikko.rapeli=linaro.org@lists.openembedded.org> wrote: > > > v9: Fixed unrelated ext4 rawcopy wic test on genericarm64. Enabled new aarch64 target > > > wic test on x86_64 build host only since boot with qemu is currently > > > failing on aarch64 build host. > > > > Sorry, but I don’t think disabling tests based on the build machine is the right thing to do here. > > Well I'm running out of options to try. > > > My gut reaction is that there is another test that is running with kvm enabled, thus breaking uboot. I’ll do a build on my own machine shortly and see if I can replicate. > > IMO this is a generic problem. The selftest code is not fully in control of > the bitbake build config, including runqemu. Snippets get enabled here and > there. Difficult to know what the effective config in CI is. This also not visible > in the AB build logs, or at least I could not find it. > > Thanks for helping, I hope you can reproduce this. Ross asked for a failing build log, there is one here: https://valkyrie.yoctoproject.org/#/builders/23/builds/306/steps/14/logs/stdio and the config for this is clearly visible here in the step before it: https://valkyrie.yoctoproject.org/#/builders/23/builds/306/steps/13/logs/stdio There isn't anything more being set or any other magic, that is the config and it runs an oe-selftest command (the one at the top of the first link above). Cheers, Richard
These changes enable building systemd uki images which combine kernel, kernel command line, initrd and possibly signatures to a single UEFI binary. This binary can be booted with UEFI firmware and systemd-boot. No grub is needed and UEFI firmware and/or systemd-boot provide possibilities for boot menus. The uki binary can also be signed for UEFI secure boot so the secure boot extends from firmware to kernel and initrd. Binding secure boot to full userspace is then easier since for example kernel command line and initrd contain the support needed to mount encrypted dm-verity etc partitions, and/or create partitions on demand with systemd-repart using device specific TPM devices for encryption. Tested on qemuarm64-secureboot machine from meta-arm with changes to support secure boot. Slightly different configuration tested on multiple arm64 System Ready boards with UEFI firmware, real and firmware based TPM devices. Tested with ovmf firmware on x86_64 with selftests but without secure boot which seems to be harder to setup in ovmf. Sadly I see two wic selftests, wic.Wic2.test_rawcopy_plugin_qemu and wic.Wic2.test_expand_mbr_image, failing when executing all wic selftests on a build machine with zfs filesystem. Will investigate this further. The issue seems to be in mkfs.ext4 producing broken filesystem, and partially in the tests which don't run the correct rootfs file (.ext4 vs .wic). Will debug this further and it is IMO unrelated to these changes since they reproduce on pure master branch without this series. v9: Fixed unrelated ext4 rawcopy wic test on genericarm64. Enabled new aarch64 target wic test on x86_64 build host only since boot with qemu is currently failing on aarch64 build host. Tested wic, uki and efibootpartition selftests with target machines qemux86_64, qemuarm64 and genericarm64 on x86_64 build host. v8: fixed comments from Ross Burton: debug print from warning to debug, dropped duplicate DISTRO_FEATURE setting for systemd in tests, removed aarch64 comment from tests which are currently x86 only. Fixed the new aarch64 wic selftest to run on both genericarm64 and qemuarm64 by adding bios, virtio disk driver etc settings for runqemu (already set in genericarm64 but missing from qemuarm64). v7: add missing "ovmf" to runqemu argument to test_efi_plugin_plain_systemd_boot_qemu_x86 to fix boot hang v6: fixes wic refactoring botch which broken non-uki systemd-boot usage on genericarm64 reported by Ross Burton <Ross.Burton@arm.com>, added selftest to cover this wks usage on x86 and aarch64 v5: drop patch "image_types_wic.bbclass: set systemd-boot and os-release dependency for all archs" since systemd-boot does not support all architectures v4: handle missing runqemu variable from build config, add python3-pefile to fast ptest list v3: rebased, fixed and added more sefltests, removed wic plugin side uki support v2: https://lists.openembedded.org/g/openembedded-core/message/204090 Michelle Lin (1): uki.bbclass: add class for building Unified Kernel Images (UKI) Mikko Rapeli (10): wic bootimg-efi.py: keep timestamps and add debug prints wic bootimg-efi.py: change UKI support from wic plugin to uki.bbclass oeqa selftest uki.py: add tests for uki.bbclass oeqa selftest efibootpartition.py: add TEST_RUNQEMUPARAMS to runqemu oeqa selftest efibootpartition.py: remove systemd-boot from grub-efi test oeqa selftest wic.py: add TEST_RUNQEMUPARAMS to runqemu oeqa selftest wic.py: support UKIs via uki.bbclass oeqa data.py: add skipIfNotBuildArch decorator oeqa selftest wic.py: mark efi tests to run on x86_64 build host only oeqa selftest wic.py: fix missing ext4 image meta-selftest/wic/test_efi_plugin.wks | 5 +- .../test_efi_plugin_plain_systemd-boot.wks | 5 + meta/classes-recipe/image_types_wic.bbclass | 3 +- meta/classes-recipe/uki.bbclass | 195 ++++++++++++++++++ meta/lib/oeqa/core/decorator/data.py | 12 ++ .../oeqa/selftest/cases/efibootpartition.py | 11 +- meta/lib/oeqa/selftest/cases/uki.py | 133 ++++++++++++ meta/lib/oeqa/selftest/cases/wic.py | 138 +++++++++++-- .../wic/canned-wks/efi-uki-bootdisk.wks.in | 3 + scripts/lib/wic/plugins/source/bootimg-efi.py | 183 +++++----------- 10 files changed, 529 insertions(+), 159 deletions(-) create mode 100644 meta-selftest/wic/test_efi_plugin_plain_systemd-boot.wks create mode 100644 meta/classes-recipe/uki.bbclass create mode 100644 meta/lib/oeqa/selftest/cases/uki.py create mode 100644 scripts/lib/wic/canned-wks/efi-uki-bootdisk.wks.in