| Message ID | 20240922155810.1139539-1-adrian.freihofer@siemens.com |
|---|---|
| Headers | show |
| Series | some cleanup for s = workdir | expand |
Great cleanup, thanks Adrian! Ross > On 22 Sep 2024, at 16:43, Adrian Freihofer via lists.openembedded.org <adrian.freihofer=gmail.com@lists.openembedded.org> wrote: > > Removing support for S = ${WORKDIR} allows for the removal of code that > gave me a headache when writing and testing. Having 2 paths (one > direct, one via symlinks) to the source files messed up Pseudo. > The code that is now dropped avoids these corner cases in a very ugly > and probably not 100% reliable way. In any case, it was much more fun > to write this remove commit than to write the commit that added this > function :-). > > While investigating this issue, I found some lines that also seemed > useless. > > Adrian Freihofer (3): > devtool: drop S = WORKDIR workaround > devtool: menuconfig remove useless code > devtool: drop useless variables > > meta/lib/oeqa/selftest/cases/devtool.py | 5 ---- > scripts/lib/devtool/ide_sdk.py | 38 ------------------------- > scripts/lib/devtool/menuconfig.py | 7 +---- > scripts/lib/devtool/standard.py | 3 -- > 4 files changed, 1 insertion(+), 52 deletions(-) > > -- > 2.46.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#204789): https://lists.openembedded.org/g/openembedded-core/message/204789 > Mute This Topic: https://lists.openembedded.org/mt/108592484/6875888 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Removing support for S = ${WORKDIR} allows for the removal of code that gave me a headache when writing and testing. Having 2 paths (one direct, one via symlinks) to the source files messed up Pseudo. The code that is now dropped avoids these corner cases in a very ugly and probably not 100% reliable way. In any case, it was much more fun to write this remove commit than to write the commit that added this function :-). While investigating this issue, I found some lines that also seemed useless. Adrian Freihofer (3): devtool: drop S = WORKDIR workaround devtool: menuconfig remove useless code devtool: drop useless variables meta/lib/oeqa/selftest/cases/devtool.py | 5 ---- scripts/lib/devtool/ide_sdk.py | 38 ------------------------- scripts/lib/devtool/menuconfig.py | 7 +---- scripts/lib/devtool/standard.py | 3 -- 4 files changed, 1 insertion(+), 52 deletions(-)