mbox series

[0/2] volatile-binds: Mitigate workdir cleanup issues

Message ID 20240718064634.7276-1-mark.jonas@de.bosch.com
Headers show
Series volatile-binds: Mitigate workdir cleanup issues | expand

Message

Jonas Mark (BT-FS/ENG1-GRB) July 18, 2024, 6:46 a.m. UTC 
From: Ricardo Simoes <ricardo.simoes@pt.bosch.com>

The recipe `volatile-binds` relies on the `mount-copybind` script
to create volatile mount points. In commit [1], the script was modified
to use OverlayFS as the primary mount strategy. If OverlayFS fails, it
falls back to an old-school bind mount.

To meet the requirements of OverlayFS, the script now unconditionally
creates a workdir. However, the newly created directory is left in
place in case the bind mount strategy is used.

Commit [2] introduced support for avoiding the OverlayFS strategy by
setting the `MOUNT_COPYBIND_AVOID_OVERLAYFS` environment variable.
However, the workdir is unconditionally created.

This patch series addresses both problems. Firstly, it only creates
the workdir if the `MOUNT_COPYBIND_AVOID_OVERLAYFS` variable is not
asserted. Secondly, it unconditionally attempts to remove the workdir
in case a bind mount is done.

[1] b4976f3cf8cd028f165100b67867adb862da4d7f
	volatile-binds: use overlayfs if available

[2] a8e7dca69054798b1c9843a0de889cef3e261c4f
	mount-copybind: add MOUNT_COPYBIND_AVOID_OVERLAYFS env var to
	skip OverlayFS

Ricardo Simoes (2):
  volatile-binds: Do not create workdir if OverlayFS is disabled
  volatile-binds: Remove workdir if OverlayFS fails

 meta/recipes-core/volatile-binds/files/mount-copybind | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)