mbox series

[0/2] Pulseaudio Y2038 fix

Message ID 20240701055553.2851418-1-primoz.fiser@norik.com
Headers show
Series Pulseaudio Y2038 fix | expand

Message

Primoz Fiser July 1, 2024, 5:55 a.m. UTC
Hi,

these 2 patches fix pulseaudio issues with Y2038 compatibility. And in
turn solve run-time issue with "Stack smashing" as described here [1].

Explanation:

Patch #1: Adds PACKAGECONFIG[oss-output] and hence adds configure flag
"-Doss-output=disabled" by default to pulseaudio. This in turn disables
OSS (Open Sound System) support that has been enabled by default since.
However, please note that OSS has long been deprecated in favor or ALSA
and I think we don't even have support for it in the kernel. Moreover,
even Debian disabled OSS wrapper support for 32-bit ARM machines [2].

Patch #2: Re-adds GLIBC_64BIT_TIME_FLAGS for pulseaudio removed by the
poky time64.inc. This has been disabled since pulseaudio didn't build
with those flags enabled [3]. Now, pulseaudio will be Y2038 compatible.

BR,
Primoz

[1] https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/3783
[2] https://salsa.debian.org/pulseaudio-team/pulseaudio/-/commit/5209c2fc46630722f1aaa3c0bbf88a9f843cd27c
[3] https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/3770

Primoz Fiser (2):
  pulseaudio: Add PACKAGECONFIG for optional OSS support
  pulseaudio: Remove from time64.inc exception list

 meta/conf/distro/include/time64.inc               | 5 -----
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 1 +
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Alexander Kanavin July 1, 2024, 9:25 a.m. UTC | #1
Thanks, these look good.

Alex

On Mon, 1 Jul 2024 at 07:56, Primoz Fiser via lists.openembedded.org
<primoz.fiser=norik.com@lists.openembedded.org> wrote:
>
> Hi,
>
> these 2 patches fix pulseaudio issues with Y2038 compatibility. And in
> turn solve run-time issue with "Stack smashing" as described here [1].
>
> Explanation:
>
> Patch #1: Adds PACKAGECONFIG[oss-output] and hence adds configure flag
> "-Doss-output=disabled" by default to pulseaudio. This in turn disables
> OSS (Open Sound System) support that has been enabled by default since.
> However, please note that OSS has long been deprecated in favor or ALSA
> and I think we don't even have support for it in the kernel. Moreover,
> even Debian disabled OSS wrapper support for 32-bit ARM machines [2].
>
> Patch #2: Re-adds GLIBC_64BIT_TIME_FLAGS for pulseaudio removed by the
> poky time64.inc. This has been disabled since pulseaudio didn't build
> with those flags enabled [3]. Now, pulseaudio will be Y2038 compatible.
>
> BR,
> Primoz
>
> [1] https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/3783
> [2] https://salsa.debian.org/pulseaudio-team/pulseaudio/-/commit/5209c2fc46630722f1aaa3c0bbf88a9f843cd27c
> [3] https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/3770
>
> Primoz Fiser (2):
>   pulseaudio: Add PACKAGECONFIG for optional OSS support
>   pulseaudio: Remove from time64.inc exception list
>
>  meta/conf/distro/include/time64.inc               | 5 -----
>  meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 1 +
>  2 files changed, 1 insertion(+), 5 deletions(-)
>
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#201275): https://lists.openembedded.org/g/openembedded-core/message/201275
> Mute This Topic: https://lists.openembedded.org/mt/106973073/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>