Message ID | 20240627221804.599573-1-JPEWhacker@gmail.com |
---|---|
Headers | show |
Series | Update to latest version of SPDX licenses | expand |
On Thu, 2024-06-27 at 16:16 -0600, Joshua Watt via lists.openembedded.org wrote: > Adds a script to read the released SPDX license JSON data, and uses it > to update the common license files > > Joshua Watt (2): > scripts/pull-spdx-licenses.py: Add script > licenses: Update to SPDX license version 3.24.0 Thanks for doing this. It does seem to upset one of the selftests: https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/6871 2024-06-30 21:07:48,909 - oe-selftest - INFO - ====================================================================== 2024-06-30 21:07:48,966 - oe-selftest - INFO - FAIL: spdx.SPDXCheck.test_spdx_base_files (subunit.RemotedTestCase) 2024-06-30 21:07:48,966 - oe-selftest - INFO - ---------------------------------------------------------------------- 2024-06-30 21:07:48,980 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last): File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 55, in test_spdx_base_files self.check_recipe_spdx("packages", "base-files.spdx.json", "base-files") File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 52, in check_recipe_spdx result = check_spdx_json(full_file_path) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 49, in check_spdx_json result = runCmd("{} {} -i {}".format(python, validator, filename)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/utils/commands.py", line 212, in runCmd raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output)) AssertionError: Command '/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/work/x86_64-linux/python3-spdx-tools-native/0.8.2/recipe-sysroot-native/usr/bin/nativepython3 /home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/work/x86_64-linux/python3-spdx-tools-native/0.8.2/recipe-sysroot-native/usr/bin/pyspdxtools -i /home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/deploy/spdx/2.2/qemux86_64/packages/base-files.spdx.json' returned non-zero exit status 1: ERROR:root:There have been issues while parsing the provided document: Error while parsing Document: ['Error while parsing version 3.24.0: 3.24.0 is not a valid version string'] It is coming from here: https://github.com/spdx/tools-python/blob/main/src/spdx_tools/spdx/model/version.py in spdx-tools :/. Cheers, Richard
Ah, right, I should have known that would happen. I'll send the fix On Mon, Jul 1, 2024 at 12:56 AM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > On Thu, 2024-06-27 at 16:16 -0600, Joshua Watt via lists.openembedded.org wrote: > > Adds a script to read the released SPDX license JSON data, and uses it > > to update the common license files > > > > Joshua Watt (2): > > scripts/pull-spdx-licenses.py: Add script > > licenses: Update to SPDX license version 3.24.0 > > Thanks for doing this. It does seem to upset one of the selftests: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/6871 > > 2024-06-30 21:07:48,909 - oe-selftest - INFO - ====================================================================== > 2024-06-30 21:07:48,966 - oe-selftest - INFO - FAIL: spdx.SPDXCheck.test_spdx_base_files (subunit.RemotedTestCase) > 2024-06-30 21:07:48,966 - oe-selftest - INFO - ---------------------------------------------------------------------- > 2024-06-30 21:07:48,980 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last): > File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 55, in test_spdx_base_files > self.check_recipe_spdx("packages", "base-files.spdx.json", "base-files") > File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 52, in check_recipe_spdx > result = check_spdx_json(full_file_path) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/selftest/cases/spdx.py", line 49, in check_spdx_json > result = runCmd("{} {} -i {}".format(python, validator, filename)) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "/home/pokybuild/yocto-worker/oe-selftest-debian/build/meta/lib/oeqa/utils/commands.py", line 212, in runCmd > raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output)) > AssertionError: Command '/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/work/x86_64-linux/python3-spdx-tools-native/0.8.2/recipe-sysroot-native/usr/bin/nativepython3 /home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/work/x86_64-linux/python3-spdx-tools-native/0.8.2/recipe-sysroot-native/usr/bin/pyspdxtools -i /home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-296488/tmp/deploy/spdx/2.2/qemux86_64/packages/base-files.spdx.json' returned non-zero exit status 1: > ERROR:root:There have been issues while parsing the provided document: > Error while parsing Document: ['Error while parsing version 3.24.0: 3.24.0 is not a valid version string'] > > It is coming from here: > > https://github.com/spdx/tools-python/blob/main/src/spdx_tools/spdx/model/version.py > > in spdx-tools :/. > > Cheers, > > Richard