Message ID | 20240619123853.2144538-1-marcus.folkesson@gmail.com |
---|---|
Headers | show |
Series | image-bootfiles: new class | expand |
On Wed, Jun 19, 2024 at 02:38:53PM +0200, Marcus Folkesson via lists.openembedded.org wrote: > image-bootfiles class copy files listed in IMAGE_BOOT_FILES > to the IMAGE_BOOT_FILES_DIR directory of the root filesystem. > > This is useful when there is no explicit boot partition but all boot > files should instead reside inside the root filesystem. > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> Sorry, I forgot the Reviewed-by tag from v4: Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Hi all, On Wed, Jun 19, 2024 at 02:38:51PM +0200, Marcus Folkesson wrote: > The image-bootfiles class is used to put all files listed in > IMAGE_BOOT_FILES into the root filesystem. > > IMAGE_BOOT_FILES is used by the bootimg-partition wic plugin to put the > files into a boot partition. > Be able to list files as "boot files" in e.g. your .conf or image files > instead of install those in every recipe is a good thing. > > It is not always desired to have a separate boot partition for boot > files. Sometimes it could be good to have them as a part of the root > filesystem. > > For example, if a double copy strategy is used for update the system, > then you probably want to update both the boot files and root filesystem > at the same time as there may be dependencies. > > v2: > - Removed the documentation from the patch series (will be submitted later) > - Break out the parts in bootimg-partition that is used by > image-bootfiles to a common library > - Make the destination directory in root filesystem configurable > v3: > - See changelog in patches > > v4: > - See changelog in patches > > v5: > - See changelog in patches > > Marcus Folkesson (2): > bootimg-partition: break out code to a common library. > image-bootfiles.bbclass: new class, copy boot files to root filesystem > > meta/classes/image-bootfiles.bbclass | 41 +++++++++++++ > meta/lib/oe/bootfiles.py | 57 +++++++++++++++++++ > .../wic/plugins/source/bootimg-partition.py | 39 +------------ > 3 files changed, 100 insertions(+), 37 deletions(-) > create mode 100644 meta/classes/image-bootfiles.bbclass > create mode 100644 meta/lib/oe/bootfiles.py > > -- > 2.45.1 > Any more thoughts about these patches? Thank you, Marcus Folkesson
On 02.07.24 11:15, Marcus Folkesson wrote: > Hi all, > > > On Wed, Jun 19, 2024 at 02:38:51PM +0200, Marcus Folkesson wrote: >> The image-bootfiles class is used to put all files listed in >> IMAGE_BOOT_FILES into the root filesystem. >> >> IMAGE_BOOT_FILES is used by the bootimg-partition wic plugin to put the >> files into a boot partition. >> Be able to list files as "boot files" in e.g. your .conf or image files >> instead of install those in every recipe is a good thing. >> >> It is not always desired to have a separate boot partition for boot >> files. Sometimes it could be good to have them as a part of the root >> filesystem. >> >> For example, if a double copy strategy is used for update the system, >> then you probably want to update both the boot files and root filesystem >> at the same time as there may be dependencies. >> >> v2: >> - Removed the documentation from the patch series (will be submitted later) >> - Break out the parts in bootimg-partition that is used by >> image-bootfiles to a common library >> - Make the destination directory in root filesystem configurable >> v3: >> - See changelog in patches >> >> v4: >> - See changelog in patches >> >> v5: >> - See changelog in patches >> >> Marcus Folkesson (2): >> bootimg-partition: break out code to a common library. >> image-bootfiles.bbclass: new class, copy boot files to root filesystem >> >> meta/classes/image-bootfiles.bbclass | 41 +++++++++++++ >> meta/lib/oe/bootfiles.py | 57 +++++++++++++++++++ >> .../wic/plugins/source/bootimg-partition.py | 39 +------------ >> 3 files changed, 100 insertions(+), 37 deletions(-) >> create mode 100644 meta/classes/image-bootfiles.bbclass >> create mode 100644 meta/lib/oe/bootfiles.py >> >> -- >> 2.45.1 >> > > Any more thoughts about these patches? > > Thank you, > Marcus Folkesson LGTM Reviewed-By: Konrad Weihmann <kweihmann@outlook.com>