| Message ID | 20240516072439.2998567-1-philip.lorenz@bmw.de |
|---|---|
| Headers | show |
| Series | package_manager: Clean up shared deb / ipk helpers | expand |
Hi, I haven't received any feedback on this so far and couldn't spot the series in master-next either. I'm not too familiar with the review process so please let me know if you require any further input from my side. Br, Philip On 16.05.24 09:24, Philip Lorenz wrote: > This patch series fixes one issue which I missed in > "lib/package_manager/ipk: Do not hardcode payload compression algorithm" > (2ad05635a6da403b4fadcc126fe7734067c12c73). Default configurations using > zstd are not affected but I'd still like to make sure that things are > cleaned up. > > Additionally, this series cleans up some deb / ipk related code by > moving their common base class to a shared location. This originally > used to be the case, but as part of a larger refactoring, the class was > duplicated into the individual packages. If there was some kind of > rationale for doing this (I couldn't think of one and couldn't figure > this out based on the commit history), please let me know. > > As part of this clean up, the `extract` method is moved into the common > base class to ensure that future adaptations apply to both > specializations. > > Philip Lorenz (3): > ipk: Fix clean up of extracted IPK payload > package_manager: Move OpkgDpkgPM into common module > package_manager: Share more common DEB / IPK code > > meta/lib/oe/package_manager/common_deb_ipk.py | 97 +++++++++++++++++++ > meta/lib/oe/package_manager/deb/__init__.py | 85 +--------------- > meta/lib/oe/package_manager/ipk/__init__.py | 95 +----------------- > 3 files changed, 101 insertions(+), 176 deletions(-) > create mode 100644 meta/lib/oe/package_manager/common_deb_ipk.py >
It's staged here: https://git.yoctoproject.org/poky-contrib/log/?h=abelloni/master-next Maybe it's worth including this link in weekly status emails. Or have poky/master-next-extra which would be directly visible. Alex On Fri, 24 May 2024 at 09:38, Philip Lorenz via lists.openembedded.org <philip.lorenz=bmw.de@lists.openembedded.org> wrote: > > Hi, > > I haven't received any feedback on this so far and couldn't spot the > series in master-next either. I'm not too familiar with the review > process so please let me know if you require any further input from my side. > > Br, > > Philip > > On 16.05.24 09:24, Philip Lorenz wrote: > > This patch series fixes one issue which I missed in > > "lib/package_manager/ipk: Do not hardcode payload compression algorithm" > > (2ad05635a6da403b4fadcc126fe7734067c12c73). Default configurations using > > zstd are not affected but I'd still like to make sure that things are > > cleaned up. > > > > Additionally, this series cleans up some deb / ipk related code by > > moving their common base class to a shared location. This originally > > used to be the case, but as part of a larger refactoring, the class was > > duplicated into the individual packages. If there was some kind of > > rationale for doing this (I couldn't think of one and couldn't figure > > this out based on the commit history), please let me know. > > > > As part of this clean up, the `extract` method is moved into the common > > base class to ensure that future adaptations apply to both > > specializations. > > > > Philip Lorenz (3): > > ipk: Fix clean up of extracted IPK payload > > package_manager: Move OpkgDpkgPM into common module > > package_manager: Share more common DEB / IPK code > > > > meta/lib/oe/package_manager/common_deb_ipk.py | 97 +++++++++++++++++++ > > meta/lib/oe/package_manager/deb/__init__.py | 85 +--------------- > > meta/lib/oe/package_manager/ipk/__init__.py | 95 +----------------- > > 3 files changed, 101 insertions(+), 176 deletions(-) > > create mode 100644 meta/lib/oe/package_manager/common_deb_ipk.py > > > -- > Philip Lorenz > BMW Car IT GmbH, Software-Plattform, -Integration Connected Company, Lise-Meitner-Straße 14, 89081 Ulm > ------------------------------------------------------------------------- > BMW Car IT GmbH > Management: Chris Brandt and Michael Böttrich > Domicile and Court of Registry: München HRB 134810 > ------------------------------------------------------------------------- > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#199829): https://lists.openembedded.org/g/openembedded-core/message/199829 > Mute This Topic: https://lists.openembedded.org/mt/106130311/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >