mbox series

[0/2] Fix: allow specification of dtb directory

Message ID 20230511213614.466484-1-rs@ti.com
Headers show
Series Fix: allow specification of dtb directory | expand

Message

Randolph Sapp May 11, 2023, 9:36 p.m. UTC
From: Randolph Sapp <rs@ti.com>

Fix a few of the oddities introduced by the previous patch that allowed
specification of the DTB install directory and specification of vendor
directories in that directory.

Add a recursive search for dtb and dtbo files to make sure
upstream dtb directory standards don't break our packages.

Makes the kernel-devicetree class posix compliant again by using BB
variables more efficiently.

Martin Jansa (1):
  kernel-devicetree: make shell scripts posix compliant

Randolph Sapp (1):
  kernel-devicetree: recursively search for dtbs

 meta/classes-recipe/kernel-devicetree.bbclass | 26 +++++++++++++------
 meta/classes-recipe/kernel.bbclass            |  2 +-
 2 files changed, 19 insertions(+), 9 deletions(-)

Comments

Alexandre Belloni May 12, 2023, 3:06 p.m. UTC | #1
Hello,

This caused the following failures on the AB:

https://autobuilder.yoctoproject.org/typhoon/#/builders/113/builds/3986/steps/13/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/5176/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/5167/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/7160/steps/11/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/6067/steps/12/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/1406/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/5126/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/5205/steps/14/logs/stdio


2023-05-12 09:01:46,475 - oe-selftest - INFO - fitimage.FitImageTests.test_initramfs_bundle (subunit.RemotedTestCase)
2023-05-12 09:01:46,476 - oe-selftest - INFO -  ... FAIL

and

ERROR: When reparsing /home/pokybuild/yocto-worker/oe-selftest-centos/build/meta/recipes-kernel/linux/linux-yocto_6.1.bb:do_package, the basehash value changed from 856d8373327180fa74e88cff2bbc28b82eb24fb635dc7d3ac16d7a2b7d89ff2e to d2b77c38850e4954edc1422022fb0dbd307742cf2eafac6d8ae699d03d2ce13b. The metadata is not deterministic and this needs to be fixed.
ERROR: The following commands may help:
ERROR: $ bitbake linux-yocto -cdo_package -Snone
ERROR: Then:
ERROR: $ bitbake linux-yocto -cdo_package -Sprintdiff

On 11/05/2023 16:36:12-0500, Randolph Sapp via lists.openembedded.org wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> Fix a few of the oddities introduced by the previous patch that allowed
> specification of the DTB install directory and specification of vendor
> directories in that directory.
> 
> Add a recursive search for dtb and dtbo files to make sure
> upstream dtb directory standards don't break our packages.
> 
> Makes the kernel-devicetree class posix compliant again by using BB
> variables more efficiently.
> 
> Martin Jansa (1):
>   kernel-devicetree: make shell scripts posix compliant
> 
> Randolph Sapp (1):
>   kernel-devicetree: recursively search for dtbs
> 
>  meta/classes-recipe/kernel-devicetree.bbclass | 26 +++++++++++++------
>  meta/classes-recipe/kernel.bbclass            |  2 +-
>  2 files changed, 19 insertions(+), 9 deletions(-)
> 
> -- 
> 2.40.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#181157): https://lists.openembedded.org/g/openembedded-core/message/181157
> Mute This Topic: https://lists.openembedded.org/mt/98837534/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Randolph Sapp May 12, 2023, 5:18 p.m. UTC | #2
On 5/12/23 10:06, Alexandre Belloni wrote:
> Hello,
> 
> This caused the following failures on the AB:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/113/builds/3986/steps/13/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/5176/steps/15/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/5167/steps/14/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/7160/steps/11/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/6067/steps/12/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/1406/steps/14/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/5126/steps/14/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/5205/steps/14/logs/stdio
> 
> 
> 2023-05-12 09:01:46,475 - oe-selftest - INFO - fitimage.FitImageTests.test_initramfs_bundle (subunit.RemotedTestCase)
> 2023-05-12 09:01:46,476 - oe-selftest - INFO -  ... FAIL
> 
> and
> 
> ERROR: When reparsing /home/pokybuild/yocto-worker/oe-selftest-centos/build/meta/recipes-kernel/linux/linux-yocto_6.1.bb:do_package, the basehash value changed from 856d8373327180fa74e88cff2bbc28b82eb24fb635dc7d3ac16d7a2b7d89ff2e to d2b77c38850e4954edc1422022fb0dbd307742cf2eafac6d8ae699d03d2ce13b. The metadata is not deterministic and this needs to be fixed.
> ERROR: The following commands may help:
> ERROR: $ bitbake linux-yocto -cdo_package -Snone
> ERROR: Then:
> ERROR: $ bitbake linux-yocto -cdo_package -Sprintdiff
> 

Right you are. Expect a v2 using a specialized function to avoid the 
metadata change in a minute.

> On 11/05/2023 16:36:12-0500, Randolph Sapp via lists.openembedded.org wrote:
>> From: Randolph Sapp <rs@ti.com>
>>
>> Fix a few of the oddities introduced by the previous patch that allowed
>> specification of the DTB install directory and specification of vendor
>> directories in that directory.
>>
>> Add a recursive search for dtb and dtbo files to make sure
>> upstream dtb directory standards don't break our packages.
>>
>> Makes the kernel-devicetree class posix compliant again by using BB
>> variables more efficiently.
>>
>> Martin Jansa (1):
>>    kernel-devicetree: make shell scripts posix compliant
>>
>> Randolph Sapp (1):
>>    kernel-devicetree: recursively search for dtbs
>>
>>   meta/classes-recipe/kernel-devicetree.bbclass | 26 +++++++++++++------
>>   meta/classes-recipe/kernel.bbclass            |  2 +-
>>   2 files changed, 19 insertions(+), 9 deletions(-)
>>
>> -- 
>> 2.40.1
>>
> 
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#181157): https://lists.openembedded.org/g/openembedded-core/message/181157
>> Mute This Topic: https://lists.openembedded.org/mt/98837534/3617179
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
> 
>